From: "Ludovic Courtès" <ludo@gnu.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: 35244@debbugs.gnu.org
Subject: [bug#35244] [PATCH 2/6] gnu: groff: Fix cross compilation.
Date: Sun, 14 Apr 2019 17:22:52 +0200 [thread overview]
Message-ID: <87muksk3w3.fsf@gnu.org> (raw)
In-Reply-To: <20190412131556.25282-2-m.othacehe@gmail.com> (Mathieu Othacehe's message of "Fri, 12 Apr 2019 15:15:52 +0200")
Hi,
Mathieu Othacehe <m.othacehe@gmail.com> skribis:
> * gnu/packages/groff.scm (groff)[arguments]: Replace build phase to pass
> GROFF_BIN_PATH and GROFFBIN variables when cross-compiling.
>
> Also add native groff as an input.
You’d need to mention ‘self-native-input?’ explicitly.
> + (self-native-input? #t)
However, this field no longer exists: see commit
a7646bc5e17a829d23519d0b199a576fb1edbd04, and see
528ea990c3a815cb4b0ded913ea22cdc778839bd for how to adjust your package.
> + (replace 'build
> + (lambda* (#:key
> + make-flags parallel-build?
> + native-inputs target #:allow-other-keys)
> + ;; When cross-compiling, native groff is needed, see:
> + ;; http://www.mail-archive.com/bug-groff@gnu.org/msg01335.html
> + (let ((parallel
> + (if parallel-build?
> + `("-j" ,(number->string (parallel-job-count)))
> + '()))
> + (flags
> + (if target
> + (let ((groff (or
> + (assoc-ref native-inputs "groff")
> + (assoc-ref native-inputs "self"))))
> + (append
> + make-flags
> + (list
> + (string-append "GROFF_BIN_PATH=" groff)
> + (string-append "GROFFBIN=" groff
> + "/bin/groff"))))
> + make-flags)))
> + (apply invoke `("make" ,@parallel ,@flags)))
If you make it conditional on (%current-target-system) , that’ll avoid a
massive rebuild of the 4K packages that depend on ‘groff’, and thus
it’ll be applicable on ‘master’.
Could you send an updated patch?
Thanks,
Ludo’.
next prev parent reply other threads:[~2019-04-14 15:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 13:13 [bug#35244] [PATCH 0/6] Fix some cross-compilation issues Mathieu Othacehe
2019-04-12 13:15 ` [bug#35244] [PATCH 1/6] gnu: bash-completion: Fix cross-compilation Mathieu Othacehe
2019-04-12 13:15 ` [bug#35244] [PATCH 2/6] gnu: groff: Fix cross compilation Mathieu Othacehe
2019-04-14 15:22 ` Ludovic Courtès [this message]
2019-04-12 13:15 ` [bug#35244] [PATCH 3/6] gnu: glibc-utf8-locales: Always use native package Mathieu Othacehe
2019-04-14 15:24 ` Ludovic Courtès
2019-04-12 13:15 ` [bug#35244] [PATCH 4/6] gnu: firmware: Fix cross compilation Mathieu Othacehe
2019-04-14 15:26 ` Ludovic Courtès
2019-04-12 13:15 ` [bug#35244] [PATCH 5/6] linux-initrd: " Mathieu Othacehe
2019-04-14 15:29 ` Ludovic Courtès
2019-06-25 19:47 ` Mathieu Othacehe
2019-06-26 8:57 ` Ludovic Courtès
2019-04-12 13:15 ` [bug#35244] [PATCH 6/6] gnu: python: " Mathieu Othacehe
2019-04-14 15:27 ` Ludovic Courtès
2019-04-14 15:19 ` [bug#35244] [PATCH 1/6] gnu: bash-completion: Fix cross-compilation Ludovic Courtès
2019-06-25 19:42 ` Mathieu Othacehe
2019-06-26 8:19 ` [bug#35244] [PATCH] gnu: perl: " Mathieu Othacehe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87muksk3w3.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=35244@debbugs.gnu.org \
--cc=m.othacehe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).