From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:54306)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hFgzD-00044V-G0
	for guix-patches@gnu.org; Sun, 14 Apr 2019 11:24:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hFgzC-0000SD-Cq
	for guix-patches@gnu.org; Sun, 14 Apr 2019 11:24:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:47679)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1hFgzC-0000Rx-70
	for guix-patches@gnu.org; Sun, 14 Apr 2019 11:24:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hFgzB-0000ng-TU
	for guix-patches@gnu.org; Sun, 14 Apr 2019 11:24:01 -0400
Subject: [bug#35244] [PATCH 2/6] gnu: groff: Fix cross compilation.
Resent-Message-ID: <handler.35244.B35244.15552553842997@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20190412131556.25282-1-m.othacehe@gmail.com>
	<20190412131556.25282-2-m.othacehe@gmail.com>
Date: Sun, 14 Apr 2019 17:22:52 +0200
In-Reply-To: <20190412131556.25282-2-m.othacehe@gmail.com> (Mathieu Othacehe's
	message of "Fri, 12 Apr 2019 15:15:52 +0200")
Message-ID: <87muksk3w3.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: 35244@debbugs.gnu.org

Hi,

Mathieu Othacehe <m.othacehe@gmail.com> skribis:

> * gnu/packages/groff.scm (groff)[arguments]: Replace build phase to pass
> GROFF_BIN_PATH and GROFFBIN variables when cross-compiling.
>
> Also add native groff as an input.

You=E2=80=99d need to mention =E2=80=98self-native-input?=E2=80=99 explicit=
ly.

> +   (self-native-input? #t)

However, this field no longer exists: see commit
a7646bc5e17a829d23519d0b199a576fb1edbd04, and see
528ea990c3a815cb4b0ded913ea22cdc778839bd for how to adjust your package.

> +         (replace 'build
> +           (lambda* (#:key
> +                     make-flags parallel-build?
> +                     native-inputs target #:allow-other-keys)
> +             ;; When cross-compiling, native groff is needed, see:
> +             ;; http://www.mail-archive.com/bug-groff@gnu.org/msg01335.h=
tml
> +             (let ((parallel
> +                    (if parallel-build?
> +                        `("-j" ,(number->string (parallel-job-count)))
> +                        '()))
> +                   (flags
> +                    (if target
> +                        (let ((groff (or
> +                                      (assoc-ref native-inputs "groff")
> +                                      (assoc-ref native-inputs "self"))))
> +                          (append
> +                           make-flags
> +                           (list
> +                            (string-append "GROFF_BIN_PATH=3D" groff)
> +                            (string-append "GROFFBIN=3D" groff
> +                                           "/bin/groff"))))
> +                        make-flags)))
> +               (apply invoke `("make" ,@parallel ,@flags)))

If you make it conditional on (%current-target-system) , that=E2=80=99ll av=
oid a
massive rebuild of the 4K packages that depend on =E2=80=98groff=E2=80=99, =
and thus
it=E2=80=99ll be applicable on =E2=80=98master=E2=80=99.

Could you send an updated patch?

Thanks,
Ludo=E2=80=99.