unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: guy fleury iteriteka <hoonandon@gmail.com>
Cc: 35878@debbugs.gnu.org
Subject: [bug#35878] [PATCH] gnu: Add chafa.
Date: Mon, 27 May 2019 16:52:33 +0200	[thread overview]
Message-ID: <87muj8t0em.fsf@gnu.org> (raw)
In-Reply-To: <20190524093307.4345-1-hoonandon@gmail.com> (guy fleury iteriteka's message of "Fri, 24 May 2019 11:33:07 +0200")

[-- Attachment #1: Type: text/plain, Size: 434 bytes --]

Hi,

guy fleury iteriteka <hoonandon@gmail.com> skribis:

> * gnu/packages/image-viewers.scm(chaffa): New variable.

I’d suggest the changes below.

Additionally, this code detects SSE4.1 and related instruction set
extensions at configuration time.  As a result, I think the resulting
code may not run on all x86_64 machines.

Could you investigate this and see how we can get a generic binary?

Thanks,
Ludo’.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 942 bytes --]

diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.scm
index fc94242ac6..d947f2d7eb 100644
--- a/gnu/packages/image-viewers.scm
+++ b/gnu/packages/image-viewers.scm
@@ -446,12 +446,12 @@ including CBZ, CB7, CBT, LHA.")
     (native-inputs
      `(("pkg-config" ,pkg-config)))
     (inputs
-     `(("glib"        ,glib)
+     `(("glib" ,glib)
        ("imagemagick" ,imagemagick)))
-    (synopsis "Terminal Graphics for the 21st Century")
+    (synopsis "Convert images to ANSI/Unicode characters")
     (description
-     "Chafa is a command-line utility that converts all kinds of images, 
-including animated GIFs, into ANSI/Unicode character output that can be 
+     "Chafa is a command-line utility that converts all kinds of images,
+including animated GIFs, into ANSI/Unicode character output that can be
 displayed in a terminal.")
     (home-page "https://hpjansson.org/chafa/")
     (license license:lgpl3+)))

  reply	other threads:[~2019-05-27 14:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-24  9:33 [bug#35878] [PATCH] gnu: Add chafa guy fleury iteriteka
2019-05-27 14:52 ` Ludovic Courtès [this message]
2019-05-29  7:44   ` guy fleury iteriteka
2019-06-29 15:23     ` guy fleury iteriteka
2019-07-02 15:19       ` bug#35878: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87muj8t0em.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=35878@debbugs.gnu.org \
    --cc=hoonandon@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).