From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:50136)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hVGzn-0001dy-Bz
	for guix-patches@gnu.org; Mon, 27 May 2019 10:53:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hVGzm-0007Ny-90
	for guix-patches@gnu.org; Mon, 27 May 2019 10:53:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:40226)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1hVGzm-0007Nu-6q
	for guix-patches@gnu.org; Mon, 27 May 2019 10:53:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hVGzm-00089r-3w
	for guix-patches@gnu.org; Mon, 27 May 2019 10:53:02 -0400
Subject: [bug#35878] [PATCH] gnu: Add chafa.
Resent-Message-ID: <handler.35878.B35878.155896876231322@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20190524093307.4345-1-hoonandon@gmail.com>
Date: Mon, 27 May 2019 16:52:33 +0200
In-Reply-To: <20190524093307.4345-1-hoonandon@gmail.com> (guy fleury
	iteriteka's message of "Fri, 24 May 2019 11:33:07 +0200")
Message-ID: <87muj8t0em.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: guy fleury iteriteka <hoonandon@gmail.com>
Cc: 35878@debbugs.gnu.org

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hi,

guy fleury iteriteka <hoonandon@gmail.com> skribis:

> * gnu/packages/image-viewers.scm(chaffa): New variable.

I=E2=80=99d suggest the changes below.

Additionally, this code detects SSE4.1 and related instruction set
extensions at configuration time.  As a result, I think the resulting
code may not run on all x86_64 machines.

Could you investigate this and see how we can get a generic binary?

Thanks,
Ludo=E2=80=99.


--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline

diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.scm
index fc94242ac6..d947f2d7eb 100644
--- a/gnu/packages/image-viewers.scm
+++ b/gnu/packages/image-viewers.scm
@@ -446,12 +446,12 @@ including CBZ, CB7, CBT, LHA.")
     (native-inputs
      `(("pkg-config" ,pkg-config)))
     (inputs
-     `(("glib"        ,glib)
+     `(("glib" ,glib)
        ("imagemagick" ,imagemagick)))
-    (synopsis "Terminal Graphics for the 21st Century")
+    (synopsis "Convert images to ANSI/Unicode characters")
     (description
-     "Chafa is a command-line utility that converts all kinds of images, 
-including animated GIFs, into ANSI/Unicode character output that can be 
+     "Chafa is a command-line utility that converts all kinds of images,
+including animated GIFs, into ANSI/Unicode character output that can be
 displayed in a terminal.")
     (home-page "https://hpjansson.org/chafa/")
     (license license:lgpl3+)))

--=-=-=--