unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#37409] [PATCH] gnu: guile-email: Add phase to patch the module directory.
@ 2019-09-15 12:33 Christopher Baines
  2019-09-16  7:56 ` Ludovic Courtès
  2019-09-16  8:37 ` [bug#37409] " Arun Isaac
  0 siblings, 2 replies; 5+ messages in thread
From: Christopher Baines @ 2019-09-15 12:33 UTC (permalink / raw)
  To: 37409

Otherwise the .go files appear within share, and Guile doesn't find them. With
this patch they appear in lib within the output. One thing this means is that
stack traces include the filenames.

* gnu/packages/guile-xyz.scm (guile-email)[arguments]: Add 'patch-module-dir
phase.
---
 gnu/packages/guile-xyz.scm | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index b765ef36e1..4fa2759205 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -927,7 +927,16 @@ tracker's SOAP service, such as @url{https://bugs.gnu.org}.")
     (inputs
      `(("guile" ,guile-2.2)))
     (arguments
-     '(#:make-flags '("GUILE_AUTO_COMPILE=0"))) ; to prevent guild warnings
+     '(#:make-flags '("GUILE_AUTO_COMPILE=0") ; to prevent guild warnings
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'configure 'patch-module-dir
+           (lambda _
+             (substitute* "Makefile.in"
+               (("^godir = ([[:graph:]]+)")
+                "godir = \
+$(libdir)/guile/@GUILE_EFFECTIVE_VERSION@/site-ccache\n"))
+             #t)))))
     (home-page "https://guile-email.systemreboot.net")
     (synopsis "Guile email parser")
     (description "guile-email is a collection of email utilities implemented
-- 
2.23.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [bug#37409] [PATCH] gnu: guile-email: Add phase to patch the module directory.
  2019-09-15 12:33 [bug#37409] [PATCH] gnu: guile-email: Add phase to patch the module directory Christopher Baines
@ 2019-09-16  7:56 ` Ludovic Courtès
  2019-09-21 16:37   ` bug#37409: " Christopher Baines
  2019-09-16  8:37 ` [bug#37409] " Arun Isaac
  1 sibling, 1 reply; 5+ messages in thread
From: Ludovic Courtès @ 2019-09-16  7:56 UTC (permalink / raw)
  To: Christopher Baines; +Cc: 37409

Hello,

Christopher Baines <mail@cbaines.net> skribis:

> Otherwise the .go files appear within share, and Guile doesn't find them. With
> this patch they appear in lib within the output. One thing this means is that
> stack traces include the filenames.
>
> * gnu/packages/guile-xyz.scm (guile-email)[arguments]: Add 'patch-module-dir
> phase.

LGTM!

Ludo’.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#37409] [PATCH] gnu: guile-email: Add phase to patch the module directory.
  2019-09-15 12:33 [bug#37409] [PATCH] gnu: guile-email: Add phase to patch the module directory Christopher Baines
  2019-09-16  7:56 ` Ludovic Courtès
@ 2019-09-16  8:37 ` Arun Isaac
  2019-09-21 16:37   ` Christopher Baines
  1 sibling, 1 reply; 5+ messages in thread
From: Arun Isaac @ 2019-09-16  8:37 UTC (permalink / raw)
  To: Christopher Baines; +Cc: 37409

[-- Attachment #1: Type: text/plain, Size: 335 bytes --]


> Otherwise the .go files appear within share, and Guile doesn't find them. With
> this patch they appear in lib within the output. One thing this means is that
> stack traces include the filenames.

LGTM! I'll also make this modification to guile-email upstream so this
phase won't be necessary after the next update of guile-email.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#37409: [PATCH] gnu: guile-email: Add phase to patch the module directory.
  2019-09-16  7:56 ` Ludovic Courtès
@ 2019-09-21 16:37   ` Christopher Baines
  0 siblings, 0 replies; 5+ messages in thread
From: Christopher Baines @ 2019-09-21 16:37 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 37409-done

[-- Attachment #1: Type: text/plain, Size: 503 bytes --]


Ludovic Courtès <ludo@gnu.org> writes:

> Hello,
>
> Christopher Baines <mail@cbaines.net> skribis:
>
>> Otherwise the .go files appear within share, and Guile doesn't find them. With
>> this patch they appear in lib within the output. One thing this means is that
>> stack traces include the filenames.
>>
>> * gnu/packages/guile-xyz.scm (guile-email)[arguments]: Add 'patch-module-dir
>> phase.
>
> LGTM!

Great, I've pushed this now (as
c219104c7803cd31ab1cf4bef142a8fbf8ed5b7a).

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#37409] [PATCH] gnu: guile-email: Add phase to patch the module directory.
  2019-09-16  8:37 ` [bug#37409] " Arun Isaac
@ 2019-09-21 16:37   ` Christopher Baines
  0 siblings, 0 replies; 5+ messages in thread
From: Christopher Baines @ 2019-09-21 16:37 UTC (permalink / raw)
  To: Arun Isaac; +Cc: 37409

[-- Attachment #1: Type: text/plain, Size: 417 bytes --]


Arun Isaac <arunisaac@systemreboot.net> writes:

>> Otherwise the .go files appear within share, and Guile doesn't find them. With
>> this patch they appear in lib within the output. One thing this means is that
>> stack traces include the filenames.
>
> LGTM! I'll also make this modification to guile-email upstream so this
> phase won't be necessary after the next update of guile-email.

Awesome, thanks Arun :)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-09-21 16:38 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-15 12:33 [bug#37409] [PATCH] gnu: guile-email: Add phase to patch the module directory Christopher Baines
2019-09-16  7:56 ` Ludovic Courtès
2019-09-21 16:37   ` bug#37409: " Christopher Baines
2019-09-16  8:37 ` [bug#37409] " Arun Isaac
2019-09-21 16:37   ` Christopher Baines

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).