unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#38116] [PATCH] gnu: jalv: Fix gtkmm, add gtk+-2 and qtbase.
@ 2019-11-08  9:14 Alexandros Theodotou
  2019-11-10 22:39 ` bug#38116: " Marius Bakke
  0 siblings, 1 reply; 2+ messages in thread
From: Alexandros Theodotou @ 2019-11-08  9:14 UTC (permalink / raw)
  To: 38116

The gtkmm passed to inputs was unused. Jalv does not support gtkmm 3 at 
the moment.

Also, Jalv is the main tool LV2 plugin developers use to test their 
plugins. Having more variants
(qt5, gtk2) means you have more types of hosts to test your plugins in 
so this is an
extremely useful addition.

 From 2ec5fb34c2600c893763ae95d69bf2bd77d17b61 Mon Sep 17 00:00:00 2001
 From: Alexandros Theodotou <alex@zrythm.org>
Date: Fri, 8 Nov 2019 09:05:10 +0000
Subject: [PATCH] gnu: jalv: Fix gtkmm, add gtk+-2 and qtbase.

* gnu/packages/audio.scm (jalv)[inputs]:
Add gtk+-2 and qtbase.
Change unused gtkmm to gtkmm-2.
---
  gnu/packages/audio.scm | 6 ++++--
  1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 28dbf06f3b..ca2d86d525 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -1599,8 +1599,10 @@ synchronous execution of all clients, and low 
latency operation.")
       `(("lv2" ,lv2)
         ("lilv" ,lilv)
         ("suil" ,suil)
-       ("gtk" ,gtk+)
-       ("gtkmm" ,gtkmm)
+       ("gtk2" ,gtk+-2)
+       ("gtk3" ,gtk+)
+       ("gtkmm" ,gtkmm-2)
+       ("qtbase" ,qtbase)
         ("jack" ,jack-1)))
      (native-inputs
       `(("pkg-config" ,pkg-config)))
-- 
2.24.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#38116: [PATCH] gnu: jalv: Fix gtkmm, add gtk+-2 and qtbase.
  2019-11-08  9:14 [bug#38116] [PATCH] gnu: jalv: Fix gtkmm, add gtk+-2 and qtbase Alexandros Theodotou
@ 2019-11-10 22:39 ` Marius Bakke
  0 siblings, 0 replies; 2+ messages in thread
From: Marius Bakke @ 2019-11-10 22:39 UTC (permalink / raw)
  To: Alexandros Theodotou, 38116-done

[-- Attachment #1: Type: text/plain, Size: 859 bytes --]

Alexandros Theodotou <alex@zrythm.org> writes:

> The gtkmm passed to inputs was unused. Jalv does not support gtkmm 3 at 
> the moment.
>
> Also, Jalv is the main tool LV2 plugin developers use to test their 
> plugins. Having more variants
> (qt5, gtk2) means you have more types of hosts to test your plugins in 
> so this is an
> extremely useful addition.
>
>  From 2ec5fb34c2600c893763ae95d69bf2bd77d17b61 Mon Sep 17 00:00:00 2001
>  From: Alexandros Theodotou <alex@zrythm.org>
> Date: Fri, 8 Nov 2019 09:05:10 +0000
> Subject: [PATCH] gnu: jalv: Fix gtkmm, add gtk+-2 and qtbase.
>
> * gnu/packages/audio.scm (jalv)[inputs]:
> Add gtk+-2 and qtbase.
> Change unused gtkmm to gtkmm-2.

Thanks!  'guix size jalv' increases from 1482.2 MiB to 1501.2 MiB with
this patch due to the addition of gtkmm@2, which seems fine.

Applied!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-11-10 22:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-08  9:14 [bug#38116] [PATCH] gnu: jalv: Fix gtkmm, add gtk+-2 and qtbase Alexandros Theodotou
2019-11-10 22:39 ` bug#38116: " Marius Bakke

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).