From: "Ludovic Courtès" <ludo@gnu.org>
To: Guillaume Le Vaillant <glv@posteo.net>
Cc: 38182@debbugs.gnu.org
Subject: [bug#38182] [PATCH 3/3] services: Add pam-mount.
Date: Mon, 25 Nov 2019 23:52:16 +0100 [thread overview]
Message-ID: <87mucjtvq7.fsf@gnu.org> (raw)
In-Reply-To: <20191112180519.9625-3-glv@posteo.net> (Guillaume Le Vaillant's message of "Tue, 12 Nov 2019 19:05:19 +0100")
Hi Guillaume,
I’ve applied the first two patches, thanks!
Guillaume Le Vaillant <glv@posteo.net> skribis:
> * gnu/services/pam-mount.scm: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
> * doc/guix.texi (PAM Mount Service): New subsection.
[…]
> +The @code{(gnu services pam-mount)} module provides a service allowing
> +users to mount volumes when they log in. It should be able to mount any
> +volume format supported by the system.
How does one specify what needs to be mounted upon log-in of a specific
user? I’m new to PAM-Mount and I’m left wondering. :-)
> Note that to automatically mount
> +encrypted volumes using the password the user entered to log in, the
> +@code{pam-mount} package must be added in the @code{packages} field of
> +the @code{operating-system} definition.
Should we instead arrange so that the ‘pam-mount’ command (or whatever
it’s called) is automatically found, instead of asking users to add it
to ‘packages’?
Perhaps the manual should give an example for the global config file,
too?
> +(define %pam-mount-default-configuration
> + (plain-file "pam_mount.conf.xml"
> + "<?xml version=\"1.0\" encoding=\"utf-8\" ?>
> +<!DOCTYPE pam_mount SYSTEM \"pam_mount.conf.xml.dtd\">
> +<pam_mount>
> +<debug enable=\"0\" />
> +<mntoptions
> +allow=\"nosuid,nodev,loop,encryption,fsck,nonempty,allow_root,allow_other\" />
> +<mntoptions require=\"nosuid,nodev\" />
> +<logout wait=\"0\" hup=\"no\" term=\"no\" kill=\"no\" />
> +<mkmountpoint enable=\"1\" remove=\"true\" />
> +</pam_mount>\n"))
I suggest writing SXML instead and using ‘sxml->xml’, if you don’t
mind. :-)
> +(define pam-mount-service-type
> + (service-type
> + (name 'pam-mount)
> + (extensions (list (service-extension etc-service-type
> + pam-mount-etc-service)
> + (service-extension pam-root-service-type
> + pam-mount-pam-service)))
> + (default-value (pam-mount-configuration))))
Please also add a ‘description’ field.
Could you send an updated patch?
Thanks!
Ludo’.
next prev parent reply other threads:[~2019-11-25 22:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 18:02 [bug#38182] [PATCH 0/3] Add PAM Mount Guillaume Le Vaillant
2019-11-12 18:05 ` [bug#38182] [PATCH 1/3] gnu: Add libhx Guillaume Le Vaillant
2019-11-12 18:05 ` [bug#38182] [PATCH 2/3] gnu: Add pam-mount Guillaume Le Vaillant
2019-11-12 18:05 ` [bug#38182] [PATCH 3/3] services: " Guillaume Le Vaillant
2019-11-25 22:52 ` Ludovic Courtès [this message]
2019-11-26 22:00 ` Guillaume Le Vaillant
2019-11-28 12:33 ` bug#38182: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mucjtvq7.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=38182@debbugs.gnu.org \
--cc=glv@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).