From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:43388)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iZNE8-0003D1-TH
 for guix-patches@gnu.org; Mon, 25 Nov 2019 17:53:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iZNE6-0002jV-Ey
 for guix-patches@gnu.org; Mon, 25 Nov 2019 17:53:04 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:43918)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1iZNE5-0002jK-Sj
 for guix-patches@gnu.org; Mon, 25 Nov 2019 17:53:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iZNE5-000480-SR
 for guix-patches@gnu.org; Mon, 25 Nov 2019 17:53:01 -0500
Subject: [bug#38182] [PATCH 3/3] services: Add pam-mount.
Resent-Message-ID: <handler.38182.B38182.157472234915825@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <87ftitas7x.fsf@yamatai> <20191112180519.9625-1-glv@posteo.net>
 <20191112180519.9625-3-glv@posteo.net>
Date: Mon, 25 Nov 2019 23:52:16 +0100
In-Reply-To: <20191112180519.9625-3-glv@posteo.net> (Guillaume Le Vaillant's
 message of "Tue, 12 Nov 2019 19:05:19 +0100")
Message-ID: <87mucjtvq7.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Guillaume Le Vaillant <glv@posteo.net>
Cc: 38182@debbugs.gnu.org

Hi Guillaume,

I=E2=80=99ve applied the first two patches, thanks!

Guillaume Le Vaillant <glv@posteo.net> skribis:

> * gnu/services/pam-mount.scm: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
> * doc/guix.texi (PAM Mount Service): New subsection.

[=E2=80=A6]

> +The @code{(gnu services pam-mount)} module provides a service allowing
> +users to mount volumes when they log in.  It should be able to mount any
> +volume format supported by the system.

How does one specify what needs to be mounted upon log-in of a specific
user?  I=E2=80=99m new to PAM-Mount and I=E2=80=99m left wondering.  :-)

> Note that to automatically mount
> +encrypted volumes using the password the user entered to log in, the
> +@code{pam-mount} package must be added in the @code{packages} field of
> +the @code{operating-system} definition.

Should we instead arrange so that the =E2=80=98pam-mount=E2=80=99 command (=
or whatever
it=E2=80=99s called) is automatically found, instead of asking users to add=
 it
to =E2=80=98packages=E2=80=99?

Perhaps the manual should give an example for the global config file,
too?

> +(define %pam-mount-default-configuration
> +  (plain-file "pam_mount.conf.xml"
> +              "<?xml version=3D\"1.0\" encoding=3D\"utf-8\" ?>
> +<!DOCTYPE pam_mount SYSTEM \"pam_mount.conf.xml.dtd\">
> +<pam_mount>
> +<debug enable=3D\"0\" />
> +<mntoptions
> +allow=3D\"nosuid,nodev,loop,encryption,fsck,nonempty,allow_root,allow_ot=
her\" />
> +<mntoptions require=3D\"nosuid,nodev\" />
> +<logout wait=3D\"0\" hup=3D\"no\" term=3D\"no\" kill=3D\"no\" />
> +<mkmountpoint enable=3D\"1\" remove=3D\"true\" />
> +</pam_mount>\n"))

I suggest writing SXML instead and using =E2=80=98sxml->xml=E2=80=99, if yo=
u don=E2=80=99t
mind.  :-)

> +(define pam-mount-service-type
> +  (service-type
> +   (name 'pam-mount)
> +   (extensions (list (service-extension etc-service-type
> +                                        pam-mount-etc-service)
> +                     (service-extension pam-root-service-type
> +                                        pam-mount-pam-service)))
> +   (default-value (pam-mount-configuration))))

Please also add a =E2=80=98description=E2=80=99 field.

Could you send an updated patch?

Thanks!

Ludo=E2=80=99.