From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Brice Waegeneire <brice@waegenei.re>
Cc: 39522@debbugs.gnu.org
Subject: [bug#39522] [PATCH] gnu: dunst: Build dunstify.
Date: Mon, 10 Feb 2020 00:45:00 +0100 [thread overview]
Message-ID: <87mu9rz5oj.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <20200209091109.28930-1-brice@waegenei.re> (Brice Waegeneire's message of "Sun, 9 Feb 2020 10:11:09 +0100")
Hello,
Brice Waegeneire <brice@waegenei.re> writes:
> * gnu/packages/dunst.scm (dunst)[arguments]: Add phase install-dunstify.
> [inputs]: Add libnotify.
Please add a copyright line for you.
> + (add-after 'install 'install-dunstify
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let ((out (assoc-ref outputs "out")))
> + (copy-file "dunstify"
> + (string-append out "/bin/dunstify"))))))))
I suggest to use
(install-file "dunstify" (string-append out "/bin"))
instead.
Also, the phase must end with #t.
Could you send an updated patch?
Thank you!
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2020-02-09 23:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-09 9:11 [bug#39522] [PATCH] gnu: dunst: Build dunstify Brice Waegeneire
2020-02-09 23:45 ` Nicolas Goaziou [this message]
2020-02-10 8:57 ` Brice Waegeneire
2020-02-11 18:26 ` bug#39522: " Nicolas Goaziou
2020-02-10 8:51 ` [bug#39522] [PATCH v2] " Brice Waegeneire
[not found] ` <handler.39522.D39522.15814455763176.notifdone@debbugs.gnu.org>
2020-02-14 14:04 ` [bug#39522] When to add a copyright line? Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mu9rz5oj.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=39522@debbugs.gnu.org \
--cc=brice@waegenei.re \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).