From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:54968)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1j0wH5-00087q-Bg
 for guix-patches@gnu.org; Sun, 09 Feb 2020 18:46:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1j0wH4-0006Xn-Fl
 for guix-patches@gnu.org; Sun, 09 Feb 2020 18:46:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:47457)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1j0wH4-0006XW-C1
 for guix-patches@gnu.org; Sun, 09 Feb 2020 18:46:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1j0wH4-0002it-Aj
 for guix-patches@gnu.org; Sun, 09 Feb 2020 18:46:02 -0500
Subject: [bug#39522] [PATCH] gnu: dunst: Build dunstify.
Resent-Message-ID: <handler.39522.B39522.158129190510394@debbugs.gnu.org>
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
References: <20200209091109.28930-1-brice@waegenei.re>
Date: Mon, 10 Feb 2020 00:45:00 +0100
In-Reply-To: <20200209091109.28930-1-brice@waegenei.re> (Brice Waegeneire's
 message of "Sun, 9 Feb 2020 10:11:09 +0100")
Message-ID: <87mu9rz5oj.fsf@nicolasgoaziou.fr>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Brice Waegeneire <brice@waegenei.re>
Cc: 39522@debbugs.gnu.org

Hello,

Brice Waegeneire <brice@waegenei.re> writes:

> * gnu/packages/dunst.scm (dunst)[arguments]: Add phase install-dunstify.
> [inputs]: Add libnotify.

Please add a copyright line for you.

> +                  (add-after 'install 'install-dunstify
> +                    (lambda* (#:key outputs #:allow-other-keys)
> +                      (let ((out (assoc-ref outputs "out")))
> +                        (copy-file "dunstify"
> +                                   (string-append out "/bin/dunstify"))))))))

I suggest to use

  (install-file "dunstify" (string-append out "/bin"))

instead.

Also, the phase must end with #t.

Could you send an updated patch?

Thank you!

Regards,

-- 
Nicolas Goaziou