From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 41849-done@debbugs.gnu.org
Subject: bug#41849: [PATCH] Add frozen-bubble
Date: Wed, 17 Jun 2020 12:05:23 +0200 [thread overview]
Message-ID: <87mu529fdo.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87ftaurq5v.fsf@gnu.org> ("Ludovic Courtès"'s message of "Wed, 17 Jun 2020 11:35:08 +0200")
Hello,
Ludovic Courtès <ludo@gnu.org> writes:
> Please add a comment stating why we’re pick this revision.
Done.
>> + (add-after 'unpack 'fix-permissions
>> + (lambda _ (invoke "chmod" "-R" "+w" "server")))
>
> How about: (for-each make-file-writable
> (find-files "servers" "." #:directories? #t))
OK.
I also removed the #:module-build-flags argument in frozen-bubble
package, as it didn't seem to be necessary, and I was not sure why I had
added it in the first place.
> I can’t wait to try it again, so many years later. :-)
Heh.
Thank you for the review. I pushed the changes.
Regards,
--
Nicolas Goaziou
prev parent reply other threads:[~2020-06-17 10:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-14 12:26 [bug#41849] [PATCH] Add frozen-bubble Nicolas Goaziou
2020-06-17 9:35 ` Ludovic Courtès
2020-06-17 10:05 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mu529fdo.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=41849-done@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).