From: "Ludovic Courtès" <ludo@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: 41849@debbugs.gnu.org
Subject: [bug#41849] [PATCH] Add frozen-bubble
Date: Wed, 17 Jun 2020 11:35:08 +0200 [thread overview]
Message-ID: <87ftaurq5v.fsf@gnu.org> (raw)
In-Reply-To: <87pna1esu6.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Sun, 14 Jun 2020 14:26:41 +0200")
Hi,
Nicolas Goaziou <mail@nicolasgoaziou.fr> skribis:
>>From 2586c90f5a25985bd02b0ea5bc65c5fc982b50d8 Mon Sep 17 00:00:00 2001
> From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
> Date: Sun, 14 Jun 2020 11:50:43 +0200
> Subject: [PATCH 1/3] gnu: Add perl-alien-sdl.
>
> * gnu/packages/perl.scm (perl-alien-sdl): New variable.
LGTM.
>>From 64744949f1d80b40317d942807b871f3c3f0f490 Mon Sep 17 00:00:00 2001
> From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
> Date: Sun, 14 Jun 2020 12:44:28 +0200
> Subject: [PATCH 2/3] gnu: Add perl-sdl.
>
> * gnu/packages/perl.scm (perl-sdl): New variable.
LGTM.
>>From 6ff230c8ec69cdc21d6b8148b54f170b3fd859e9 Mon Sep 17 00:00:00 2001
> From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
> Date: Sun, 14 Jun 2020 12:50:34 +0200
> Subject: [PATCH 3/3] gnu: Add frozen-bubble.
>
> * gnu/packages/games.scm (frozen-bubble): New variable.
[...]
> +(define-public frozen-bubble
> + (let ((commit "d6a029110ad6ab9e4960052e175addc98807fb7e")
> + (revision "1"))
Please add a comment stating why we’re pick this revision.
> + (add-after 'unpack 'fix-permissions
> + (lambda _ (invoke "chmod" "-R" "+w" "server")))
How about: (for-each make-file-writable
(find-files "servers" "." #:directories? #t))
Otherwise LGTM.
I can’t wait to try it again, so many years later. :-)
Thanks!
Ludo’.
next prev parent reply other threads:[~2020-06-17 9:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-14 12:26 [bug#41849] [PATCH] Add frozen-bubble Nicolas Goaziou
2020-06-17 9:35 ` Ludovic Courtès [this message]
2020-06-17 10:05 ` bug#41849: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftaurq5v.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=41849@debbugs.gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).