From: "Ludovic Courtès" <ludo@gnu.org>
To: Eric Bavier <bavier@posteo.net>
Cc: 39807@debbugs.gnu.org
Subject: [bug#39807] [PATCH] guix: pack: Only wrap executable files.
Date: Wed, 21 Oct 2020 23:31:13 +0200 [thread overview]
Message-ID: <87mu0fxo4e.fsf@gnu.org> (raw)
In-Reply-To: <48f280214fca0f8bd17aeff46c42ee76a04c90f2.camel@posteo.net> (Eric Bavier's message of "Wed, 21 Oct 2020 11:21:57 -0500")
Hi,
Eric Bavier <bavier@posteo.net> skribis:
> On Wed, 2020-10-21 at 17:35 +0200, Ludovic Courtès wrote:
>> Hi Eric,
>>
>> Eric Bavier <bavier@posteo.net> skribis:
>>
>> > (mkdir-p (dirname result))
>> > (apply invoke #$compiler "-std=gnu99" "-static" "-Os" "-g0" "-Wall"
>> > "run.c" "-o" result
>> > + (string-append "-DWRAPPER_PROGRAM=\"" result "\"")
>>
>> Can we just write (canonical-path result) here? That way we wouldn’t
>> need ‘find-input-files’ and related changes.
>>
>
> Guile's canonicalize-path will raise and error if the path does not
> already exist. We could create a dummy file at result, then call
> canonicalize-path? but that seems clumsier than forming a canonical
> name in the first place?
Oh you’re right, sorry.
The patch you sent has ‘find-files’ use ‘stat’ instead of the trailing
slash. It introduces a difference: by using ‘stat’ all the way, it
follows all symlinks, not just the higher-level ones. I don’t know if
this could have undesired implications, like wrapping the same file
twice because there’s a symlink pointing to it. (Or am I too paranoid?)
To be on the safe side, we could write:
(string-append (canonical-path (dirname) result) "/" result)
WDYT?
Thanks,
Ludo’.
next prev parent reply other threads:[~2020-10-21 21:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 4:36 [bug#39807] [PATCH] guix: pack: Only wrap executable files Eric Bavier
2020-03-06 11:16 ` Ludovic Courtès
2020-03-24 17:51 ` Ludovic Courtès
2020-03-27 2:53 ` Eric Bavier
2020-03-27 2:29 ` Eric Bavier
[not found] ` <8d8a2e1209d82e136d36222683967956@posteo.net>
2020-03-29 14:39 ` Ludovic Courtès
2020-07-27 21:42 ` Eric Bavier
2020-10-21 5:09 ` Eric Bavier
2020-10-21 9:07 ` Ludovic Courtès
2020-10-21 15:12 ` Eric Bavier
2020-10-21 15:35 ` Ludovic Courtès
2020-10-21 16:21 ` Eric Bavier
2020-10-21 21:31 ` Ludovic Courtès [this message]
2020-10-21 23:51 ` Eric Bavier
2020-10-23 10:48 ` Ludovic Courtès
2020-10-30 15:13 ` bug#39807: " Eric Bavier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mu0fxo4e.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=39807@debbugs.gnu.org \
--cc=bavier@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).