From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id sDxSB9CqkF9uSgAA0tVLHw (envelope-from ) for ; Wed, 21 Oct 2020 21:40:32 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 6BgpA9CqkF/AQwAA1q6Kng (envelope-from ) for ; Wed, 21 Oct 2020 21:40:32 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A5D3A9403A0 for ; Wed, 21 Oct 2020 21:40:31 +0000 (UTC) Received: from localhost ([::1]:50752 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kVLqQ-0008AG-JM for larch@yhetil.org; Wed, 21 Oct 2020 17:40:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47920) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kVLiE-0006xg-CQ for guix-patches@gnu.org; Wed, 21 Oct 2020 17:32:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39204) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kVLiD-0002e5-Vh for guix-patches@gnu.org; Wed, 21 Oct 2020 17:32:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kVLiD-0005nc-Rj for guix-patches@gnu.org; Wed, 21 Oct 2020 17:32:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#39807] [PATCH] guix: pack: Only wrap executable files. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 21 Oct 2020 21:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39807 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Eric Bavier Cc: 39807@debbugs.gnu.org Received: via spool by 39807-submit@debbugs.gnu.org id=B39807.160331589022248 (code B ref 39807); Wed, 21 Oct 2020 21:32:01 +0000 Received: (at 39807) by debbugs.gnu.org; 21 Oct 2020 21:31:30 +0000 Received: from localhost ([127.0.0.1]:50749 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVLhh-0005mm-SA for submit@debbugs.gnu.org; Wed, 21 Oct 2020 17:31:30 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41002) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVLhf-0005mK-Qa for 39807@debbugs.gnu.org; Wed, 21 Oct 2020 17:31:28 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57917) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kVLha-0002cA-8T; Wed, 21 Oct 2020 17:31:22 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=45832 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kVLhU-00045G-Pm; Wed, 21 Oct 2020 17:31:18 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <3ace941f920d87da65de6e4fdc16add5b9725434.camel@posteo.net> <83416910901e77b537b64de392ee02598ccd72ff.camel@posteo.net> <87wnzk7xs0.fsf@gnu.org> <69f5446e2accd24cd1de9e3964373ab525b0875d.camel@posteo.net> <87pn5b383l.fsf@gnu.org> <48f280214fca0f8bd17aeff46c42ee76a04c90f2.camel@posteo.net> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 30 =?UTF-8?Q?Vend=C3=A9miaire?= an 229 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Wed, 21 Oct 2020 23:31:13 +0200 In-Reply-To: <48f280214fca0f8bd17aeff46c42ee76a04c90f2.camel@posteo.net> (Eric Bavier's message of "Wed, 21 Oct 2020 11:21:57 -0500") Message-ID: <87mu0fxo4e.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.51 X-TUID: wKpSh/fgpKwU Hi, Eric Bavier skribis: > On Wed, 2020-10-21 at 17:35 +0200, Ludovic Court=C3=A8s wrote: >> Hi Eric, >>=20 >> Eric Bavier skribis: >>=20 >> > (mkdir-p (dirname result)) >> > (apply invoke #$compiler "-std=3Dgnu99" "-static" "-Os"= "-g0" "-Wall" >> > "run.c" "-o" result >> > + (string-append "-DWRAPPER_PROGRAM=3D\"" result "= \"") >>=20 >> Can we just write (canonical-path result) here? That way we wouldn=E2= =80=99t >> need =E2=80=98find-input-files=E2=80=99 and related changes. >>=20 > > Guile's canonicalize-path will raise and error if the path does not > already exist. We could create a dummy file at result, then call > canonicalize-path? but that seems clumsier than forming a canonical > name in the first place? Oh you=E2=80=99re right, sorry. The patch you sent has =E2=80=98find-files=E2=80=99 use =E2=80=98stat=E2=80= =99 instead of the trailing slash. It introduces a difference: by using =E2=80=98stat=E2=80=99 all the= way, it follows all symlinks, not just the higher-level ones. I don=E2=80=99t know= if this could have undesired implications, like wrapping the same file twice because there=E2=80=99s a symlink pointing to it. (Or am I too paran= oid?) To be on the safe side, we could write: (string-append (canonical-path (dirname) result) "/" result) WDYT? Thanks, Ludo=E2=80=99.