From: Xinglu Chen <public@yoctocell.xyz>
To: 50756@debbugs.gnu.org
Cc: Olivier Dion <olivier.dion@polymtl.ca>
Subject: [bug#50756] [PATCH] gnu: Add lttng-tools.
Date: Fri, 24 Sep 2021 16:24:42 +0200 [thread overview]
Message-ID: <87mto2jbkl.fsf@yoctocell.xyz> (raw)
In-Reply-To: <20210923124004.3164-1-olivier.dion@polymtl.ca>
[-- Attachment #1: Type: text/plain, Size: 3904 bytes --]
On Thu, Sep 23 2021, Olivier Dion via Guix-patches via wrote:
> * gnu/packages/linux.scm (lttng-tools): New variable.
>
> Note that tests are not yet working.
What is the reason for that? There should be a comment explaining why.
> Signed-off-by: Olivier Dion <olivier.dion@polymtl.ca>
There is no need to “sign-off” your own commit; this is only done by
committers who push a patch on behalf of someone else.
> ---
> gnu/packages/linux.scm | 54 ++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 54 insertions(+)
>
> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> index 9bb90e599e..a8cb4fd05a 100644
> --- a/gnu/packages/linux.scm
> +++ b/gnu/packages/linux.scm
> @@ -53,6 +53,7 @@
> ;;; Copyright © 2020 pukkamustard <pukkamustard@posteo.net>
> ;;; Copyright © 2021 B. Wilson <elaexuotee@wilsonb.com>
> ;;; Copyright © 2021 Ivan Gankevich <i.gankevich@spbu.ru>
> +;;; Copyright © 2021 Olivier Dion <olivier.dion@polymtl.ca>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -8051,6 +8052,59 @@ enable and disable specific instrumentation points, and writes event records
> to ring buffers shared with a consumer daemon.")
> (license license:lgpl2.1+)))
>
> +(define-public lttng-tools
> + (package
> + (name "lttng-tools")
> + (version "2.12.5")
Version 2.13 is available; any reason for not using it?
> + (source (origin
> + (method url-fetch)
> + (uri (string-append "https://lttng.org/files/lttng-tools/"
> + "lttng-tools-" version ".tar.bz2"))
> + (sha256
> + (base32 "0bgk35423v6z17j1w80m7dcza7gigs1pwyq24sdmgqwg6j2d1zmc"))))
Keep lines <=80 characters long.
> +
> + (build-system gnu-build-system)
These newlines aren’t necessary.
> + (arguments
> + `(#:tests? #f
> + #:parallel-tests? #f
There is no need to set #:parallel-tests? if #:tests? is set to #f.
> + #:phases
> + (modify-phases %standard-phases
> + (add-before 'configure 'set-environment-variables
> + (lambda _
> + (setenv "HOME" "/tmp")
> + (setenv "LTTNG_HOME" "/tmp"))))))
> +
> + (inputs
> + `(("liburcu" ,liburcu)
> + ("popt" ,popt)
> + ("numactl" ,numactl)))
> +
> + (propagated-inputs
> + `(("libkmod" ,kmod)
> + ("modprobe" ,module-init-tools)))
Any reason for the labels not being the same as the package?
> + (native-inputs
> + `(("pkg-config" ,pkg-config)
> + ("perl" ,perl)
> + ("libpfm4" ,libpfm4)
> + ("python" ,python-3)
While running the configure script, I get
configure: You may configure with --enable-python-bindings if you want Python bindings.
So you would have to pass the ‘--enable-python-bindings’ flag, and
Python would be needed during runtime as well.
> + ("procps" ,procps)
> + ("which" ,which)
> + ("flex" ,flex)
> + ("bison" ,bison)
> + ("asciidoc" ,asciidoc)
> + ("libxml2" ,libxml2)
> + ("lttng-ust" ,lttng-ust)))
>
> + (home-page "https://lttng.org/")
> + (synopsis "LTTng userspace tracer libraries")
> + (description "The lttng-tools project provides a session
> +daemon (lttng-sessiond) that acts as a tracing registry, the \"lttng\" command
the @command{lttng} command
> +line for tracing control, a lttng-ctl library for tracing control and a
> +lttng-relayd for network streaming.")
I would use @code{lttng-ctl} and @code{lttng-relayd}.
> + (license license:gpl2)))
The bottom of the homepage says
…LTTng-tools is licensed under LGPLv2.1 and GPLv2…
so it would be (list license:gpl2 license:lgpl2.1)
Could you send an updated patch?
[1]: <https://lttng.org/docs/v2.13/#doc-building-from-source>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
next prev parent reply other threads:[~2021-09-24 14:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 12:40 [bug#50756] [PATCH] gnu: Add lttng-tools Olivier Dion via Guix-patches via
2021-09-24 14:24 ` Xinglu Chen [this message]
2021-09-24 15:13 ` Olivier Dion via Guix-patches via
2021-09-26 9:42 ` Xinglu Chen
2021-10-13 8:52 ` Ludovic Courtès
2021-10-13 14:41 ` Olivier Dion via Guix-patches via
2021-10-17 15:06 ` [bug#50756] [PATCH v2] " Olivier Dion via Guix-patches via
2021-10-25 12:02 ` bug#50756: [PATCH] " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mto2jbkl.fsf@yoctocell.xyz \
--to=public@yoctocell.xyz \
--cc=50756@debbugs.gnu.org \
--cc=olivier.dion@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).