From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id eCPOLM3fTWEPSgAAgWs5BA (envelope-from ) for ; Fri, 24 Sep 2021 16:25:17 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 8HpsKM3fTWHVLgAAbx9fmQ (envelope-from ) for ; Fri, 24 Sep 2021 14:25:17 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DB731388CB for ; Fri, 24 Sep 2021 16:25:16 +0200 (CEST) Received: from localhost ([::1]:47194 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mTm8a-0005Ji-3V for larch@yhetil.org; Fri, 24 Sep 2021 10:25:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40858) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mTm8M-0005JY-50 for guix-patches@gnu.org; Fri, 24 Sep 2021 10:25:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:47441) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mTm8L-0007t0-UA for guix-patches@gnu.org; Fri, 24 Sep 2021 10:25:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mTm8L-00010F-Qt for guix-patches@gnu.org; Fri, 24 Sep 2021 10:25:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50756] [PATCH] gnu: Add lttng-tools. Resent-From: Xinglu Chen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 24 Sep 2021 14:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50756 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 50756@debbugs.gnu.org Cc: Olivier Dion X-Debbugs-Original-To: Olivier Dion via Guix-patches via , 50756@debbugs.gnu.org Received: via spool by 50756-submit@debbugs.gnu.org id=B50756.16324934983841 (code B ref 50756); Fri, 24 Sep 2021 14:25:01 +0000 Received: (at 50756) by debbugs.gnu.org; 24 Sep 2021 14:24:58 +0000 Received: from localhost ([127.0.0.1]:58985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTm8D-0000zf-M1 for submit@debbugs.gnu.org; Fri, 24 Sep 2021 10:24:57 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:45174 helo=mail.yoctocell.xyz) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTm8C-0000zN-9j for 50756@debbugs.gnu.org; Fri, 24 Sep 2021 10:24:52 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1632493484; bh=MtxPqbFcpjP82dr/Y4h0JFjs4IF5X3IxSlRS2RRpGMA=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=u8aBxqeoJHKGCd4FVwJ5T+wCXnxVkz25VFl6FLERZq5BT6ZuJqTsJnQU1sor0suym tIpQsiUH+x0/tzGWy9dm99hbKWREbzjgy/pGwprqzpYc5LYD82k/vzn00bDv6e9ybK mgm5alQCA8A/mQQ50wofGq+lNQVAUGFeY8n1KGM8= In-Reply-To: <20210923124004.3164-1-olivier.dion@polymtl.ca> References: <20210923124004.3164-1-olivier.dion@polymtl.ca> Date: Fri, 24 Sep 2021 16:24:42 +0200 Message-ID: <87mto2jbkl.fsf@yoctocell.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632493517; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=CmKuDxXQZrMMLRXD0B8Oa6ljOzRdJhrkl8pvEtS6pjc=; b=NZHQAYtH2nsBLJCMbp0ElacUp8CnQ5onODphO0UuH1lj/5qyfyX7xu9aiHGRo6mqHAHQxj C/1dCMqQmr+3o3a5ah8K3gYzYyZoKpyv2KRZZB+7Yxi1ynZwaC1wr90L37Fbdb0cFns/kB T8de2ZNFWbkuE2nQ60T0L61jrTfx2HEfcu4O2B4pfR8l1FcIzAm54x56rTkgqIZpvyKqRg sBC9GKzjRDdjj/5YHa17CkIqBhTysKUYYrQoOSWwdVNiluC7V1a0yS4h4PDXjwCQlAToJ1 Zzz6kzgxLOKXbm72Aa34fXrtEhsP3sKHLE55w8JOiufY0r62vhmYX0pqwFNzdQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632493517; a=rsa-sha256; cv=none; b=Vd5KyasQD0lXR5sHqN8UNWGFu2tilG8bYqN5X2dJtBpcmqjJjGUER8DHgLfZgcS9ro5uWL idLOpm4wcK6aWuWjm8oaKp78rHdnbpkVBl8+Pfw265GvTvMvk9LpjcXdBbPNCttVxZPBc5 IDZJJ8mFIuZpRq06CQFzHPmOc0zNZirXEAsB3jn0pd6V1hG4dKTTYhM6bZfLqAr3RJFTqf SyD70KbIBQLjWOVRAd3b4Pni2GZ7ghb304PVLUzxG0osCDEjku7c9RKaISNKkEaCoeh2Zh xe4lsOjanqfplqPgp8JAzgrL+zY43anZMKnYEzOHWYSM+HyrfI7SGvRYfeg9rQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=yoctocell.xyz header.s=mail header.b=u8aBxqeo; dmarc=fail reason="SPF not aligned (relaxed)" header.from=yoctocell.xyz (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.39 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=yoctocell.xyz header.s=mail header.b=u8aBxqeo; dmarc=fail reason="SPF not aligned (relaxed)" header.from=yoctocell.xyz (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: DB731388CB X-Spam-Score: -3.39 X-Migadu-Scanner: scn0.migadu.com X-TUID: MytEEG/zzYZN --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Thu, Sep 23 2021, Olivier Dion via Guix-patches via wrote: > * gnu/packages/linux.scm (lttng-tools): New variable. > > Note that tests are not yet working. What is the reason for that? There should be a comment explaining why. > Signed-off-by: Olivier Dion There is no need to =E2=80=9Csign-off=E2=80=9D your own commit; this is onl= y done by committers who push a patch on behalf of someone else. > --- > gnu/packages/linux.scm | 54 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 54 insertions(+) > > diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm > index 9bb90e599e..a8cb4fd05a 100644 > --- a/gnu/packages/linux.scm > +++ b/gnu/packages/linux.scm > @@ -53,6 +53,7 @@ > ;;; Copyright =C2=A9 2020 pukkamustard > ;;; Copyright =C2=A9 2021 B. Wilson > ;;; Copyright =C2=A9 2021 Ivan Gankevich > +;;; Copyright =C2=A9 2021 Olivier Dion > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -8051,6 +8052,59 @@ enable and disable specific instrumentation points= , and writes event records > to ring buffers shared with a consumer daemon.") > (license license:lgpl2.1+))) >=20=20 > +(define-public lttng-tools > + (package > + (name "lttng-tools") > + (version "2.12.5") Version 2.13 is available; any reason for not using it? > + (source (origin > + (method url-fetch) > + (uri (string-append "https://lttng.org/files/lttng-tools/" > + "lttng-tools-" version ".tar.bz2")) > + (sha256 > + (base32 "0bgk35423v6z17j1w80m7dcza7gigs1pwyq24sdmgqwg6j2d= 1zmc")))) Keep lines <=3D80 characters long. > + > + (build-system gnu-build-system) These newlines aren=E2=80=99t necessary. > + (arguments > + `(#:tests? #f > + #:parallel-tests? #f There is no need to set #:parallel-tests? if #:tests? is set to #f. > + #:phases > + (modify-phases %standard-phases > + (add-before 'configure 'set-environment-variables > + (lambda _ > + (setenv "HOME" "/tmp") > + (setenv "LTTNG_HOME" "/tmp")))))) > + > + (inputs > + `(("liburcu" ,liburcu) > + ("popt" ,popt) > + ("numactl" ,numactl))) > + > + (propagated-inputs > + `(("libkmod" ,kmod) > + ("modprobe" ,module-init-tools))) Any reason for the labels not being the same as the package? > + (native-inputs > + `(("pkg-config" ,pkg-config) > + ("perl" ,perl) > + ("libpfm4" ,libpfm4) > + ("python" ,python-3) While running the configure script, I get configure: You may configure with --enable-python-bindings if you want Py= thon bindings. So you would have to pass the =E2=80=98--enable-python-bindings=E2=80=99 fl= ag, and Python would be needed during runtime as well. > + ("procps" ,procps) > + ("which" ,which) > + ("flex" ,flex) > + ("bison" ,bison) > + ("asciidoc" ,asciidoc) > + ("libxml2" ,libxml2) > + ("lttng-ust" ,lttng-ust))) > > + (home-page "https://lttng.org/") > + (synopsis "LTTng userspace tracer libraries") > + (description "The lttng-tools project provides a session > +daemon (lttng-sessiond) that acts as a tracing registry, the \"lttng\" c= ommand the @command{lttng} command > +line for tracing control, a lttng-ctl library for tracing control and a > +lttng-relayd for network streaming.") I would use @code{lttng-ctl} and @code{lttng-relayd}. > + (license license:gpl2))) The bottom of the homepage says =E2=80=A6LTTng-tools is licensed under LGPLv2.1 and GPLv2=E2=80=A6 so it would be (list license:gpl2 license:lgpl2.1) Could you send an updated patch? [1]: --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEAVhh4yyK5+SEykIzrPUJmaL7XHkFAmFN36sVHHB1YmxpY0B5 b2N0b2NlbGwueHl6AAoJEKz1CZmi+1x5ihMQAI1+w4oNUsNIJ68FkvLzw4Pquh51 0mXz+E7Jn2k2zf81ouWOguIKyaZlAH6i5TpntBsYJnQn31JsuGnisThcHpObz8cR Ir6xVCgpbA6FpwqJ4UD+bBPek+DJygORSUH1VhMYFLmVi0nvJ9OVhbXQxw8vjSPy EfqMxpG3/OTmDMZRgOwu4k5n+CpyCnFXS33EHFoJ6/NF8bhacqVmLg21VRWwc19G dITsi8fAaReNj4swAbrWaUPs3rIuOf7ERuhxcN2IZa9gyB0KQ5O7PNy39k+n+XN8 VKnW1bqLY1a3VPoLWXfwqkupIfmaHcjbdOCzInOV1RCyzLWZ6ZVBZl3u4pdrXvKm JvCJZDOJK1rU1i6kEhzKBMiORdwCzyeyW/jyKHjfeJFlMsbg5FXIDaDSnxaZ6r1g Xo/BdSWApkMKwlc+5MQ07UMjjPMefG9K1HvJ7JftmOgfcmaia0+wymA73Jk4Qt0i sr2CfqX9zVZvLwkMWcztzwLQ110emzXuSm59CfH1o034iIwi+WYIufWjbv3YD4ms qtrIaUCQoz8PbQuo5msICxGbYFDAlfplW+1wHyWdMkWML2R2AyI75PAjdeISwpKA Gs0oTSIuogbFSD5KV95cXOGiHIGQmq14voO339q3CR7EeglO6iKdMPu7BTgHaKHs Ix4Uy0FQ03CptSh2 =gs8K -----END PGP SIGNATURE----- --=-=-=--