From: Christopher Baines <mail@cbaines.net>
To: 路辉 <luhux76@gmail.com>
Cc: 58754@debbugs.gnu.org
Subject: [bug#58754] [PATCH] gnu: Add new variable gkermit
Date: Sat, 05 Nov 2022 11:32:19 +0100 [thread overview]
Message-ID: <87mt95k7v7.fsf@cbaines.net> (raw)
In-Reply-To: <CAGNyvehWU2dq8Ke6PS90_edwoaYS1AaJG53V-f7ZzME0ViUEJQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2829 bytes --]
路辉 <luhux76@gmail.com> writes:
> add new tool for embedded developing
Thanks for the patch. I've noted two hopefully minor issues below. Would
you be able to take a look at sending an updated patch?
> +(define-public gkermit
> + (package
> + (name "gkermit")
> + (version "2.01")
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/KermitProject/gkermit")
> + (commit (string-append "v" version))))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "0njxzwnvanrdnx6cs7y0136g2179wx8wbqk8iqxpb48dr2hg7zn1"))))
> + (build-system gnu-build-system)
> + (arguments
> + `(#:tests? #f
From looking at the source, I guess the reason for this is that there
are no included tests to run. If that is correct, it would be good to
note the reason in a comment.
> + #:make-flags (list (string-append "CC="
> + ,(cc-for-target))
> + (string-append "PREFIX="
> + (assoc-ref %outputs "out")))
> + #:phases (modify-phases %standard-phases
> + (delete 'configure)
> + (add-before 'build 'replace-hardcodepath
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let* ((out (assoc-ref outputs "out"))
> + (bin (string-append out "/bin"))
> + (doc (string-append out "/share/doc"))
> + (man1 (string-append out "/share/man/man1"))
> + (info (string-append out "/share/info")))
> + (substitute* "makefile"
> + (("/usr/local/bin")
> + bin)
> + (("/usr/man/manl")
> + man1) ;may be a typo err?
> + (("/usr/local/doc")
> + doc)
> + (("/usr/local/info")
> + info)
> + (("CC=cc")
> + "CC ?= cc"))
> + (mkdir-p bin)
> + (mkdir-p doc)
> + (mkdir-p man1)
> + (mkdir-p info)))))))
> +
> + (home-page "https://github.com/KermitProject/gkermit")
> + (synopsis "Kermit for UNIX")
> + (description
> + "Use for uploading and downloading files with Kermit protocol")
> + (license license:gpl2)))
Can you check this, at least some files I looked at weren't strict gpl2
only.
Thanks,
Chris
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]
prev parent reply other threads:[~2022-11-05 10:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 5:17 [bug#58754] [PATCH] gnu: Add new variable gkermit 路辉
2022-11-05 10:32 ` Christopher Baines [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mt95k7v7.fsf@cbaines.net \
--to=mail@cbaines.net \
--cc=58754@debbugs.gnu.org \
--cc=luhux76@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).