From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id iOxlOWg8ZmNbggAAbAwnHQ (envelope-from ) for ; Sat, 05 Nov 2022 11:35:21 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id qG9yOWg8ZmM7nAAA9RJhRA (envelope-from ) for ; Sat, 05 Nov 2022 11:35:20 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B603121799 for ; Sat, 5 Nov 2022 11:35:20 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1orGVz-00029U-NJ; Sat, 05 Nov 2022 06:35:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1orGVy-00028x-Cp for guix-patches@gnu.org; Sat, 05 Nov 2022 06:35:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1orGVx-0002T1-W7 for guix-patches@gnu.org; Sat, 05 Nov 2022 06:35:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1orGVx-0006ES-R2 for guix-patches@gnu.org; Sat, 05 Nov 2022 06:35:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#58754] [PATCH] gnu: Add new variable gkermit Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 05 Nov 2022 10:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58754 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: =?UTF-8?Q?=E8=B7=AF=E8=BE=89?= Cc: 58754@debbugs.gnu.org X-Debbugs-Original-Cc: 58754@debbugs.gnu.org, guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.166764446723895 (code B ref -1); Sat, 05 Nov 2022 10:35:01 +0000 Received: (at submit) by debbugs.gnu.org; 5 Nov 2022 10:34:27 +0000 Received: from localhost ([127.0.0.1]:55554 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orGVP-0006DL-7S for submit@debbugs.gnu.org; Sat, 05 Nov 2022 06:34:27 -0400 Received: from lists.gnu.org ([209.51.188.17]:50006) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orGVN-0006D7-4s for submit@debbugs.gnu.org; Sat, 05 Nov 2022 06:34:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1orGVM-00027f-VF for guix-patches@gnu.org; Sat, 05 Nov 2022 06:34:24 -0400 Received: from mira.cbaines.net ([212.71.252.8]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1orGVL-0002Ql-Bx for guix-patches@gnu.org; Sat, 05 Nov 2022 06:34:24 -0400 Received: from localhost (unknown [54.36.30.212]) by mira.cbaines.net (Postfix) with ESMTPSA id 2CACA27BBE9; Sat, 5 Nov 2022 10:34:22 +0000 (GMT) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id ee73e8f3; Sat, 5 Nov 2022 10:34:21 +0000 (UTC) References: User-agent: mu4e 1.8.9; emacs 28.1 From: Christopher Baines Date: Sat, 05 Nov 2022 11:32:19 +0100 In-reply-to: Message-ID: <87mt95k7v7.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=212.71.252.8; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Guix-patches" Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1667644520; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=rBCwMJAvb04vLNx7Dm9/tJWxy1lHfcFDUivn2N7kFfQ=; b=RmyYOMc+OXljIsv2s/hGhSqFhmPu7v7Yt4QHzL1DlJWXWMc9nzjYTrwI+upfWOC00uKX5x 4g7BkhGyMqqrDXU/3NKaKb0U0n8GPBielW/ks2OaMma1BztN81LuASwD8xVIc26HjyyopX tRqQSCW8uffkWqwUkhlPHx1/2CZbKC4/uZDh5a38RFodU3fGgYgvPDLVQUPjHFa2Dd73X8 n9t5fVUpkem1NVG8vBkWrodhba3xn80HWEK6VAnPGXeJa6+u13U0moOOKbw/R4/MNSfqQu s6GgEjrF7rOBJ5g5P278DO2tzxayaeq57Z9YeDAywly35QrJ6vTaOfkzSVY6MA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1667644520; a=rsa-sha256; cv=none; b=Pw1D34mxgh4UblDXbi3mgFFXbeaJIx43rG5FGcGpo3n5tN6l+dmwfqwoSA4g/WpP/UdVrX o940YEFLLX+dXsabNMFwP3LU4/XFQAh15fN7ZztxWoYApY0M8qparpq9ld2rjlKwB4seMC Hsy20Cy8c2OkA5DujolGqrU4AG+ZxcaTR1AoKqkjOE5MnQFjt2TU/AaRGXwE1nLXabG7US WZEQ+nFWajVmnjFZAHY3jwl4e0NevVEK3Y8jpH1X4y12CA+e0UAgfqLLo/Tk/nigHJe2ez Qe/hUa0V3o16lO7RFZ+K/ieFyEIHDfrRznGZzOhC7zo6G7vnAB4T6VB35Cz4TA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.81 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: B603121799 X-Spam-Score: -4.81 X-Migadu-Scanner: scn0.migadu.com X-TUID: szHqqno+hTFm --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable =E8=B7=AF=E8=BE=89 writes: > add new tool for embedded developing Thanks for the patch. I've noted two hopefully minor issues below. Would you be able to take a look at sending an updated patch? > +(define-public gkermit > + (package > + (name "gkermit") > + (version "2.01") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/KermitProject/gkermit") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "0njxzwnvanrdnx6cs7y0136g2179wx8wbqk8iqxpb48dr2hg7zn1"))= )) > + (build-system gnu-build-system) > + (arguments > + `(#:tests? #f From=20looking at the source, I guess the reason for this is that there are no included tests to run. If that is correct, it would be good to note the reason in a comment. > + #:make-flags (list (string-append "CC=3D" > + ,(cc-for-target)) > + (string-append "PREFIX=3D" > + (assoc-ref %outputs "out"))) > + #:phases (modify-phases %standard-phases > + (delete 'configure) > + (add-before 'build 'replace-hardcodepath > + (lambda* (#:key outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) > + (bin (string-append out "/bin")) > + (doc (string-append out "/share/doc")) > + (man1 (string-append out "/share/man/man1")) > + (info (string-append out "/share/info"))) > + (substitute* "makefile" > + (("/usr/local/bin") > + bin) > + (("/usr/man/manl") > + man1) ;may be a typo err? > + (("/usr/local/doc") > + doc) > + (("/usr/local/info") > + info) > + (("CC=3Dcc") > + "CC ?=3D cc")) > + (mkdir-p bin) > + (mkdir-p doc) > + (mkdir-p man1) > + (mkdir-p info))))))) > + > + (home-page "https://github.com/KermitProject/gkermit") > + (synopsis "Kermit for UNIX") > + (description > + "Use for uploading and downloading files with Kermit protocol") > + (license license:gpl2))) Can you check this, at least some files I looked at weren't strict gpl2 only. Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmNmPCxfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XdqtQ//aXTmNUjBZfguKQW9ohVUWsXPCvBhbzKK 2YTGRn740ALDU9LmmpnxdXx+0CTo/HzhnkJbU0TXlt3wOtHXjAf9PoB3FX1aaQbq hwgwTp0jfnnZpYNhpu07kg3YYVQIiBXgqS/vOa1sDdSUlx1be9e9PVqUln3S4jUU ayzf7D5AP7edpun9wXvOGhqjZyVgXfLMf2BNtrai1e1jPi5s7BjJkNrhCPBiHmSW c+tJvfDA4ODUu6950wqka0DyjcyJYOmnWqaIgAxxclZnP/NfugYy2YyCLz3bHYMK SbfCLBCR6BFjzNoBkfmeATCuohTmFB6MnduqDh356MRkEXuSL4RQa9zq9pp1VG6e 5mZWpmf++rJqXpFKJJUR7+GBSg1etBl6H2GAFO6otckRUK71JpMKzmv0mbjkmlm1 0+tCQR2Hmc4uIdnrx1vViP7sZ/YtrX+t7KLmv9CdFZgdOZto0508BhyJNS2sd7LC rqqYgN6uquSuibxlPbuIClgdAGeSRSJcjG8iFh8yQ63IwmLOMwKxX/2t1IG5ydXz EdZFSpj5k/qf5kge4+UAQOM7sKUeRCUln86VdRm6pjqW2Y1N7c3EdEH+lCqbYqkc mTJEyIlY9v5urU+B2PeeBa41S4LaeVBoQt8hGdOKmGDhmIJ1/RMqNTrcgTGi5rRe JDPZZJWcORQ= =Gxoa -----END PGP SIGNATURE----- --=-=-=--