unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#58715] [PATCH] Remove 'davexunit(2nd)' from channel auth
       [not found] <20221022141323.18299-1-kreyren@rixotstudio.cz>
@ 2022-11-08 13:02 ` Ludovic Courtès
  2022-11-08 13:57   ` [bug#58715] [EXT] Re: bug#58715: " Thompson, David
  0 siblings, 1 reply; 2+ messages in thread
From: Ludovic Courtès @ 2022-11-08 13:02 UTC (permalink / raw)
  To: David Thompson; +Cc: 58715

Hi David,

Someone proposed this change:

> --- a/.guix-authorizations
> +++ b/.guix-authorizations
> @@ -37,8 +37,6 @@
>     (name "dannym"))
>    ("B3C0 DB4D AD73 BA5D 285E  19AE 5143 0234 CEFD 87C3"
>     (name "davexunit"))
> -  ("8CCB A7F5 52B9 CBEA E1FB  2915 8328 C747 0FF1 D807" ;FIXME: to be confirmed!
> -   (name "davexunit (2nd)"))

However, it doesn’t seem right because your most recent commits were
made using that key.

Could you perhaps remove the other key and the FIXME comment from
‘.guix-authorizations’?

TIA,
Ludo’.




^ permalink raw reply	[flat|nested] 2+ messages in thread

* [bug#58715] [EXT] Re: bug#58715: [PATCH] Remove 'davexunit(2nd)' from channel auth
  2022-11-08 13:02 ` [bug#58715] [PATCH] Remove 'davexunit(2nd)' from channel auth Ludovic Courtès
@ 2022-11-08 13:57   ` Thompson, David
  0 siblings, 0 replies; 2+ messages in thread
From: Thompson, David @ 2022-11-08 13:57 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 58715

Hi Ludo,

On Tue, Nov 8, 2022 at 8:02 AM Ludovic Courtès <ludo@gnu.org> wrote:
>
> Hi David,
>
> Someone proposed this change:
>
> > --- a/.guix-authorizations
> > +++ b/.guix-authorizations
> > @@ -37,8 +37,6 @@
> >     (name "dannym"))
> >    ("B3C0 DB4D AD73 BA5D 285E  19AE 5143 0234 CEFD 87C3"
> >     (name "davexunit"))
> > -  ("8CCB A7F5 52B9 CBEA E1FB  2915 8328 C747 0FF1 D807" ;FIXME: to be confirmed!
> > -   (name "davexunit (2nd)"))
>
> However, it doesn’t seem right because your most recent commits were
> made using that key.
>
> Could you perhaps remove the other key and the FIXME comment from
> ‘.guix-authorizations’?

Oh wow, I didn't realize that old key was still hanging around.
Removed the key beginning in B3C0, removed the FIXME comment, and
changed the name of the remaining key to "dthompson".  After the name
change things were still in alphabetical order so I didn't have to
move where it is in the list.

Pushed as commit 96ae718c516a289124a0b91ceeef78b20d187825.

Thanks for bringing this to my attention!

- Dave




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-11-08 13:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20221022141323.18299-1-kreyren@rixotstudio.cz>
2022-11-08 13:02 ` [bug#58715] [PATCH] Remove 'davexunit(2nd)' from channel auth Ludovic Courtès
2022-11-08 13:57   ` [bug#58715] [EXT] Re: bug#58715: " Thompson, David

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).