[bug#32529] Submitting package for SpaceFM

[bug#32529] Submitting package for SpaceFM

[Ison111]

[-- Attachment #1.1: Type: text/plain, Size: 72 bytes --]

Hello,
I would like to submit this package for the SpaceFM file manager.

[-- Attachment #1.2: Type: text/html, Size: 101 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: spacefm.scm --]
[-- Type: text/x-scheme; name="spacefm.scm", Size: 2279 bytes --]

(define-module (gnu packages spacefm)
  #:use-module ((guix licenses) #:prefix license:)
  #:use-module (guix packages)
  #:use-module (guix download)
  #:use-module (guix utils)
  #:use-module (guix build-system gnu)
  #:use-module (gnu packages)
  #:use-module (gnu packages bash)
  #:use-module (gnu packages pkg-config)
  #:use-module (gnu packages gtk)
  #:use-module (gnu packages linux)
  #:use-module (gnu packages freedesktop)
  #:use-module (gnu packages gnome)
  #:use-module (gnu packages glib)
  #:use-module (gnu packages video)
  #:use-module (gnu packages lsof))

(define-public spacefm
  (package
    (name "spacefm")
    (version "1.0.6")
    (source (origin
              (method url-fetch)
              (uri (string-append "https://github.com/IgnorantGuru/spacefm/archive/" version ".tar.gz"))
              (sha256 (base32 "1jg7xfyr7kihjnalxp8wxyb9qjk8hqf5l36rp3s0lvkpmpyakppy"))
              (file-name (string-append name "-" version ".tar.gz"))))

    (build-system gnu-build-system)

    (native-inputs `(("pkg-config"         ,pkg-config)))
    (inputs `(("bash"               ,bash)
              ("gtk+"               ,gtk+)
              ("eudev"              ,eudev)
              ("desktop-file-utils" ,desktop-file-utils)
              ("shared-mime-info"   ,shared-mime-info)
              ("intltool"           ,intltool)
              ("ffmpegthumbnailer"  ,ffmpegthumbnailer)
              ("jmtpfs"             ,jmtpfs)
              ("lsof"               ,lsof)
              ("udisks"             ,udisks)))

    (arguments
     `(#:configure-flags (list (string-append "--with-bash-path="
                                              (assoc-ref %build-inputs "bash")
                                              "/bin/bash")
                               (string-append "--sysconfdir="
                                              (assoc-ref %outputs "out")
                                              "/etc"))))

    (home-page "http://ignorantguru.github.io/spacefm/")
    (synopsis "A multi-panel tabbed file manager")
    (description "Multi-panel tabbed file and desktop manager for GNU/Linux
with built-in VFS, udev- or HAL-based device manager,
customizable menu system, and bash integration")
    (license license:gpl3+)))

[bug#32529] Submitting package for SpaceFM

[Ludovic Courtès]

Hello Ison111,

Could you please send it as a patch as produced by ‘git format-patch’?
Please see
<https://www.gnu.org/software/guix/manual/en/html_node/Submitting-Patches.html>,
which also contains other pieces of advice.

At first sight there are a couple of minor issues that ‘guix lint’
should report.  Usually we don’t indent items in the ‘inputs’ list the
way you did, but I’m nitpicking.

Could you send the updated patch?  Let me know if you have troubles with
any of this.

Thanks,
Ludo’.

[bug#32529] [PATCH] Submit SpaceFM package

[Ison111]

[-- Attachment #1.1: Type: text/plain, Size: 252 bytes --]

Sorry for the poor formatting, and thanks for the documentation. Please let me know if there are still any issues, or if this package should be added to an existing package file instead of given it's own as I'm not sure what the convention is for that.

[-- Attachment #1.2: Type: text/html, Size: 267 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Submit-SpaceFM-package.patch --]
[-- Type: text/x-patch; name="0001-Submit-SpaceFM-package.patch", Size: 2908 bytes --]

From 5212c860c123b161c08208beaa429b581542ce88 Mon Sep 17 00:00:00 2001
From: ison111 <ison111@protonmail.com>
Date: Sun, 26 Aug 2018 02:49:59 -0600
Subject: [PATCH] Submit SpaceFM package

---
 gnu/packages/spacefm.scm | 55 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 55 insertions(+)
 create mode 100644 gnu/packages/spacefm.scm

diff --git a/gnu/packages/spacefm.scm b/gnu/packages/spacefm.scm
new file mode 100644
index 000000000..d32d39ec0
--- /dev/null
+++ b/gnu/packages/spacefm.scm
@@ -0,0 +1,55 @@
+(define-module (gnu packages spacefm)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix packages)
+  #:use-module (guix download)
+  #:use-module (guix utils)
+  #:use-module (guix build-system gnu)
+  #:use-module (gnu packages)
+  #:use-module (gnu packages bash)
+  #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages gtk)
+  #:use-module (gnu packages linux)
+  #:use-module (gnu packages freedesktop)
+  #:use-module (gnu packages gnome)
+  #:use-module (gnu packages glib)
+  #:use-module (gnu packages video)
+  #:use-module (gnu packages lsof))
+
+(define-public spacefm
+  (package
+    (name "spacefm")
+    (version "1.0.6")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://github.com/IgnorantGuru/spacefm/archive/"
+                                  version ".tar.gz"))
+              (sha256
+                (base32
+                  "1jg7xfyr7kihjnalxp8wxyb9qjk8hqf5l36rp3s0lvkpmpyakppy"))
+              (file-name (string-append name "-" version ".tar.gz"))))
+    (build-system gnu-build-system)
+    (native-inputs `(("pkg-config" ,pkg-config)
+                     ("intltool" ,intltool)))
+    (inputs `(("bash" ,bash)
+              ("gtk+" ,gtk+)
+              ("eudev" ,eudev)
+              ("desktop-file-utils" ,desktop-file-utils)
+              ("shared-mime-info" ,shared-mime-info)
+              ("ffmpegthumbnailer" ,ffmpegthumbnailer)
+              ("jmtpfs" ,jmtpfs)
+              ("lsof" ,lsof)
+              ("udisks" ,udisks)))
+    (arguments
+     `(#:configure-flags (list (string-append "--with-bash-path="
+                                              (assoc-ref %build-inputs "bash")
+                                              "/bin/bash")
+                               (string-append "--sysconfdir="
+                                              (assoc-ref %outputs "out")
+                                              "/etc"))))
+    (home-page "http://ignorantguru.github.io/spacefm/")
+    (synopsis "Multi-panel tabbed file manager")
+    (description "Multi-panel tabbed file manager for GNU/Linux
+based on PCManFM with built-in virtual file system, udev- or
+HAL-based device manager, customizable menu system, and bash
+integration.  Comes with a build-in desktop and device manager.")
+    (license license:gpl3+)))
-- 
2.18.0

bug#32529: [PATCH] Submit SpaceFM package

[Ludovic Courtès]

Hello Ison111,

Ison111 <ison111@protonmail.com> skribis:

> Sorry for the poor formatting, and thanks for the documentation. Please let me know if there are still any issues, or if this package should be added to an existing package file instead of given it's own as I'm not sure what the convention is for that.

I ended up moving it to lxde.scm, next to PCManFM.  I added a copyright
line for you, tweaked the description, and added a commit log that
follows our conventions.  You can see the result here:

  https://git.savannah.gnu.org/cgit/guix.git/commit/?id=d2434b6966b06893a4d2b15d0620b05e921fd182

Thank you!

Ludo’.