unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Alex Griffin <a@ajgrf.com>
Cc: 36213@debbugs.gnu.org
Subject: [bug#36213] [PATCH 4/4] gnu: Add pulseaudio-dlna.
Date: Tue, 02 Jul 2019 17:54:37 +0200	[thread overview]
Message-ID: <87lfxg5t4y.fsf@gnu.org> (raw)
In-Reply-To: <3ee05f72-19df-4eb0-89c0-37ddded34d57@www.fastmail.com> (Alex Griffin's message of "Fri, 14 Jun 2019 19:28:16 +0000")

Hi Alex,

Overall this patch set LGTM.  I have two questions:

"Alex Griffin" <a@ajgrf.com> skribis:

> +(define-public pulseaudio-dlna
> +  (let ((commit "4472928dd23f274193f14289f59daec411023ab0")
> +        (revision "1"))

Could you explain why you chose this commit rather than the latest
release?

> +      (arguments `(#:python ,python-2))

Can it run on Python 3?

Since Python 2 is approaching EOL, we’re trying to avoid adding more
Python 2 packages.  If we could remove ‘python2-’ packages from this
patch series, that’d be great; if not, so be it!

Thanks,
Ludo’.

  reply	other threads:[~2019-07-02 15:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-14 19:21 [bug#36213] [PATCH 0/4] Add pulseaudio-dlna Alex Griffin
2019-06-14 19:22 ` [bug#36213] [PATCH 1/4] gnu: Add python-notify2, python2-notify2 Alex Griffin
2019-06-14 19:23 ` [bug#36213] [PATCH 2/4] gnu: Add python-pyroute2, python2-pyroute2 Alex Griffin
2019-06-14 19:27 ` [bug#36213] [PATCH 3/4] gnu: Add python2-zeroconf Alex Griffin
2019-06-14 19:28 ` [bug#36213] [PATCH 4/4] gnu: Add pulseaudio-dlna Alex Griffin
2019-07-02 15:54   ` Ludovic Courtès [this message]
2019-07-02 16:01     ` Alex Griffin
2019-07-04 16:07       ` bug#36213: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lfxg5t4y.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=36213@debbugs.gnu.org \
    --cc=a@ajgrf.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).