From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:41839)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hiL7j-0003iT-Om
 for guix-patches@gnu.org; Tue, 02 Jul 2019 11:55:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hiL7Z-0003mQ-1u
 for guix-patches@gnu.org; Tue, 02 Jul 2019 11:55:08 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:38890)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1hiL7V-0003l9-TG
 for guix-patches@gnu.org; Tue, 02 Jul 2019 11:55:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hiL7V-0000Nl-R1
 for guix-patches@gnu.org; Tue, 02 Jul 2019 11:55:01 -0400
Subject: [bug#36213] [PATCH 4/4] gnu: Add pulseaudio-dlna.
Resent-Message-ID: <handler.36213.B36213.15620828861446@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <9f57b4cb-e4e9-4dfa-9308-9263b5edfe23@www.fastmail.com>
 <3ee05f72-19df-4eb0-89c0-37ddded34d57@www.fastmail.com>
Date: Tue, 02 Jul 2019 17:54:37 +0200
In-Reply-To: <3ee05f72-19df-4eb0-89c0-37ddded34d57@www.fastmail.com> (Alex
 Griffin's message of "Fri, 14 Jun 2019 19:28:16 +0000")
Message-ID: <87lfxg5t4y.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Alex Griffin <a@ajgrf.com>
Cc: 36213@debbugs.gnu.org

Hi Alex,

Overall this patch set LGTM.  I have two questions:

"Alex Griffin" <a@ajgrf.com> skribis:

> +(define-public pulseaudio-dlna
> +  (let ((commit "4472928dd23f274193f14289f59daec411023ab0")
> +        (revision "1"))

Could you explain why you chose this commit rather than the latest
release?

> +      (arguments `(#:python ,python-2))

Can it run on Python 3?

Since Python 2 is approaching EOL, we=E2=80=99re trying to avoid adding more
Python 2 packages.  If we could remove =E2=80=98python2-=E2=80=99 packages =
from this
patch series, that=E2=80=99d be great; if not, so be it!

Thanks,
Ludo=E2=80=99.