[bug#38347] gnome-contacts

[Tobias Geerinckx-Rice via Guix-patches via <guix-patches@gnu.org>]

[-- Attachment #1: Type: text/plain, Size: 3130 bytes --]

Raghav,

Raghav Gururajan 写道：
> Please find the attached file containing patch to add 
> gnome-contacts.

Thank you!  Congratulations on your first patch, and may there be 
many more.

I was going to fix the points below myself, but then they 
multiplied and hey, I can always say it's a good lesson for you, 
right?  Just send the result to this thread with ‘v2’ clearly in 
the subject line.

* Using ‘name’ in source URIs is harmless but also completely 
  useless.  Just use:

    (uri (string-append "mirror://gnome/sources/gnome-contacts/"
                        (version-major+minor version) "/"
                        "gnome-contacts-" version ".tar.xz"))

* Could you explain *why* generate-vapis needs to be done 
  manually?  For a mostly non-GNOMEhead like me, it's just black 
  magic.

* Nitpick: the ‘`’ of `(#:phases should fall under the ‘(’ of 
  (arguments:

    (arguments
     `(#:phases

  You can use C-M-q in emacs or run etc/indent-code.el manually to 
  indent the code for you.

* You need to move inputs that appear in ‘guix gc --references 
  /gnu/store/…gnome-contacts…’ from (native-inputs) to (inputs).

* Fix ‘dockbook-xsl’ typo.

* Since you're rewriting most *inputs anyway, please order them 
  alphabetically.

* Synopses don't need to include the name of the programme or a 
  leading article (‘a’):

    (synopsis "GNOME's integrated address book")

* The description is far too short, and just not very relevant to 
  me.

  I took a look at the README; what about:

    (description
     "Contacts is GNOME's integrated address book.  It organizes 
     contact                                         
information from all your online and offline sources, and provides 
a central                                     
place to:                                                                                                        
@enumerate                                                                                                       
@item search for and view contacts,                                                                              
@item edit contact details and make new contacts,                                                                
@item integrate with online address books,                                                                       
@item automatically link contacts from different online sources.                                                 
@end enumerate\n")

* Add ‘license:’ prefix to gpl2 (without it, Guix won't even 
  work).

* A randomly chosen source file 
  (https://gitlab.gnome.org/GNOME/gnome-contacts/blob/master/src/cc-crop-area.c) 
  says ‘or any later version’.  This makes the licence gpl2+, not 
  gpl2 (-only), unless there are files that lack this wording. 
  Could you check?

                                 * * *

I'm happy to hear that you have more patches planned.  Please 
check them for similar points and send them to guix-patches at 
gnu.org.

Thanks again!

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]