From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:44957) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iYaVr-0003Gd-SJ for guix-patches@gnu.org; Sat, 23 Nov 2019 13:52:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iYaVq-0002pH-La for guix-patches@gnu.org; Sat, 23 Nov 2019 13:52:07 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:48989) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iYaVp-0002oU-HT for guix-patches@gnu.org; Sat, 23 Nov 2019 13:52:06 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iYaVp-00018T-FS for guix-patches@gnu.org; Sat, 23 Nov 2019 13:52:05 -0500 Subject: [bug#38347] gnome-contacts Resent-Message-ID: References: <225ae64271283846a65401032635ec60731f7277.camel@disroot.org> In-reply-to: <225ae64271283846a65401032635ec60731f7277.camel@disroot.org> Date: Sat, 23 Nov 2019 19:51:10 +0100 Message-ID: <87lfs677fl.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" Reply-to: Tobias Geerinckx-Rice , Tobias Geerinckx-Rice via Guix-patches From: Tobias Geerinckx-Rice via Guix-patches via To: Raghav Gururajan Cc: 38347@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Raghav, Raghav Gururajan =E5=86=99=E9=81=93=EF=BC=9A > Please find the attached file containing patch to add=20 > gnome-contacts. Thank you! Congratulations on your first patch, and may there be=20 many more. I was going to fix the points below myself, but then they=20 multiplied and hey, I can always say it's a good lesson for you,=20 right? Just send the result to this thread with =E2=80=98v2=E2=80=99 clear= ly in=20 the subject line. * Using =E2=80=98name=E2=80=99 in source URIs is harmless but also complete= ly=20 useless. Just use: (uri (string-append "mirror://gnome/sources/gnome-contacts/" (version-major+minor version) "/" "gnome-contacts-" version ".tar.xz")) * Could you explain *why* generate-vapis needs to be done=20 manually? For a mostly non-GNOMEhead like me, it's just black=20 magic. * Nitpick: the =E2=80=98`=E2=80=99 of `(#:phases should fall under the =E2= =80=98(=E2=80=99 of=20 (arguments: (arguments `(#:phases You can use C-M-q in emacs or run etc/indent-code.el manually to=20 indent the code for you. * You need to move inputs that appear in =E2=80=98guix gc --references=20 /gnu/store/=E2=80=A6gnome-contacts=E2=80=A6=E2=80=99 from (native-inputs)= to (inputs). * Fix =E2=80=98dockbook-xsl=E2=80=99 typo. * Since you're rewriting most *inputs anyway, please order them=20 alphabetically. * Synopses don't need to include the name of the programme or a=20 leading article (=E2=80=98a=E2=80=99): (synopsis "GNOME's integrated address book") * The description is far too short, and just not very relevant to=20 me. I took a look at the README; what about: (description "Contacts is GNOME's integrated address book. It organizes=20 contact=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 information from all your online and offline sources, and provides=20 a central=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 place to:=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20 @enumerate=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20 @item search for and view contacts,=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 @item edit contact details and make new contacts,=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20 @item integrate with online address books,=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20 @item automatically link contacts from different online sources.=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 @end enumerate\n") * Add =E2=80=98license:=E2=80=99 prefix to gpl2 (without it, Guix won't eve= n=20 work). * A randomly chosen source file=20 (https://gitlab.gnome.org/GNOME/gnome-contacts/blob/master/src/cc-crop-ar= ea.c)=20 says =E2=80=98or any later version=E2=80=99. This makes the licence gpl2= +, not=20 gpl2 (-only), unless there are files that lack this wording.=20 Could you check? * * * I'm happy to hear that you have more patches planned. Please=20 check them for similar points and send them to guix-patches at=20 gnu.org. Thanks again! T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfo+u0AlEeO9y5k0W2Imw8BjFSTwFAl3Zf54ACgkQ2Imw8BjF STxlvw/8Dc6oz8Bxg7pcCcB2amlsI6cko4EG3NamXvJb7ovtIoAJY8E+as+/XMNx LaLdKddsCsaefe8MVypw1ykGoucaHcNewkW6TY6OVM6AhcfD0RPRas2fZH9XmgSO RPKEanyaZRUJ0HKr8TqhfGlyjdA8MmkXtVjV8enlsj7zMfJHm6K8muLaSsoTpvn+ RsizH1TwewR8PayNtJ84zDJNJ7a/LXUGYNi2jmvk4jbkKi9sRYk42/t68UmF6aoQ 5/eWHbGhEv0PUx+ycdrX/8bm1M7p5RyU9hlX1CzMBFI26SlmWX6/DzBPSeWcb64v h2yWiFmDdETkFRvXPJFb/4KntNqM4SMEgU078LJBCz/kCbO3dAEJsUYyO3iflZEa zIdVdSnXDIVmHAQDzU4ZKP4w4bCwa/ockP0U0yo1cJDgPc03iLJm5zuNVjPkummv HG/Qbb7ZneWJayuH9TLs1oysgJG5P2VdgL03pvCgMBxSsXhVKaCFa9vhhQ6CsjuM G5lBuWgHuU2vN3MX2LL5bnYdFpoxc+t5tD8YJQMhYfp6n9V2R0pTYa8stk2WXRRY iphs4wiULEUZgGv1cOgPKdPj3EiyrPjhH0TWXyJ9mK/0K0WeH/9Azygv3YoM9pRf yBKjXTlYr3kZI1bihpikkqY7Gwl3RmNUVLCDiu3Gpw1qx3G8kD4= =WaFM -----END PGP SIGNATURE----- --=-=-=--