[bug#39292] [PATCH 03/10] gnu: Add python-rawkit

[Christopher Baines <mail@cbaines.net>]

[-- Attachment #1: Type: text/plain, Size: 2402 bytes --]


Sebastian Schott <sschott@mailbox.org> writes:

> * gnu/packages/python-xyz.scm (python-rawkit): New variable.
> ---
>  gnu/packages/python-xyz.scm | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
> index 1592c6b511..7c4b0495fa 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -126,6 +126,7 @@
>    #:use-module (gnu packages openstack)
>    #:use-module (gnu packages pcre)
>    #:use-module (gnu packages perl)
> +  #:use-module (gnu packages photo)
>    #:use-module (gnu packages pkg-config)
>    #:use-module (gnu packages python)
>    #:use-module (gnu packages python-check)
> @@ -167,6 +168,26 @@
>    #:use-module (srfi srfi-1)
>    #:use-module (srfi srfi-26))
>
> +(define-public python-rawkit
> +  (package
> +    (name "python-rawkit")
> +    (version "0.6.0")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (pypi-uri "rawkit" version))
> +              (sha256
> +               (base32
> +                "0vrhrpr70i61y5q5ysk341x1539ff1q1k82g59zq69lv16s0f76s"))))
> +    (build-system python-build-system)
> +    (native-inputs
> +     `(("libraw" ,libraw)

This might need to be an input, rather than a native-input. The
distinction is important for cross-compilation, as at that point, the
architecture for native-inputs matches where the build is taking place,
but the architecture for inputs matches the target architecture.

The distinction is also just useful to track what's needed at runtime,
rather than just build time, and I'm guessing libraw is required at
runtime.

> +       ("python-pytest" ,python-pytest)
> +       ("python-mock" ,python-mock)))
> +    (home-page "https://rawkit.readthedocs.io/en/v0.6.0/")

Maybe tweak this to not be version dependent (if possible).

> +    (synopsis "Ctypes-based LibRaw binding for Python")
> +    (description "The rawkit package provides two modules:  rawkit
> and libraw.  The rawkit module provides a high-level Pythonic
> interface for developing raw photos, while the libraw module provides
> a CTypes based interface for interacting with the low-level LibRaw C
> APIs.")

This line is too long, could you split the description across multiple
lines.

> +    (license license:expat)))
> +
>  (define-public python-easygui
>    (package
>      (name "python-easygui")

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]