unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Sebastian Schott <sschott@mailbox.org>
Cc: 39292@debbugs.gnu.org
Subject: [bug#39292] [PATCH 01/10] gnu: Add python-pymediainfo
Date: Sun, 15 Mar 2020 14:47:28 -0400	[thread overview]
Message-ID: <20200315184728.GG5561@jasmine.lan> (raw)
In-Reply-To: <20200307151146.2581-1-sschott@mailbox.org>

On Sat, Mar 07, 2020 at 04:11:37PM +0100, Sebastian Schott wrote:
> * gnu/packages/python-xyz.scm (python-pymediainfo): New variable.

Thanks for this patch series Sebastian! Overall it looks good...

I only have one nitpick:

> +             ;; Skip the only failing test "test_parse_url"
> +             (invoke "pytest" "-vv" "-k" "not test_parse_url")
> +             #t)))))

How does the test fail? We should add comments explaining why tests are
skipped, not just that they are fail so we skip them :)

And while you are adding that comment or fixing the test, can you rebase
the patches on the current master branch? They no longer apply due to
other changes in python-xyz.scm.

  parent reply	other threads:[~2020-03-15 18:48 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-26 10:07 [bug#39292] [PATCH 0/10] gnu: Add rapid-photo-downloader sschott
2020-01-26 17:24 ` [bug#39292] [PATCH 01/10] gnu: Add python-pymediainfo Sebastian Schott
2020-01-26 17:24   ` [bug#39292] [PATCH 02/10] gnu: Add python-easygui Sebastian Schott
2020-01-26 17:24   ` [bug#39292] [PATCH 03/10] gnu: Add python-rawkit Sebastian Schott
2020-01-27  8:39     ` Christopher Baines
2020-01-26 17:24   ` [bug#39292] [PATCH 04/10] gnu: Add python-d2to1 Sebastian Schott
2020-01-26 17:24   ` [bug#39292] [PATCH 05/10] gnu: Add python-colour Sebastian Schott
2020-01-26 17:24   ` [bug#39292] [PATCH 06/10] gnu: Add python-gphoto2 Sebastian Schott
2020-01-27  8:40     ` Christopher Baines
2020-01-26 17:24   ` [bug#39292] [PATCH 07/10] gnu: Add python-pyprind Sebastian Schott
2020-01-26 17:24   ` [bug#39292] [PATCH 08/10] gnu: Add python-colorlog Sebastian Schott
2020-01-26 17:24   ` [bug#39292] [PATCH 09/10] gnu: Add python-tenacity Sebastian Schott
2020-01-26 17:24   ` [bug#39292] [PATCH 10/10] gnu: Add rapid-photo-downloader Sebastian Schott
2020-01-27  8:49     ` Christopher Baines
2020-01-27  8:35   ` [bug#39292] [PATCH 01/10] gnu: Add python-pymediainfo Christopher Baines
2020-02-02  9:36 ` [bug#39292] Re: [bug#39292] [PATCH 10/10] gnu: Add rapid-photo-downloader Sebastian Schott
2020-02-02 10:11   ` Christopher Baines
2020-03-07 15:11 ` [bug#39292] [PATCH 01/10] gnu: Add python-pymediainfo Sebastian Schott
2020-03-07 15:11   ` [bug#39292] [PATCH 02/10] gnu: Add python-easygui Sebastian Schott
2020-03-07 15:11   ` [bug#39292] [PATCH 03/10] gnu: Add python-rawkit Sebastian Schott
2020-03-07 15:11   ` [bug#39292] [PATCH 04/10] gnu: Add python-d2to1 Sebastian Schott
2020-03-07 15:11   ` [bug#39292] [PATCH 05/10] gnu: Add python-colour Sebastian Schott
2020-03-07 15:11   ` [bug#39292] [PATCH 06/10] gnu: Add python-gphoto2 Sebastian Schott
2020-03-07 15:11   ` [bug#39292] [PATCH 07/10] gnu: Add python-pyprind Sebastian Schott
2020-03-07 15:11   ` [bug#39292] [PATCH 08/10] gnu: Add python-colorlog Sebastian Schott
2020-03-07 15:11   ` [bug#39292] [PATCH 09/10] gnu: Add python-tenacity Sebastian Schott
2020-03-07 15:11   ` [bug#39292] [PATCH 10/10] gnu: Add rapid-photo-downloader Sebastian Schott
2020-03-15 18:47   ` Leo Famulari [this message]
2020-03-15 21:26     ` [bug#39292] [PATCH 01/10] gnu: Add python-pymediainfo Christopher Baines
2020-03-15 21:39       ` Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200315184728.GG5561@jasmine.lan \
    --to=leo@famulari.name \
    --cc=39292@debbugs.gnu.org \
    --cc=sschott@mailbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).