unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Marius Bakke <mbakke@fastmail.com>
To: pinoaffe@airmail.cc, 40165@debbugs.gnu.org
Subject: [bug#40165] Subject: [PATCH] gnu: Add python-flask-markdown.
Date: Sun, 29 Mar 2020 22:07:04 +0200	[thread overview]
Message-ID: <87lfnjvsbb.fsf@devup.no> (raw)
In-Reply-To: <978aeda27a795fd06ef7fb77049adbe8@airmail.cc>

[-- Attachment #1: Type: text/plain, Size: 1323 bytes --]

pinoaffe@airmail.cc writes:

> * gnu/packages/python-web.scm (python-flask-markdown): New variable.

Thanks!

[...]

> +(define-public python-flask-markdown
> +  (package
> +    (name "python-flask-markdown")
> +    (version "0.3")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (pypi-uri "Flask-Markdown" version))
> +        (sha256
> +          (base32
> +            "0l32ikv4f7va926jlq4f7gx0xid247bhlxl6bd9av5dk8ljz1hyq"))))
> +    (build-system python-build-system)
> +    (arguments
> +       `(#:tests? #f))

Can you add a comment about why tests are disabled?

> +    (propagated-inputs
> +      `(("python-markdown" ,python-markdown)
> +        ("python-flask" ,python-flask)))
> +    (native-inputs
> +      `(("python-nose" ,python-nose)))
> +    (home-page
> +      "http://github.com/dcolish/flask-markdown")
> +    (synopsis
> +      "Small extension to make using markdown in flask easy")
> +    (description
> +      "Small extension to make using markdown in flask easy")

Can you expand on the description a bit?  Being identical to the
synopsis is not very helpful for interested readers.

Please also adjust the indentation of the whole package.  If you are not
using Emacs you can use the ./etc/indent-code.el script.

Can you send an updated patch?  Thanks in advance!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

      reply	other threads:[~2020-03-29 20:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-21  8:06 [bug#40165] Subject: [PATCH] gnu: Add python-flask-markdown pinoaffe
2020-03-29 20:07 ` Marius Bakke [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lfnjvsbb.fsf@devup.no \
    --to=mbakke@fastmail.com \
    --cc=40165@debbugs.gnu.org \
    --cc=pinoaffe@airmail.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).