From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:44131)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jIeDz-0004gg-FN
 for guix-patches@gnu.org; Sun, 29 Mar 2020 16:08:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jIeDy-0004bd-Bs
 for guix-patches@gnu.org; Sun, 29 Mar 2020 16:08:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:48380)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jIeDy-0004bO-8U
 for guix-patches@gnu.org; Sun, 29 Mar 2020 16:08:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jIeDy-0000US-21
 for guix-patches@gnu.org; Sun, 29 Mar 2020 16:08:02 -0400
Subject: [bug#40165] Subject: [PATCH] gnu: Add python-flask-markdown.
Resent-Message-ID: <handler.40165.B40165.15855124361820@debbugs.gnu.org>
From: Marius Bakke <mbakke@fastmail.com>
In-Reply-To: <978aeda27a795fd06ef7fb77049adbe8@airmail.cc>
References: <978aeda27a795fd06ef7fb77049adbe8@airmail.cc>
Date: Sun, 29 Mar 2020 22:07:04 +0200
Message-ID: <87lfnjvsbb.fsf@devup.no>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: pinoaffe@airmail.cc, 40165@debbugs.gnu.org

--=-=-=
Content-Type: text/plain

pinoaffe@airmail.cc writes:

> * gnu/packages/python-web.scm (python-flask-markdown): New variable.

Thanks!

[...]

> +(define-public python-flask-markdown
> +  (package
> +    (name "python-flask-markdown")
> +    (version "0.3")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (pypi-uri "Flask-Markdown" version))
> +        (sha256
> +          (base32
> +            "0l32ikv4f7va926jlq4f7gx0xid247bhlxl6bd9av5dk8ljz1hyq"))))
> +    (build-system python-build-system)
> +    (arguments
> +       `(#:tests? #f))

Can you add a comment about why tests are disabled?

> +    (propagated-inputs
> +      `(("python-markdown" ,python-markdown)
> +        ("python-flask" ,python-flask)))
> +    (native-inputs
> +      `(("python-nose" ,python-nose)))
> +    (home-page
> +      "http://github.com/dcolish/flask-markdown")
> +    (synopsis
> +      "Small extension to make using markdown in flask easy")
> +    (description
> +      "Small extension to make using markdown in flask easy")

Can you expand on the description a bit?  Being identical to the
synopsis is not very helpful for interested readers.

Please also adjust the indentation of the whole package.  If you are not
using Emacs you can use the ./etc/indent-code.el script.

Can you send an updated patch?  Thanks in advance!

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl6A/+gACgkQoqBt8qM6
VPryIgf+NllybFZTz5+OLq6BWBprjmsugd00oszkm/M9Ut2xAbZEpLEEt6d7gA5V
MMozv4Tlvglt0NgGA5WgyR4wcnosGp/OsYv1O+DMKMacZ/KKsvrPsmccj3AUONAj
pJazQZBMM/9jd/4KUYhgdSNzbTs8qcmDEWGJPUppS2n0sF5ocpl8IivvDyLt8Hn1
8LqXA9KXWlTpigX4h45l4up1N6EgyiLfeLGdq3GY5eQ1FFHcYIY4s3wosjl7raPZ
UJqcsZWxJlsZltWqxBufpudlOpq+IF42TTviasDitbIptKb7gxGZXX9MJiTG8TPT
nmypcBesBUNVH+uuxx1ASw5+L3bdTQ==
=3Gnp
-----END PGP SIGNATURE-----
--=-=-=--