unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Vincent Legoll <vincent.legoll@gmail.com>
Cc: 40691@debbugs.gnu.org
Subject: [bug#40691] [PATCH 3/3] gnu: Add gromacs.
Date: Sun, 03 May 2020 12:46:36 +0200	[thread overview]
Message-ID: <87lfm91ek3.fsf@gnu.org> (raw)
In-Reply-To: <20200502164325.2028-3-vincent.legoll@gmail.com> (Vincent Legoll's message of "Sat, 2 May 2020 18:43:25 +0200")

Vincent Legoll <vincent.legoll@gmail.com> skribis:

> * gnu/packages/bioinformatics.scm (gromacs): New variable.
> * gnu/packages/patches/gromacs-tinyxml2.patch: New file...
> * gnu/local.mk (dist_patch_DATA): ...add it here.

I wonder if chemistry.scm would be more appropriate, WDYT?

> --- /dev/null
> +++ b/gnu/packages/patches/gromacs-tinyxml2.patch
> @@ -0,0 +1,50 @@

Could you add one or two sentences at the top of the file explaining
what it does and what its upstream status is?  It’s not obvious why the
reference data needs to be adjusted as a consequence of unbundling
tinyxml2.

That’s it!

Could you send updated patches?  I’ll be happy to commit them.  :-)

Thank you for all the work!

Ludo’.




  reply	other threads:[~2020-05-03 10:47 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-17 22:22 [bug#40691] [PATCH 0/1] gnu: Add gromacs Vincent Legoll
2020-04-17 22:24 ` [bug#40691] [PATCH] " Vincent Legoll
2020-04-17 22:48 ` [bug#40691] gromacs - WIP, submitted Vincent Legoll
2020-04-19 22:19 ` [bug#40691] [PATCH 0/1] gnu: Add gromacs Ludovic Courtès
2020-04-20 22:15   ` [bug#40691] [PATCH v2 1/1] " Vincent Legoll
2020-04-22 15:38     ` Ludovic Courtès
2020-04-23 13:07       ` [bug#40691] [PATCH v3 " Vincent Legoll
2020-04-23 19:52         ` Ludovic Courtès
2020-05-01 22:30           ` Vincent Legoll
2020-05-02 13:35             ` Ludovic Courtès
2020-05-02 13:46           ` [bug#40691] [PATCH v4 0/3] gnu: Add gromacs, tng & lmfit Vincent Legoll
2020-05-03 10:39             ` Ludovic Courtès
2020-05-03 22:31               ` [bug#40691] [PATCH v6 " Vincent Legoll
2020-05-04  8:40                 ` bug#40691: " Ludovic Courtès
2020-05-02 13:48 ` [bug#40691] [PATCH 1/3] gnu: Add tng Vincent Legoll
2020-05-02 13:48   ` [bug#40691] [PATCH 2/3] gnu: Add lmfit Vincent Legoll
2020-05-02 13:48   ` [bug#40691] [PATCH 3/3] gnu: Add gromacs Vincent Legoll
2020-05-02 13:53   ` [bug#40691] [PATCH v4 0/3]: " Vincent Legoll
2020-05-02 16:43 ` [bug#40691] [PATCH 1/3] gnu: Add tng Vincent Legoll
2020-05-02 16:43   ` [bug#40691] [PATCH 2/3] gnu: Add lmfit Vincent Legoll
2020-05-03 10:43     ` Ludovic Courtès
2020-05-02 16:43   ` [bug#40691] [PATCH 3/3] gnu: Add gromacs Vincent Legoll
2020-05-03 10:46     ` Ludovic Courtès [this message]
2020-05-03 10:41   ` [bug#40691] [PATCH 1/3] gnu: Add tng Ludovic Courtès
2020-05-03 22:32 ` Vincent Legoll
2020-05-03 22:32   ` [bug#40691] [PATCH 2/3] gnu: Add lmfit Vincent Legoll
2020-05-03 22:32   ` [bug#40691] [PATCH 3/3] gnu: Add gromacs Vincent Legoll
2020-05-03 22:39     ` Vincent Legoll
2020-05-03 22:39 ` [bug#40691] [PATCH] " Vincent Legoll
2020-05-05 21:27 ` [bug#40691] Upstream patches are being merged Vincent Legoll

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lfm91ek3.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=40691@debbugs.gnu.org \
    --cc=vincent.legoll@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).