[bug#41134] [PATCH 1/2] gnu: Add libindicator.

unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed

* [bug#41134] [PATCH 1/2] gnu: Add libindicator.
@ 2020-05-08  6:34 Pierre Neidhardt
       [not found] ` <handler.41134.B.158891966521951.ack@debbugs.gnu.org>
  2020-05-11 11:38 ` [bug#41134] LibAppIndicator Raghav Gururajan
  0 siblings, 2 replies; 9+ messages in thread
From: Pierre Neidhardt @ 2020-05-08  6:34 UTC (permalink / raw)
  To: 41134


[-- Attachment #1.1: Type: text/plain, Size: 142 bytes --]

Sent this patch 24 hours ago with git-sendemail.  Nothing showed up.
Trying again manually.

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-libindicator.patch --]
[-- Type: text/x-patch, Size: 2359 bytes --]

From 9520260642783cb3a16dac844221260ccb666c41 Mon Sep 17 00:00:00 2001
From: Pierre Neidhardt <mail@ambrevar.xyz>
Date: Thu, 7 May 2020 10:57:53 +0200
Subject: [PATCH 1/2] gnu: Add libindicator.

* gnu/packages/freedesktop.scm (libindicator): New variable.
---
 gnu/packages/freedesktop.scm | 41 ++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
index 75d0118f83..d88c151df7 100644
--- a/gnu/packages/freedesktop.scm
+++ b/gnu/packages/freedesktop.scm
@@ -1760,3 +1760,44 @@ that provides a graphical boot animation while the boot process happens in the
 background.  You are not supposed to install this on your own, it is only
 useful with system integration.")
     (license license:gpl2+)))
+
+(define-public libindicator
+  (package
+    (name "libindicator")
+    (version "12.10.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://launchpad.net/libindicator/"
+             (version-major+minor version) "/" version
+             "/+download/libindicator-" version ".tar.gz"))
+       (sha256
+        (base32
+         "0zs4z7l9b57jldwz0ban77f3c2zq43ambd0dssf5qg9i216f9lmj"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("gobject-introspection" ,gobject-introspection)
+       ("glib:bin" ,glib "bin")))
+    (inputs
+     `(("gtk+" ,gtk+)
+       ("glib" ,glib)))
+    (arguments
+     `(#:make-flags '("CFLAGS=-Wno-error=deprecated-declarations")
+       #:tests? #f              ; FIXME: Require the dbus-test-runner package.
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'fix-typo
+           (lambda _
+             (substitute* "configure"
+               (("LIBINDICATOR_LIBS\\+\\=.......") "LIBINDICATOR_LIBS+=\" $LIBM\""))
+             (substitute* "tests/Makefile.in"
+               (("/bin/bash") (which "bash"))
+               (("/bin/sh") (which "sh")))
+             #t)))))
+    (home-page "https://launchpad.net/libindicator")
+    (synopsis "Convience functions for desktop indicators")
+    (description "A set of symbols and convience functions that all indicators
+would like to use.  Originally from the Ayatana indicators project.")
+    (license license:gpl3+)))
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

[parent not found: <handler.41134.B.158891966521951.ack@debbugs.gnu.org>]

* [bug#41134] [PATCH 2/2] gnu: Add libappindicator.
       [not found] ` <handler.41134.B.158891966521951.ack@debbugs.gnu.org>
@ 2020-05-08  6:42   ` Pierre Neidhardt
  2020-05-11 11:46     ` Nicolò Balzarotti
  0 siblings, 1 reply; 9+ messages in thread
From: Pierre Neidhardt @ 2020-05-08  6:42 UTC (permalink / raw)
  To: 41134


[-- Attachment #1.1: Type: text/plain, Size: 2929 bytes --]


* gnu/packages/freedesktop.scm (libappindicator): New variable.
---
 gnu/packages/freedesktop.scm | 58 ++++++++++++++++++++++++++++++++++++
 1 file changed, 58 insertions(+)

diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
index d88c151df7..20e4024dfb 100644
--- a/gnu/packages/freedesktop.scm
+++ b/gnu/packages/freedesktop.scm
@@ -1801,3 +1801,61 @@ useful with system integration.")
     (description "A set of symbols and convience functions that all indicators
 would like to use.  Originally from the Ayatana indicators project.")
     (license license:gpl3+)))
+
+(define-public libappindicator
+  (package
+    (name "libappindicator")
+    (version "12.10.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://launchpad.net/libappindicator/"
+             (version-major+minor version) "/" version
+             "/+download/libappindicator-" version ".tar.gz"))
+       (sha256
+        (base32
+         "17xlqd60v0zllrxp8bgq3k5a1jkj0svkqn8rzllcyjh8k0gpr46m"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("glib:bin" ,glib "bin")
+       ("gobject-introspection" ,gobject-introspection)
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("gtk+" ,gtk+)
+       ("dbus-glib" ,dbus-glib)
+       ("python" ,python-2)
+       ("python2-pygtk" ,python2-pygtk)
+       ("python2-pygobject" ,python2-pygobject)
+       ("libdbusmenu" ,libdbusmenu)
+       ("libindicator" ,libindicator)))
+    (arguments
+     `(#:configure-flags '("--with-gtk=3")
+       #:make-flags '("CFLAGS=-Wno-error=deprecated-declarations")
+       #:tests? #f              ; FIXME: Require the dbus-test-runner package.
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'fix-codegen-path
+           (lambda _
+             (substitute* "configure"
+               (("PYGTK_CODEGEN=.*") "PYGTK_CODEGEN=pygtk-codegen-2.0\n"))
+             #t))
+         (add-after 'unpack 'disable-fail-on-error
+           (lambda _
+             (substitute* "src/Makefile.in"
+               (("-Werror") ""))
+             #t))
+         (add-after 'unpack 'fix-test
+           (lambda _
+             (substitute* "tests/Makefile.in"
+               (("/bin/bash") (which "bash"))
+               (("/bin/sh") (which "sh")))
+             (substitute* "docs/reference/Makefile.in"
+               (("/bin/sh") (which "sh")))
+             #t)))))
+    (home-page "https://launchpad.net/libappindicator")
+    (synopsis "Library to export a menu into the system tray")
+    (description "A library to allow applications to export a menu, originally
+into the Unity menu bar.  Based on KSNI, it also works in KDE and will
+fallback to generic system tray support if none of those are available.")
+    (license license:gpl3+)))
-- 
2.25.1

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0002-gnu-Add-libappindicator.patch --]
[-- Type: text/x-patch, Size: 3054 bytes --]

From a82ab4f66aed111c07358a238de3fc1e369799c0 Mon Sep 17 00:00:00 2001
From: Pierre Neidhardt <mail@ambrevar.xyz>
Date: Thu, 7 May 2020 11:24:09 +0200
Subject: [PATCH 2/2] gnu: Add libappindicator.

* gnu/packages/freedesktop.scm (libappindicator): New variable.
---
 gnu/packages/freedesktop.scm | 58 ++++++++++++++++++++++++++++++++++++
 1 file changed, 58 insertions(+)

diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
index d88c151df7..20e4024dfb 100644
--- a/gnu/packages/freedesktop.scm
+++ b/gnu/packages/freedesktop.scm
@@ -1801,3 +1801,61 @@ useful with system integration.")
     (description "A set of symbols and convience functions that all indicators
 would like to use.  Originally from the Ayatana indicators project.")
     (license license:gpl3+)))
+
+(define-public libappindicator
+  (package
+    (name "libappindicator")
+    (version "12.10.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://launchpad.net/libappindicator/"
+             (version-major+minor version) "/" version
+             "/+download/libappindicator-" version ".tar.gz"))
+       (sha256
+        (base32
+         "17xlqd60v0zllrxp8bgq3k5a1jkj0svkqn8rzllcyjh8k0gpr46m"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("glib:bin" ,glib "bin")
+       ("gobject-introspection" ,gobject-introspection)
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("gtk+" ,gtk+)
+       ("dbus-glib" ,dbus-glib)
+       ("python" ,python-2)
+       ("python2-pygtk" ,python2-pygtk)
+       ("python2-pygobject" ,python2-pygobject)
+       ("libdbusmenu" ,libdbusmenu)
+       ("libindicator" ,libindicator)))
+    (arguments
+     `(#:configure-flags '("--with-gtk=3")
+       #:make-flags '("CFLAGS=-Wno-error=deprecated-declarations")
+       #:tests? #f              ; FIXME: Require the dbus-test-runner package.
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'fix-codegen-path
+           (lambda _
+             (substitute* "configure"
+               (("PYGTK_CODEGEN=.*") "PYGTK_CODEGEN=pygtk-codegen-2.0\n"))
+             #t))
+         (add-after 'unpack 'disable-fail-on-error
+           (lambda _
+             (substitute* "src/Makefile.in"
+               (("-Werror") ""))
+             #t))
+         (add-after 'unpack 'fix-test
+           (lambda _
+             (substitute* "tests/Makefile.in"
+               (("/bin/bash") (which "bash"))
+               (("/bin/sh") (which "sh")))
+             (substitute* "docs/reference/Makefile.in"
+               (("/bin/sh") (which "sh")))
+             #t)))))
+    (home-page "https://launchpad.net/libappindicator")
+    (synopsis "Library to export a menu into the system tray")
+    (description "A library to allow applications to export a menu, originally
+into the Unity menu bar.  Based on KSNI, it also works in KDE and will
+fallback to generic system tray support if none of those are available.")
+    (license license:gpl3+)))
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [bug#41134] [PATCH 2/2] gnu: Add libappindicator.
  2020-05-08  6:42   ` [bug#41134] [PATCH 2/2] gnu: Add libappindicator Pierre Neidhardt
@ 2020-05-11 11:46     ` Nicolò Balzarotti
  2020-05-11 12:14       ` Pierre Neidhardt
  0 siblings, 1 reply; 9+ messages in thread
From: Nicolò Balzarotti @ 2020-05-11 11:46 UTC (permalink / raw)
  To: Pierre Neidhardt, 41134

[-- Attachment #1: Type: text/plain, Size: 274 bytes --]


Hi Pierre,

I packaged some time ago dbus-test-runner (libappindicator-12.10.1,
sligthly newer than yours, with all dependencies with all tests) but
never had the time to submit it.

If you want to take ownership of the patch and enable tests, here's the
file I was using


[-- Attachment #2: blueman.scm --]
[-- Type: application/octet-stream, Size: 9313 bytes --]

(define-module (guixpkgs blueman)
  #:use-module ((guix licenses) #:prefix license:)
  #:use-module (guix build-system gnu)
  #:use-module (guix build-system meson)
  #:use-module (guix download)
  #:use-module (guix packages)
  #:use-module (guix git-download)
  #:use-module (guix utils)
  #:use-module (gnu packages autotools)
  #:use-module (gnu packages cmake)
  #:use-module (gnu packages glib)
  #:use-module (gnu packages gnome)
  #:use-module (gnu packages gtk)
  #:use-module (gnu packages linux)
  #:use-module (gnu packages python)
  #:use-module (gnu packages python-xyz)
  #:use-module (gnu packages pulseaudio)
  #:use-module (gnu packages pkg-config)
  #:use-module (gnu packages xorg))

(define-public dbus-test-runner
  (package
    (name "dbus-test-runner")
    (version "19.04.0")
    (source (origin
	      (method url-fetch)
	      (uri (string-append
		    "https://launchpad.net/dbus-test-runner/"
		    (version-major+minor version) "/" version
		    "/+download/dbus-test-runner-" version ".tar.gz"))
	      (sha256
	       (base32
		"0xnbay58xn0hav208mdsg8dd176w57dcpw1q2k0g5fh9v7xk4nk4"))))
    (build-system gnu-build-system)
    (arguments
     `(#:phases
       (modify-phases %standard-phases
    	 (add-before 'configure 'fix-test-paths
    	   ;; add missing space
    	   (lambda* (#:key outputs #:allow-other-keys)
	     (substitute* "Makefile.in"
    	       (("#!/bin/bash") (string-append "#!" (which "bash"))))
    	     (substitute* "tests/Makefile.in"
    	       (("/bin/sh") (which "sh"))
	       (("#!/bin/bash") (string-append "#!" (which "bash")))
	       (("echo cat") (string-append "echo " (which "cat")))
	       (("/bin/true") (which "true")))
    	     #t)))))
    (inputs
     `(("gtk+" ,gtk+)
       ("glib" ,glib)
       ("dbus-glib" ,dbus-glib)))
    (native-inputs
     `(("glib:bin" ,glib "bin")
       ("intltool" ,intltool)
       ("pkg-config" ,pkg-config)
       ;; following used for tests
       ("python" ,python)
       ("python-dbusmock" ,python-dbusmock)
       ("xvfb" ,xorg-server-for-tests)))
    (home-page "https://launchpad.net/dbus-test-runner")
    (synopsis "Run a executables under a new DBus session for testing")
    (description "A small little utility to run a couple of executables under a
new DBus session for testing.")
    (license license:gpl3)))

(define-public libindicator
  (package
    (name "libindicator")
    (version "12.10.1")
    (source (origin
	      (method url-fetch)
	      (uri (string-append
		    "https://launchpad.net/libindicator/"
		    (version-major+minor version) "/" version
		    "/+download/libindicator-" version ".tar.gz"))
	      (sha256
	       (base32
		"0zs4z7l9b57jldwz0ban77f3c2zq43ambd0dssf5qg9i216f9lmj"))))
    (build-system gnu-build-system)
    (arguments
     `(#:configure-flags '("CFLAGS=-Wno-error")
       #:phases
       (modify-phases %standard-phases
	 (add-before 'configure 'fix-libm
	   ;; add missing space
	   (lambda* (#:key outputs #:allow-other-keys)
	     (substitute* "configure"
	       (("LIBM=\"-lm\"") "LIBM=\" -lm\""))
	     #t))
	 (add-before 'configure 'fix-test-paths
	   (lambda* (#:key inputs #:allow-other-keys)
	     (substitute* "tests/Makefile.in"
	       (("/bin/sh") (which "sh"))
	       (("#!/bin/bash") (string-append "#!" (which "bash")))
	       (("/usr/share")
		(string-append (assoc-ref inputs "dbus-test-runner") "/share")))
	     #t)))))
    (inputs
     `(("gtk+" ,gtk+)
       ("glib" ,glib)
       ("python" ,python)))
    (native-inputs
     `(("pkg-config" ,pkg-config)
       ("dbus-test-runner" ,dbus-test-runner)
       ("glib:bin" ,glib "bin")
       ("xvfb" ,xorg-server-for-tests)))
    (home-page "https://launchpad.net/libindicator")
    (synopsis "Ayatana indicators symbols and functions")
    (description "A set of symbols and convenience functions for Ayatana indicators.")
    (license license:gpl3)))

(define-public libappindicator
  (package
    (name "libappindicator")
    (version "12.10.0")
    (source
     (origin
       (method url-fetch)
       (uri
	(string-append "https://launchpad.net/libappindicator/"
		       (version-major+minor version) "/" version
		       "/+download/libappindicator-" version ".tar.gz"))
       (sha256
	(base32
	 "17xlqd60v0zllrxp8bgq3k5a1jkj0svkqn8rzllcyjh8k0gpr46m"))))
    (build-system gnu-build-system)
    (arguments
     `(#:configure-flags
       `("CFLAGS=-Wno-error"
	 ;; FIXME: do not hardcode gtk version
	 "--with-gtk=3")
       #:phases
       (modify-phases %standard-phases
	 (delete 'check) 		;there's still one not passing It passes when it should fail 
	 (add-before 'configure 'fix-paths
	   (lambda* (#:key inputs #:allow-other-keys)
	     (substitute* "docs/reference/Makefile.in"
	       (("/bin/sh") (which "sh")))
	     (substitute* "tests/Makefile.in"
	       (("/bin/sh") (which "sh"))
	       (("#!/bin/bash") (string-append "#!" (which "bash")))
	       (("/usr") (string-append (assoc-ref inputs "dbus-test-runner"))))
	     (substitute* "bindings/python/Makefile.in"
	       (("-lappindicator") "-lappindicator3"))
	     #t))
	 (add-after 'unpack 'fix-codegen-path
	   (lambda* (#:key inputs #:allow-other-keys)
	     (substitute* "configure.ac"
	       (("codegendir pygtk-2.0`")
		;; pygobject` is not found. FIXME: This is a bad hack to 
		(string-append "codegendir pygobject`"
			       (assoc-ref inputs "python2-pygobject-2")
			       "/share/pygobject/2.0/codegen/")))
	     #t))
	 (add-after 'build 'build-bindings
	   (lambda _
	     (invoke "make" "-C" "bindings/python")
	     #t))
	 (add-after 'install 'install-bindings
	   (lambda _
	     (invoke "make" "-C" "bindings/python" "install")
	     #t)))))
    (inputs
     `(("dbus-glib" ,dbus-glib)
       ("gtk+" ,gtk+)
       ("libdbusmenu" ,libdbusmenu)
       ("libindicator" ,libindicator)
       ("python@2" ,python-2)
       ("python2-pygtk" ,python2-pygtk)
       ("python2-pygobject-2" ,python2-pygobject-2)
       ;; ("mono" ,mono) ; requires non-packaged gapi
       ("vala" ,vala)))
    (native-inputs
     `(("autoconf" ,autoconf)
       ("automake" ,automake)
       ("dbus-test-runner" ,dbus-test-runner)
       ("glib:bin" ,glib "bin")
       ("gobject-introspection" ,gobject-introspection)
       ("pkg-config" ,pkg-config)
       ("xvfb" ,xorg-server-for-tests)))
    (home-page "https://launchpad.net/libappindicator")
    (synopsis "Allow applications to export a menu into the Unity Menu bar.")
    (description "A library to allow applications to export a menu into the
Unity Menu bar.  Based on KSNI it also works in KDE and will fallback to generic
Systray support if none of those are available.")
    (license  license:lgpl2.1+)))

(define-public blueman
  (package
    (name "blueman")
    (version "2.1.2-git")
    (source
     (origin
       (method git-fetch)
       (uri (git-reference
	     (url "https://github.com/blueman-project/blueman")
	     ;; add meson
	     (commit "a0ab19f5bb6a9c4f290604960856b3f3949bcf1f")))
       (sha256
	(base32
	 "06nc2qxgk8p9q2sfggmi9x5d47mxz4bnl6yfpddj7b2afmai6902"))))
    (arguments
     `(#:phases
       (modify-phases %standard-phases
	 (add-after 'unpack 'fix-ldopen
	   (lambda* (#:key inputs #:allow-other-keys)
	     (substitute* "blueman/main/PulseAudioUtils.py"
	       (("CDLL\\(\"libpulse")
		(string-append "CDLL(\""
			       (assoc-ref inputs "pulseaudio") "/lib/libpulse"))
	       (("self.connect_rfcomm") "self.connect_pulseaudio"))
	     #t)
	   )
	 (add-after 'install 'wrap-programs
	   (lambda* (#:key outputs #:allow-other-keys)
	     (let* ((out  (assoc-ref outputs "out"))
		    (python-path (getenv "PYTHONPATH"))
		    (gi-path (getenv "GI_TYPELIB_PATH")))
	       (for-each (lambda (file)
			   (wrap-program (string-append out "/bin/" file)
			     `("PYTHONPATH" ":" prefix
			       (,python-path ,(string-append out
							     "/lib/python"
							     "3.7" ;FIXME
							     "/site-packages/"
							     )))
			     `("GI_TYPELIB_PATH" ":" prefix
			       (,gi-path))))
			 '("blueman-adapters"
			   "blueman-applet"
			   "blueman-assistant"
			   "blueman-manager"
			   "blueman-sendto"
			   "blueman-services"
			   "blueman-tray"))
	       (for-each (lambda (file)
			   (wrap-program (string-append out "/libexec/" file)
			     `("PYTHONPATH" ":" prefix
			       (,python-path ,(string-append out
							     "/lib/python"
							     "3.7" ;FIXME
							     "/site-packages/"
							     )))
			     `("GI_TYPELIB_PATH" ":" prefix
			       (,gi-path))))
			 '("blueman-mechanism" "blueman-rfcomm-watcher")))
	     #t)))))
    (inputs
     `(("bluez" ,bluez)
       ("libappindicator" ,libappindicator)
       ("python" ,python)
       ("python-pycairo" ,python-pycairo)
       ("python-pygobject" ,python-pygobject)
       ("gobject-introspection" ,gobject-introspection)
       ("pulseaudio" ,pulseaudio)
       ("gtk+" ,gtk+)))
    ;; gio-launch-desktop is required, but I can't find where it is called to
    ;; patch it directly
    (propagated-inputs `(("glib:bin" ,glib "bin")))
    (native-inputs `(("cmake" ,cmake)
		     ("pkg-config" ,pkg-config)
		     ("intltool" ,intltool)
		     ("python-cython" ,python-cython)))
    (build-system meson-build-system)
    (home-page "")
    (synopsis "")
    (description "")
    (license license:gpl2+)))

blueman

[-- Attachment #3: Type: text/plain, Size: 6428 bytes --]


Thanks, Nicolò


Pierre Neidhardt <mail@ambrevar.xyz> writes:

> * gnu/packages/freedesktop.scm (libappindicator): New variable.
> ---
>  gnu/packages/freedesktop.scm | 58 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 58 insertions(+)
>
> diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
> index d88c151df7..20e4024dfb 100644
> --- a/gnu/packages/freedesktop.scm
> +++ b/gnu/packages/freedesktop.scm
> @@ -1801,3 +1801,61 @@ useful with system integration.")
>      (description "A set of symbols and convience functions that all indicators
>  would like to use.  Originally from the Ayatana indicators project.")
>      (license license:gpl3+)))
> +
> +(define-public libappindicator
> +  (package
> +    (name "libappindicator")
> +    (version "12.10.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://launchpad.net/libappindicator/"
> +             (version-major+minor version) "/" version
> +             "/+download/libappindicator-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "17xlqd60v0zllrxp8bgq3k5a1jkj0svkqn8rzllcyjh8k0gpr46m"))))
> +    (build-system gnu-build-system)
> +    (native-inputs
> +     `(("glib:bin" ,glib "bin")
> +       ("gobject-introspection" ,gobject-introspection)
> +       ("pkg-config" ,pkg-config)))
> +    (inputs
> +     `(("gtk+" ,gtk+)
> +       ("dbus-glib" ,dbus-glib)
> +       ("python" ,python-2)
> +       ("python2-pygtk" ,python2-pygtk)
> +       ("python2-pygobject" ,python2-pygobject)
> +       ("libdbusmenu" ,libdbusmenu)
> +       ("libindicator" ,libindicator)))
> +    (arguments
> +     `(#:configure-flags '("--with-gtk=3")
> +       #:make-flags '("CFLAGS=-Wno-error=deprecated-declarations")
> +       #:tests? #f              ; FIXME: Require the dbus-test-runner package.
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'fix-codegen-path
> +           (lambda _
> +             (substitute* "configure"
> +               (("PYGTK_CODEGEN=.*") "PYGTK_CODEGEN=pygtk-codegen-2.0\n"))
> +             #t))
> +         (add-after 'unpack 'disable-fail-on-error
> +           (lambda _
> +             (substitute* "src/Makefile.in"
> +               (("-Werror") ""))
> +             #t))
> +         (add-after 'unpack 'fix-test
> +           (lambda _
> +             (substitute* "tests/Makefile.in"
> +               (("/bin/bash") (which "bash"))
> +               (("/bin/sh") (which "sh")))
> +             (substitute* "docs/reference/Makefile.in"
> +               (("/bin/sh") (which "sh")))
> +             #t)))))
> +    (home-page "https://launchpad.net/libappindicator")
> +    (synopsis "Library to export a menu into the system tray")
> +    (description "A library to allow applications to export a menu, originally
> +into the Unity menu bar.  Based on KSNI, it also works in KDE and will
> +fallback to generic system tray support if none of those are available.")
> +    (license license:gpl3+)))
> -- 
> 2.25.1
> From a82ab4f66aed111c07358a238de3fc1e369799c0 Mon Sep 17 00:00:00 2001
> From: Pierre Neidhardt <mail@ambrevar.xyz>
> Date: Thu, 7 May 2020 11:24:09 +0200
> Subject: [PATCH 2/2] gnu: Add libappindicator.
>
> * gnu/packages/freedesktop.scm (libappindicator): New variable.
> ---
>  gnu/packages/freedesktop.scm | 58 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 58 insertions(+)
>
> diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
> index d88c151df7..20e4024dfb 100644
> --- a/gnu/packages/freedesktop.scm
> +++ b/gnu/packages/freedesktop.scm
> @@ -1801,3 +1801,61 @@ useful with system integration.")
>      (description "A set of symbols and convience functions that all indicators
>  would like to use.  Originally from the Ayatana indicators project.")
>      (license license:gpl3+)))
> +
> +(define-public libappindicator
> +  (package
> +    (name "libappindicator")
> +    (version "12.10.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://launchpad.net/libappindicator/"
> +             (version-major+minor version) "/" version
> +             "/+download/libappindicator-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "17xlqd60v0zllrxp8bgq3k5a1jkj0svkqn8rzllcyjh8k0gpr46m"))))
> +    (build-system gnu-build-system)
> +    (native-inputs
> +     `(("glib:bin" ,glib "bin")
> +       ("gobject-introspection" ,gobject-introspection)
> +       ("pkg-config" ,pkg-config)))
> +    (inputs
> +     `(("gtk+" ,gtk+)
> +       ("dbus-glib" ,dbus-glib)
> +       ("python" ,python-2)
> +       ("python2-pygtk" ,python2-pygtk)
> +       ("python2-pygobject" ,python2-pygobject)
> +       ("libdbusmenu" ,libdbusmenu)
> +       ("libindicator" ,libindicator)))
> +    (arguments
> +     `(#:configure-flags '("--with-gtk=3")
> +       #:make-flags '("CFLAGS=-Wno-error=deprecated-declarations")
> +       #:tests? #f              ; FIXME: Require the dbus-test-runner package.
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'fix-codegen-path
> +           (lambda _
> +             (substitute* "configure"
> +               (("PYGTK_CODEGEN=.*") "PYGTK_CODEGEN=pygtk-codegen-2.0\n"))
> +             #t))
> +         (add-after 'unpack 'disable-fail-on-error
> +           (lambda _
> +             (substitute* "src/Makefile.in"
> +               (("-Werror") ""))
> +             #t))
> +         (add-after 'unpack 'fix-test
> +           (lambda _
> +             (substitute* "tests/Makefile.in"
> +               (("/bin/bash") (which "bash"))
> +               (("/bin/sh") (which "sh")))
> +             (substitute* "docs/reference/Makefile.in"
> +               (("/bin/sh") (which "sh")))
> +             #t)))))
> +    (home-page "https://launchpad.net/libappindicator")
> +    (synopsis "Library to export a menu into the system tray")
> +    (description "A library to allow applications to export a menu, originally
> +into the Unity menu bar.  Based on KSNI, it also works in KDE and will
> +fallback to generic system tray support if none of those are available.")
> +    (license license:gpl3+)))
> -- 
> 2.25.1

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [bug#41134] [PATCH 2/2] gnu: Add libappindicator.
  2020-05-11 11:46     ` Nicolò Balzarotti
@ 2020-05-11 12:14       ` Pierre Neidhardt
  2020-05-11 14:18         ` Raghav Gururajan
  0 siblings, 1 reply; 9+ messages in thread
From: Pierre Neidhardt @ 2020-05-11 12:14 UTC (permalink / raw)
  To: Nicolò Balzarotti, 41134; +Cc: Raghav Gururajan

[-- Attachment #1: Type: text/plain, Size: 195 bytes --]

Thanks!

Actually you've got blueman here to, as in 41025@debbugs.gnu.org.
Raghav, Nicolò, what do you think?  Which is one is more complete?

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [bug#41134] [PATCH 2/2] gnu: Add libappindicator.
  2020-05-11 12:14       ` Pierre Neidhardt
@ 2020-05-11 14:18         ` Raghav Gururajan
  2020-05-11 15:07           ` Nicolò Balzarotti
  0 siblings, 1 reply; 9+ messages in thread
From: Raghav Gururajan @ 2020-05-11 14:18 UTC (permalink / raw)
  To: Pierre Neidhardt, Nicolò Balzarotti, 41134


[-- Attachment #1.1.1: Type: text/plain, Size: 489 bytes --]

Hi Pierre!

> Actually you've got blueman here to, as in 41025@debbugs.gnu.org.
> Raghav, Nicolò, what do you think?  Which is one is more complete?

Pierre:
I'd say, let us go with dbus-test-runner from Nicolò's 4113#4;
libindicator+libappindicator from yours' 41143#0 and 4113#1; blueman
from my 41025#14.
So if you could update libindicator and libappindicator, by using
dbus-test-runner; I can update blueman to integrate them. Wdyt?

Nicolò:
Wdyt?

Regards,
RG.


[-- Attachment #1.1.2: 0xAE6EF3046D6F7B57.asc --]
[-- Type: application/pgp-keys, Size: 2877 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [bug#41134] [PATCH 2/2] gnu: Add libappindicator.
  2020-05-11 14:18         ` Raghav Gururajan
@ 2020-05-11 15:07           ` Nicolò Balzarotti
  2020-05-11 15:10             ` Raghav Gururajan
  0 siblings, 1 reply; 9+ messages in thread
From: Nicolò Balzarotti @ 2020-05-11 15:07 UTC (permalink / raw)
  To: Raghav Gururajan, Pierre Neidhardt, 41134

Raghav Gururajan <raghavgururajan@disroot.org> writes:

> Hi Pierre!
>
>> Actually you've got blueman here to, as in 41025@debbugs.gnu.org.
>> Raghav, Nicolò, what do you think?  Which is one is more complete?
>
> Pierre:
> I'd say, let us go with dbus-test-runner from Nicolò's 4113#4;
> libindicator+libappindicator from yours' 41143#0 and 4113#1; blueman
> from my 41025#14.
> So if you could update libindicator and libappindicator, by using
> dbus-test-runner; I can update blueman to integrate them. Wdyt?
>
> Nicolò:
> Wdyt?
>
Fine! But remember to also apply the this libpulse patch, as current
blueman fails to find pulseaudio

(substitute* "blueman/main/PulseAudioUtils.py"
       (("CDLL\\(\"libpulse")
	(string-append "CDLL(\""
		       (assoc-ref inputs "pulseaudio") "/lib/libpulse")))

> Regards,
> RG.
>
Thanks!

> -----BEGIN PGP PUBLIC KEY BLOCK-----
>
> mQENBF6yxWcBCAClEApjrOYs8fSzDl8GBwMFtUzF6VCOVrWaGun1vvPDvk4AFzbB
> 3ZV6+Jn8VfEuqh3OOvSJGHL2cJoR28Q5gVqeOwupyaMWVdEt6TmDrHISyxriF426
> KVaJnklfMjYwIi0l/7j8bs3pDRyyR6uFrY6sYL9t6HFvevtt7NwgWL1MAEVy6txK
> kriyrK1h+qc13wRRgVx3tzl7dNwYEDWd3yUDn+LESoDOlawJ7TQbO8d1K4FFHaqw
> yQ/SyaIfLBnMAz9Qd18MUWpDkktLh/9ujRfctouFx5BUr+uGgCHAWcII5D60lt86
> 7y5m6vp3Ua75TkVQrYTt7KSF/wm7NZ7L02fTABEBAAG0NFJhZ2hhdiBHdXJ1cmFq
> YW4gKFJHKSA8cmdAbWFpbC5yYWdoYXZndXJ1cmFqYW4ubmFtZT6JAVEEEwEIADsC
> GwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AWIQQnQS80qpGN6kDSlCiubvMEbW97
> VwUCXrXjmQIZAQAKCRCubvMEbW97V32uCACYYyZoxs+lNb53hEB663VkZdF84C0j
> 0rCaUn0IKQSIy3fmHjFR1gmx5wXwWfOOtu7kjBgxGU/zWB1Nd3yTS+yZikd5IvF6
> mwXfXTrgtS4TPZy0t+bbrALYFyw9mBJbbyCfOgRB4/mMB+PGJk0pTqYIFwMtzFP/
> YSKWhVs+O2K2mPBZQninW0R9NGzbH1tDG5jABndtrvsQQhQN4iLkFl7x0NcaVUEO
> miBwprhk9S4rHjXdmafIxoy/nBhDgFNUuoxEwVrGSCmOT6J83gMfFyk96kGgG3Bq
> nPVuMX8C8AJRwpRXvRYkHX6tGyJEyIZJT48A0pE6yguIJf67fH+5nKcPtDNSYWdo
> YXYgR3VydXJhamFuIChSRykgPHJhZ2hhdmd1cnVyYWphbkBkaXNyb290Lm9yZz6J
> AU4EEwEIADgWIQQnQS80qpGN6kDSlCiubvMEbW97VwUCXrXj2wIbAwULCQgHAgYV
> CgkICwIEFgIDAQIeAQIXgAAKCRCubvMEbW97V71iB/9zYsGiX3KzqDv6+P63hND5
> n4FVkaVj/LoXcmYrgZnJ8pbcUpsWdXa5VqZ22qeT+7LFciJWOkqy0wHje0dEu9Bw
> CDZJ+17yqVmox0oV9DEeGzXqoxEzWYO4Idj04Os3052A9VEKnTcZzzIiU0gWQSwg
> Jvy4XRLooLeefbqAwPWRFS0ecnCofp8veDS1IZrkV6R/7G+hMtBSpnTHOOyjZ5Bk
> GsknhmPPEcDjYH79/664jWzidbddndqrKpIjqM57sYOTt50+qG3e4QrqvhGMI88E
> la1GbjHpTt9lBOHdonj4YjwX4qa1QjQxjxc7SU3tGPjkAGo49twgYBiGqfy9QqWd
> tDNSYWdoYXYgR3VydXJhamFuIChSRykgPHJhZ2hhdmd1cnVyYWphbkBzbm9weXRh
> Lm9yZz6JAU4EEwEIADgWIQQnQS80qpGN6kDSlCiubvMEbW97VwUCXrXj9wIbAwUL
> CQgHAgYVCgkICwIEFgIDAQIeAQIXgAAKCRCubvMEbW97V8mkB/98Jnh8OkkjRt8h
> 2x8vOynRzcx94pXDiSwHxRlCLSYaZ49NpGOSOqFyxPihxNUGfiq6B1WZnrKCsu78
> KZdTPScN1NqJCqwdm7RoV8yuS43G168nSvF3yT6RDssxbHSxCxDOqd+rQiqoXGuq
> gdOTfvYjg13b9wBSsoMkVjylmzP8x9BI9G0SuxG9X0Rqb7c6+my5aLTKiJek8c7P
> QTg7PzdYOBB+QGuhmDcfXfCer0xa5dPvZ3VEjjyIN/9bd8laVoK6c2jGea7gBo57
> hu/TTPi3hueGHtWoStGb7dPJKtY2Xrz2dv44bGLuLHaygHdr2YcHUTX8NC9383+y
> PAKxcKKouQENBF6yxWcBCADRjE1WgIkhraQG8UaPQBznNpIGrZALB/3o7czR9JrR
> sLRNIORodDikyOu/CiLWp87ZrpCnGZgZ4DwsL1BhjUGM1lsLEvpAbYucCdzhaK4P
> ibWLn/5/Q40gIZ2+4daYi/V4tHa1C5eaL1RUafyD5XZG090fKYHPVcAGtFVUT+fX
> bIBepz4aB48Xwaf13ANkEZ0XwdmzeAVQlWpSXpTxmEdKUsJH7RaZoWuBUWtC6ybX
> DHofjxttGrD4inBOLDRmU5h95Hh5E35OU7nbN5cub5aphCoO6mP86EtclkCY9I9+
> iaF9f62r6PoFMbM4oPNNeNGuWxdlVBES3CjvgqdJSOP/ABEBAAGJATYEGAEIACAW
> IQQnQS80qpGN6kDSlCiubvMEbW97VwUCXrLFZwIbDAAKCRCubvMEbW97V6kyB/wP
> c+9BywmXAH56Zbho+AD34t4WqnVO8b7a5DfXhyaD1e6cMctZbjUUfMYO2B5MHEP/
> ahHL0onDSL4Y0cOXEqclvRxpjhcome/ii391z1Iwu6QuaSDPgAFssg+RpcqmpB9c
> AXvEQvf/Lzcn2Z5m1eD1Lx6B72P8WR/g/wH4NSdooHSHm5EM84RQQuuUwChXjDSF
> kJGCDCo6uLvp5r97K3qr0b5bfFWKtFUqtuEhbNCSfnRJrjt/7O9tdtiSC9FxFEt6
> KBm/6eu/ETNjqXpS2XGUjxuryCK0BSsOvzVYw7TmNw6zT7UPofOFJxT1LWmcr0EM
> KRjY77Tc1P2JvjcLBZtE
> =cLME
> -----END PGP PUBLIC KEY BLOCK-----




^ permalink raw reply	[flat|nested] 9+ messages in thread

* [bug#41134] [PATCH 2/2] gnu: Add libappindicator.
  2020-05-11 15:07           ` Nicolò Balzarotti
@ 2020-05-11 15:10             ` Raghav Gururajan
  2020-05-14 17:14               ` Pierre Neidhardt
  0 siblings, 1 reply; 9+ messages in thread
From: Raghav Gururajan @ 2020-05-11 15:10 UTC (permalink / raw)
  To: Nicolò Balzarotti, Pierre Neidhardt, 41134


[-- Attachment #1.1: Type: text/plain, Size: 874 bytes --]

Hi Pierre!

>>> Actually you've got blueman here to, as in 41025@debbugs.gnu.org.
>>> Raghav, Nicolò, what do you think?  Which is one is more complete?
>>
>> Pierre:
>> I'd say, let us go with dbus-test-runner from Nicolò's 4113#4;
>> libindicator+libappindicator from yours' 41143#0 and 4113#1; blueman
>> from my 41025#14.
>> So if you could update libindicator and libappindicator, by using
>> dbus-test-runner; I can update blueman to integrate them. Wdyt?
>>
>> Nicolò:
>> Wdyt?
>>
> Fine! But remember to also apply the this libpulse patch, as current
> blueman fails to find pulseaudio
> 
> (substitute* "blueman/main/PulseAudioUtils.py"
>        (("CDLL\\(\"libpulse")
> 	(string-append "CDLL(\""
> 		       (assoc-ref inputs "pulseaudio") "/lib/libpulse")))
> 

It have already fixed libpulse issue in #41025#14. :-)

Regards,
RG.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [bug#41134] [PATCH 2/2] gnu: Add libappindicator.
  2020-05-11 15:10             ` Raghav Gururajan
@ 2020-05-14 17:14               ` Pierre Neidhardt
  0 siblings, 0 replies; 9+ messages in thread
From: Pierre Neidhardt @ 2020-05-14 17:14 UTC (permalink / raw)
  To: Raghav Gururajan, Nicolò Balzarotti, 41134

[-- Attachment #1: Type: text/plain, Size: 295 bytes --]

I've pushed Nicolò's packages with minor changes:

- dbus-test-runner: 522b1148d1e78cd78a962e8046b3ed6ab34de8fa,
- libindicator: 5e2750fb9e3511b38a0b681e42fc4f528121a9d5
- libappindicator: c7b777130f31d313355562697d4f56480a93f477

Thanks!

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [bug#41134] LibAppIndicator
  2020-05-08  6:34 [bug#41134] [PATCH 1/2] gnu: Add libindicator Pierre Neidhardt
       [not found] ` <handler.41134.B.158891966521951.ack@debbugs.gnu.org>
@ 2020-05-11 11:38 ` Raghav Gururajan
  1 sibling, 0 replies; 9+ messages in thread
From: Raghav Gururajan @ 2020-05-11 11:38 UTC (permalink / raw)
  To: 41134

Hi Pierre!

Great job! Nice to have these for Blueman.

I tried packaging them while I was packaging blueman, but gave up as I got too many errors.

Regards,
RG.




^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2020-05-14 17:15 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-08  6:34 [bug#41134] [PATCH 1/2] gnu: Add libindicator Pierre Neidhardt
     [not found] ` <handler.41134.B.158891966521951.ack@debbugs.gnu.org>
2020-05-08  6:42   ` [bug#41134] [PATCH 2/2] gnu: Add libappindicator Pierre Neidhardt
2020-05-11 11:46     ` Nicolò Balzarotti
2020-05-11 12:14       ` Pierre Neidhardt
2020-05-11 14:18         ` Raghav Gururajan
2020-05-11 15:07           ` Nicolò Balzarotti
2020-05-11 15:10             ` Raghav Gururajan
2020-05-14 17:14               ` Pierre Neidhardt
2020-05-11 11:38 ` [bug#41134] LibAppIndicator Raghav Gururajan

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).