unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Jonathan <rostranjj@gmail.com>
Cc: 45011@debbugs.gnu.org
Subject: [bug#45011] [PATCH] add emacs-project and dependency
Date: Fri, 04 Dec 2020 21:12:47 +0100	[thread overview]
Message-ID: <87lfedpby8.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CANwJfzj4HgpE0nWHTvfNAiooDjF-wBH37d8FziPKgWVwos_K9w@mail.gmail.com> (Jonathan's message of "Wed, 2 Dec 2020 10:29:48 -0600")

Hello,

Jonathan <rostranjj@gmail.com> writes:

>  gnu/packages/emacs-xyz.scm | 61 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 61 insertions(+)

Thank you!

Could you write a commit message to introduce your changes? You can look
at those starting with "Add ..." in the code base.

Also, could you split it into two patches, one for each package?

> +  (synopsis "Operations on the current project")
> +  (description
> +   "NOTE: The project API is still experimental and can change in major,
> +backward-incompatible ways.  Everyone is encouraged to try it, and
> +report to us any problems or use cases we hadn't anticipated, by
> +sending an email to emacs-devel, or `M-x report-emacs-bug'.
> +
> +This file contains generic infrastructure for dealing with
> +projects, some utility functions, and commands using that
> +infrastructure.")

The synopsis could be clarified, so could the description. In
particular, the latter explains what the library is about.

> +  (description
> +    "NOTE: The xref API is still experimental and can change in major,
> +backward-incompatible ways.  Everyone is encouraged to try it, and
> +report to us any problems or use cases we hadn't anticipated, by
> +sending an email to emacs-devel, or `M-x report-emacs-bug'.
> +
> +This file provides a somewhat generic infrastructure for cross
> +referencing commands, in particular \"find-definition\".
> +
> +See the etags and elisp-mode implementations for full examples.")

Ditto.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou




  reply	other threads:[~2020-12-04 21:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-02 16:29 [bug#45011] [PATCH] add emacs-project and dependency Jonathan
2020-12-04 20:12 ` Nicolas Goaziou [this message]
2020-12-05 18:18   ` Jonathan
2020-12-06 14:53     ` Nicolas Goaziou
2020-12-06 19:22       ` Jonathan
2020-12-06 20:36         ` Nicolas Goaziou
2020-12-06 23:55           ` Jonathan
2020-12-08  7:26             ` Nicolas Goaziou
2020-12-08 17:31               ` Jonathan
2020-12-08 17:34                 ` Jonathan
2020-12-16 16:53                   ` Jonathan
2020-12-16 17:33                     ` bug#45011: " Nicolas Goaziou
2020-12-05 19:41   ` [bug#45011] " Jonathan
2020-12-05 19:42   ` Jonathan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lfedpby8.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=45011@debbugs.gnu.org \
    --cc=rostranjj@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).