unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Jonathan <rostranjj@gmail.com>
Cc: 45011@debbugs.gnu.org
Subject: [bug#45011] [PATCH] add emacs-project and dependency
Date: Sun, 06 Dec 2020 15:53:12 +0100	[thread overview]
Message-ID: <874kkz0yw7.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CANwJfzg_WV_YRbP3A1A-y4ai1f1J8LeaN_qzKzo9jP9zYBC-BA@mail.gmail.com> (Jonathan's message of "Sat, 5 Dec 2020 12:18:29 -0600")

Hello,

Jonathan <rostranjj@gmail.com> writes:

> The descriptions are the ones found in their project's homepage.

Well, sometimes, even upstream descriptions need to be reworded.

> I can't think of a better synopsis for Project since it provides
> several functions to operate on a project directory... Do you have
> a suggestion?.

Unfortunately, no. My concern is that I don't know what this package is
about, and the synopsis doesn't help me finding it out. Maybe the term
"project" is too vague.

Note that the synopsis must fit on a single line, and is not a full
sentence. You may want to run "guix lint" on your package definition.

Also, I suggest to remove the big note at the beginning of each
description. It may make sense as a foreword in a project home page, but
I don't think it does when describing the software.

> Which patch do you want first? emacs-xref is needed for emacs-project. Do
> you want me to send emacs-xref first?

Sure.

I see you send new patches. Could you integrate the suggestion above,
and include a proper commit message, like the following:

    gnu: Add emacs-xref.

    * gnu/packages/emacs-xyz.scm (emacs-xref): New variable.

?

Thanks!

Regards,
-- 
Nicolas Goaziou




  reply	other threads:[~2020-12-06 14:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-02 16:29 [bug#45011] [PATCH] add emacs-project and dependency Jonathan
2020-12-04 20:12 ` Nicolas Goaziou
2020-12-05 18:18   ` Jonathan
2020-12-06 14:53     ` Nicolas Goaziou [this message]
2020-12-06 19:22       ` Jonathan
2020-12-06 20:36         ` Nicolas Goaziou
2020-12-06 23:55           ` Jonathan
2020-12-08  7:26             ` Nicolas Goaziou
2020-12-08 17:31               ` Jonathan
2020-12-08 17:34                 ` Jonathan
2020-12-16 16:53                   ` Jonathan
2020-12-16 17:33                     ` bug#45011: " Nicolas Goaziou
2020-12-05 19:41   ` [bug#45011] " Jonathan
2020-12-05 19:42   ` Jonathan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874kkz0yw7.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=45011@debbugs.gnu.org \
    --cc=rostranjj@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).