From: "Ludovic Courtès" <ludo@gnu.org>
To: Xinglu Chen <public@yoctocell.xyz>
Cc: 47670@debbugs.gnu.org
Subject: [bug#47670] [PATCH 0/2] Add updater for packages hosted as SourceHut Git repositories
Date: Tue, 27 Jul 2021 12:19:46 +0200 [thread overview]
Message-ID: <87lf5s3vp9.fsf@gnu.org> (raw)
In-Reply-To: <87lf7gbvmx.fsf@yoctocell.xyz> (Xinglu Chen's message of "Fri, 11 Jun 2021 11:25:42 +0200")
Hi,
Replying to an old message…
Xinglu Chen <public@yoctocell.xyz> skribis:
> On Sun, Jun 06 2021, Ludovic Courtès wrote:
[...]
>>> Umm, the 'upstream-source-compiler' uses 'url-fetch' to fetch the url, I
>>> guess we would have to make it support Git repositories first.
>>
>> Yes, that’s a limitation of (guix upstream) right now.
>> ‘%method-updates’ was a first step in the direction of supporting Git
>> repos.
>
> One of the problems with adding support for Git repos in (guix upstream)
> was that Libgit2 (and by extension Guile-Git) doesn’t provide an API for
> verifying tags, the I only way I know of is to run ‘git verify-tag’ in
> the shell. There is a ‘git_commit_extract_signature’ API, but it only
> for individual commits, and since the majority of people don’t sign
> their commits it means that a most of the time its not going to be able
> to verify the checkout.
The (guix git-authenticate) commit has code that retrieves the OpenPGP
signature and checks it. It can serve as inspiration.
>> Now, I agree with Léo that (1) this is not SourceHut-specific, and (2)
>> it should not download generated archives.
>>
>> Also, I’d prefer to have the code rely on Guile-Git to list tags rather
>> than invoking ‘git’, if possible.
>
> Libgit2 has a ‘git_tag_list’ API, though it doesn’t seem like Guile-Git
> supports it.
>
> https://libgit2.org/libgit2/#HEAD/group/tag/git_tag_list
Ah, we could add it.
>> Perhaps that code could leave in its own (guix import git) module or
>> similar, rather than in (guix gnu-maintenance), which already has
>> little to do with GNU maintenance at this point. :-)
>
> Yeah, I think that’s a good idea :)
Thanks,
Ludo’.
prev parent reply other threads:[~2021-07-27 10:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 9:02 [bug#47670] [PATCH 0/2] Add updater for packages hosted as SourceHut Git repositories Xinglu Chen
2021-04-09 9:05 ` [bug#47670] [PATCH 1/2] upstream: Add predicate for Git URLs Xinglu Chen
2021-04-09 9:05 ` [bug#47670] [PATCH 2/2] gnu-maintenance: Add 'sourcehut-git' updater Xinglu Chen
2021-04-09 10:54 ` [bug#47670] [PATCH 0/2] Add updater for packages hosted as SourceHut Git repositories Léo Le Bouter via Guix-patches via
2021-04-09 11:58 ` Xinglu Chen
2021-04-09 12:04 ` Léo Le Bouter via Guix-patches via
2021-04-09 12:41 ` Xinglu Chen
2021-04-09 12:48 ` Xinglu Chen
2021-06-06 13:23 ` Ludovic Courtès
2021-06-11 9:25 ` Xinglu Chen
2021-07-27 10:19 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lf5s3vp9.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=47670@debbugs.gnu.org \
--cc=public@yoctocell.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).