From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id +NJfKtfd/2AQegEAgWs5BA (envelope-from ) for ; Tue, 27 Jul 2021 12:20:07 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id EAvxJdfd/2CLKwAAbx9fmQ (envelope-from ) for ; Tue, 27 Jul 2021 10:20:07 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5D671CA7D for ; Tue, 27 Jul 2021 12:20:07 +0200 (CEST) Received: from localhost ([::1]:56876 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m8KBy-00059g-BE for larch@yhetil.org; Tue, 27 Jul 2021 06:20:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45838) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m8KBu-00059X-S7 for guix-patches@gnu.org; Tue, 27 Jul 2021 06:20:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41051) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m8KBu-0002Tr-KL for guix-patches@gnu.org; Tue, 27 Jul 2021 06:20:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m8KBu-0004nE-Gs for guix-patches@gnu.org; Tue, 27 Jul 2021 06:20:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47670] [PATCH 0/2] Add updater for packages hosted as SourceHut Git repositories Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 27 Jul 2021 10:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47670 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Xinglu Chen Cc: 47670@debbugs.gnu.org Received: via spool by 47670-submit@debbugs.gnu.org id=B47670.162738119518404 (code B ref 47670); Tue, 27 Jul 2021 10:20:02 +0000 Received: (at 47670) by debbugs.gnu.org; 27 Jul 2021 10:19:55 +0000 Received: from localhost ([127.0.0.1]:52597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m8KBm-0004mm-Uo for submit@debbugs.gnu.org; Tue, 27 Jul 2021 06:19:55 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48022) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m8KBl-0004mY-OL for 47670@debbugs.gnu.org; Tue, 27 Jul 2021 06:19:54 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42988) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m8KBf-0002LS-Ps; Tue, 27 Jul 2021 06:19:47 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=42970 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m8KBf-0003RM-Hy; Tue, 27 Jul 2021 06:19:47 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <6b8ddedae2addf01efa57dcf3a6723bed81bf076.camel@zaclys.net> <87im4vwtyd.fsf@yoctocell.xyz> <2513bc7a1e52872be1cd1b8ecde11e21a6f613e0.camel@zaclys.net> <87fszzwryv.fsf@yoctocell.xyz> <87czv3wrnj.fsf@yoctocell.xyz> <87zgw3jfed.fsf_-_@gnu.org> <87lf7gbvmx.fsf@yoctocell.xyz> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 9 Thermidor an 229 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 27 Jul 2021 12:19:46 +0200 In-Reply-To: <87lf7gbvmx.fsf@yoctocell.xyz> (Xinglu Chen's message of "Fri, 11 Jun 2021 11:25:42 +0200") Message-ID: <87lf5s3vp9.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1627381207; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=iU01JisRmkQEZp/eUItX5th9SoFYD2opYUwfk/aryTI=; b=IgqOYN/Ya9K0yTvZuvKWl+R0ItiEN+KuTZ9MGNES49S5SXlDLswuBq/+Kg9tzz421E8MtL jUM78Qq90S5FxlqlboOeHcEo4jfZ5H2PrxrQjFLe1J0AQz0dXkuBCM+6qut7wZ2IOx/QSn LILl57VAa2T9vDsrOnDKGxw/ipLShwt9/NWPv7AwaNSm4i6zyg1yhBPVwPaBwjY62ZT5Az Z98JZeBgEFCWY8lUdwfziSWwBXT1ui/6abpVLG9ysErQ9IvVAurA0HMad6XktFp/BDML49 anfZw3O8xVA3zjLJ/YQlw0ZQuBGaLpIopD5K6OhQlrrrQ/iHKJMk0y8NRS9ESg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1627381207; a=rsa-sha256; cv=none; b=eHOwCI9SydTWfEHwHbUqhtvrKNQP2Bn3qwA+hM4c85gMqUfzxNZIuCppkzCWFhOBhzvhIm 6QchEPE6GDkSxZUA8YnCobCvrm55sYIhY2l/HYk7NbXcCiVeklK9WMR4lOu3IKPOoUkvbz +yY8091oqJ/bL+5zsUreiP0pR/T4MUEXTaCH4iIgPhI0I4DwDxv6v1sH1TMU0Zfbl3j0ns Gh22fGFNr5PPnVlPaT+rhWU98i/EX/fAsXlbaQPpltF2a9MaLlyrXYGNmZjsIdljIq6HL4 2kD5D2Y/leKjkTsfwkaEyUhNFQcf5kr4n76DHPxWOYjytALG2qiIT2sxAqCyGA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.92 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 5D671CA7D X-Spam-Score: -2.92 X-Migadu-Scanner: scn0.migadu.com X-TUID: R9v2umrr3U/X Hi, Replying to an old message=E2=80=A6 Xinglu Chen skribis: > On Sun, Jun 06 2021, Ludovic Court=C3=A8s wrote: [...] >>> Umm, the 'upstream-source-compiler' uses 'url-fetch' to fetch the url, I >>> guess we would have to make it support Git repositories first. >> >> Yes, that=E2=80=99s a limitation of (guix upstream) right now. >> =E2=80=98%method-updates=E2=80=99 was a first step in the direction of s= upporting Git >> repos. > > One of the problems with adding support for Git repos in (guix upstream) > was that Libgit2 (and by extension Guile-Git) doesn=E2=80=99t provide an = API for > verifying tags, the I only way I know of is to run =E2=80=98git verify-ta= g=E2=80=99 in > the shell. There is a =E2=80=98git_commit_extract_signature=E2=80=99 API= , but it only > for individual commits, and since the majority of people don=E2=80=99t si= gn > their commits it means that a most of the time its not going to be able > to verify the checkout. The (guix git-authenticate) commit has code that retrieves the OpenPGP signature and checks it. It can serve as inspiration. >> Now, I agree with L=C3=A9o that (1) this is not SourceHut-specific, and = (2) >> it should not download generated archives. >> >> Also, I=E2=80=99d prefer to have the code rely on Guile-Git to list tags= rather >> than invoking =E2=80=98git=E2=80=99, if possible. > > Libgit2 has a =E2=80=98git_tag_list=E2=80=99 API, though it doesn=E2=80= =99t seem like Guile-Git > supports it. > > https://libgit2.org/libgit2/#HEAD/group/tag/git_tag_list Ah, we could add it. >> Perhaps that code could leave in its own (guix import git) module or >> similar, rather than in (guix gnu-maintenance), which already has >> little to do with GNU maintenance at this point. :-) > > Yeah, I think that=E2=80=99s a good idea :) Thanks, Ludo=E2=80=99.