* [bug#51479] [PATCH 0/1] gnu: ta-lib: Explicitly link math library
@ 2021-10-29 11:04 Foo Chuan Wei
2021-10-29 11:06 ` [bug#51479] [PATCH 1/1] " Foo Chuan Wei
0 siblings, 1 reply; 3+ messages in thread
From: Foo Chuan Wei @ 2021-10-29 11:04 UTC (permalink / raw)
To: 51479
The math library has to be linked with ta-lib. Otherwise, errors may
occur. For example: https://github.com/rivella50/talib-ruby/issues/6
The fix here was copied from the patch used by Arch Linux and Gentoo.
https://gitweb.gentoo.org/repo/gentoo.git/tree/sci-libs/ta-lib/files/ta-lib-0.4.0-asneeded.patch
Foo Chuan Wei (1):
gnu: ta-lib: Explicitly link math library
gnu/packages/finance.scm | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
base-commit: ad39268cdf075f4c4eeb87ed78ce46ca6f817675
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [bug#51479] [PATCH 1/1] gnu: ta-lib: Explicitly link math library
2021-10-29 11:04 [bug#51479] [PATCH 0/1] gnu: ta-lib: Explicitly link math library Foo Chuan Wei
@ 2021-10-29 11:06 ` Foo Chuan Wei
2021-10-30 12:46 ` bug#51479: " Guillaume Le Vaillant
0 siblings, 1 reply; 3+ messages in thread
From: Foo Chuan Wei @ 2021-10-29 11:06 UTC (permalink / raw)
To: 51479
* gnu/packages/finance.scm (ta-lib): Explicitly link math library.
---
gnu/packages/finance.scm | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
index f0093ba635..f662b5b774 100644
--- a/gnu/packages/finance.scm
+++ b/gnu/packages/finance.scm
@@ -1768,7 +1768,17 @@ editing on the Web.")
(base32 "0lf69nna0aahwpgd9m9yjzbv2fbfn081djfznssa84f0n7y1xx4z"))))
(build-system gnu-build-system)
(arguments
- `(;; Parallel build fails with:
+ `(#:phases
+ (modify-phases %standard-phases
+ (add-after 'unpack 'edit-makefile-to-link-math-library
+ (lambda _
+ (substitute* "src/Makefile.am"
+ (("ta_common/libta_common.la")
+ "ta_common/libta_common.la -lm"))
+ (substitute* "src/Makefile.in"
+ (("\\$\\(libta_lib_la_LDFLAGS\\) \\$\\(LDFLAGS\\) -o \\$@")
+ "$(libta_lib_la_LDFLAGS) $(LDFLAGS) -lm -o $@")))))
+ ;; Parallel build fails with:
;; mv -f .deps/gen_code-gen_code.Tpo .deps/gen_code-gen_code.Po
;; mv: cannot stat '.deps/gen_code-gen_code.Tpo': No such file or directory
;; Makefile:254: recipe for target 'gen_code-gen_code.o' failed
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* bug#51479: [PATCH 1/1] gnu: ta-lib: Explicitly link math library
2021-10-29 11:06 ` [bug#51479] [PATCH 1/1] " Foo Chuan Wei
@ 2021-10-30 12:46 ` Guillaume Le Vaillant
0 siblings, 0 replies; 3+ messages in thread
From: Guillaume Le Vaillant @ 2021-10-30 12:46 UTC (permalink / raw)
To: Foo Chuan Wei; +Cc: 51479-done
[-- Attachment #1: Type: text/plain, Size: 106 bytes --]
Patch pushed as d4449565ed90aabaa6b755dfe1786a1dce370707 with a slightly
modified commit message.
Thanks.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-30 12:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-29 11:04 [bug#51479] [PATCH 0/1] gnu: ta-lib: Explicitly link math library Foo Chuan Wei
2021-10-29 11:06 ` [bug#51479] [PATCH 1/1] " Foo Chuan Wei
2021-10-30 12:46 ` bug#51479: " Guillaume Le Vaillant
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).