unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#60563] [PATCH 1/1] gnu: nettle: Fix mingw cross-compilation.
  2023-01-04 23:36 [bug#60563] [PATCH 0/1] Fix mingw cross-compilation of nettle Vivien Kraus via Guix-patches via
@ 2023-01-04 23:04 ` Vivien Kraus via Guix-patches via
  2023-01-19 16:31   ` bug#60563: [PATCH 0/1] Fix mingw cross-compilation of nettle Ludovic Courtès
  0 siblings, 1 reply; 3+ messages in thread
From: Vivien Kraus via Guix-patches via @ 2023-01-04 23:04 UTC (permalink / raw)
  To: 60563

* gnu/packages/nettle.scm (nettle-2) [move-static-libraries]: .dll.a files are
not static libraries.
---
 gnu/packages/nettle.scm | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/nettle.scm b/gnu/packages/nettle.scm
index 27bd9efc60..ea26ba3b2d 100644
--- a/gnu/packages/nettle.scm
+++ b/gnu/packages/nettle.scm
@@ -44,7 +44,7 @@ (define-public nettle-2
     (arguments
      ;; 'sexp-conv' and other programs need to have their RUNPATH point to
      ;; $libdir, which is not the case by default.  Work around it.
-     '(#:configure-flags (list (string-append "LDFLAGS=-Wl,-rpath="
+     `(#:configure-flags (list (string-append "LDFLAGS=-Wl,-rpath="
                                               (assoc-ref %outputs "out")
                                               "/lib"))
        #:phases (modify-phases %standard-phases
@@ -59,7 +59,13 @@ (define-public nettle-2
                                       (rename-file ar (string-append
                                                        slib "/"
                                                        (basename ar))))
-                                    (find-files "." "\\.a$")))
+                                    (find-files
+                                     "."
+                                     ,(if (target-mingw?)
+                                          '(lambda (filename _)
+                                             (and (string-suffix? ".a" filename)
+                                                  (not (string-suffix? ".dll.a" filename))))
+                                          "\\.a$"))))
                         #t))))))
     (outputs '("out" "debug" "static"))
     (native-inputs (list m4))
-- 
2.38.1




^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#60563] [PATCH 0/1] Fix mingw cross-compilation of nettle
@ 2023-01-04 23:36 Vivien Kraus via Guix-patches via
  2023-01-04 23:04 ` [bug#60563] [PATCH 1/1] gnu: nettle: Fix mingw cross-compilation Vivien Kraus via Guix-patches via
  0 siblings, 1 reply; 3+ messages in thread
From: Vivien Kraus via Guix-patches via @ 2023-01-04 23:36 UTC (permalink / raw)
  To: 60563

Dear guix,

nettle separates its static library output from its main output by moving all
files with a ".a" extension. However, doing that also moves the ".dll.a" files
on mingw. These files are required to link against a DLL. Packages that want
to link against the nettle DLL will require the default output of nettle, and
will not want the static output. So, these files must stay in the default
output.

Best regards,

Vivien

Vivien Kraus (1):
  gnu: nettle: Fix mingw cross-compilation.

 gnu/packages/nettle.scm | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)


base-commit: 658c09333da095edf6e1b3c5e351a7bfa3c87354
-- 
2.38.1




^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#60563: [PATCH 0/1] Fix mingw cross-compilation of nettle
  2023-01-04 23:04 ` [bug#60563] [PATCH 1/1] gnu: nettle: Fix mingw cross-compilation Vivien Kraus via Guix-patches via
@ 2023-01-19 16:31   ` Ludovic Courtès
  0 siblings, 0 replies; 3+ messages in thread
From: Ludovic Courtès @ 2023-01-19 16:31 UTC (permalink / raw)
  To: Vivien Kraus; +Cc: 60563-done

Hi Vivien,

Vivien Kraus <vivien@planete-kraus.eu> skribis:

> * gnu/packages/nettle.scm (nettle-2) [move-static-libraries]: .dll.a files are
> not static libraries.

Applied, thanks!

Ludo’.




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-01-19 16:33 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-04 23:36 [bug#60563] [PATCH 0/1] Fix mingw cross-compilation of nettle Vivien Kraus via Guix-patches via
2023-01-04 23:04 ` [bug#60563] [PATCH 1/1] gnu: nettle: Fix mingw cross-compilation Vivien Kraus via Guix-patches via
2023-01-19 16:31   ` bug#60563: [PATCH 0/1] Fix mingw cross-compilation of nettle Ludovic Courtès

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).