From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Bruno Victal <mirai@makinata.eu>
Cc: 60788@debbugs.gnu.org
Subject: [bug#60788] [PATCH v5] services: Add vnstat-service-type.
Date: Fri, 10 Feb 2023 09:07:40 -0500 [thread overview]
Message-ID: <87lel5fwb7.fsf@gmail.com> (raw)
In-Reply-To: <965e112603934b79ec784738a3ad075bfdb0dd51.1676034889.git.mirai@makinata.eu> (Bruno Victal's message of "Fri, 10 Feb 2023 13:15:13 +0000")
Hi!
Bruno Victal <mirai@makinata.eu> writes:
[...]
> + vnstat-configuration
> + vnstat-configuration?
> + vnstat-service-type
> + vnstat-configuration-package
> + vnstat-configuration-database-dir
> + vnstat-configuration-5-minute-hours
> + vnstat-configuration-64bit-interface-counters
> + vnstat-configuration-always-add-new-interfaces?
> + vnstat-configuration-bandwidth-detection?
> + vnstat-configuration-bandwidth-detection-interval
> + vnstat-configuration-boot-variation
> + vnstat-configuration-check-disk-space?
> + vnstat-configuration-create-dirs?
> + vnstat-configuration-daemon-group
> + vnstat-configuration-daemon-user
> + vnstat-configuration-daily-days
> + vnstat-configuration-database-synchronous
> + vnstat-configuration-database-write-ahead-logging?
> + vnstat-configuration-hourly-days
> + vnstat-configuration-log-file
> + vnstat-configuration-max-bandwidth
> + vnstat-configuration-max-BW
^ Looks like you forgot to adjust to use the now all lowercase symbol
here.
> + vnstat-configuration-monthly-months
> + vnstat-configuration-month-rotate
> + vnstat-configuration-month-rotate-affects-years?
> + vnstat-configuration-offline-save-interval
> + vnstat-configuration-pid-file
> + vnstat-configuration-poll-interval
> + vnstat-configuration-rescan-database-on-save?
> + vnstat-configuration-save-interval
> + vnstat-configuration-save-on-status-change?
> + vnstat-configuration-time-sync-wait
> + vnstat-configuration-top-day-entries
> + vnstat-configuration-trafficless-entries?
> + vnstat-configuration-update-file-owner?
> + vnstat-configuration-update-interval
> + vnstat-configuration-use-logging
> + vnstat-configuration-use-UTC?
Ditto.
The rest LGTM.
--
Thanks,
Maxim
next prev parent reply other threads:[~2023-02-10 15:24 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 20:07 [bug#60788] [PATCH] services: Add vnstat-service-type Bruno Victal
2023-01-14 21:06 ` [bug#60788] [PATCH v2] " Bruno Victal
2023-01-16 18:42 ` [bug#60788] [PATCH] " Maxim Cournoyer
2023-01-16 19:31 ` Bruno Victal
2023-01-16 19:56 ` Maxim Cournoyer
2023-01-18 0:34 ` [bug#60788] [PATCH v2] " Bruno Victal
2023-01-18 0:37 ` [bug#60788] [PATCH v2] services: vnstat: Use least-authority-wrapper Bruno Victal
2023-02-02 14:21 ` [bug#60788] [PATCH v3] services: Add vnstat-service-type Bruno Victal
2023-02-07 14:25 ` [bug#60788] [PATCH v4] " Bruno Victal
2023-02-09 3:34 ` [bug#60788] [PATCH] " Maxim Cournoyer
2023-02-09 4:19 ` Bruno Victal
2023-02-09 13:31 ` Maxim Cournoyer
2023-02-10 13:15 ` [bug#60788] [PATCH v5] " Bruno Victal
2023-02-10 14:07 ` Maxim Cournoyer [this message]
2023-02-10 14:14 ` [bug#60788] [PATCH v6] " Bruno Victal
2023-03-22 16:15 ` [bug#60788] [PATCH v7] " Bruno Victal
2023-04-03 14:14 ` [bug#60788] [PATCH v8] " Bruno Victal
2023-04-04 13:08 ` [bug#60788] [PATCH v9] " Bruno Victal
2023-04-07 15:22 ` [bug#60788] [PATCH] " Ludovic Courtès
2023-04-07 20:04 ` Maxim Cournoyer
2023-04-20 10:03 ` [bug#60788] Policy for system tests? Ludovic Courtès
2023-04-08 12:40 ` [bug#60788] [PATCH] services: Add vnstat-service-type Bruno Victal
2023-04-20 10:09 ` Ludovic Courtès
2023-05-05 0:18 ` [bug#60788] [PATCH v10 1/3] " Bruno Victal
2023-05-11 14:33 ` bug#60788: " Ludovic Courtès
2023-05-05 0:18 ` [bug#60788] [PATCH v10 2/3] services: inetd: Export accessors Bruno Victal
2023-05-05 0:18 ` [bug#60788] [PATCH v10 3/3] tests: Add vnstat tests Bruno Victal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lel5fwb7.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=60788@debbugs.gnu.org \
--cc=mirai@makinata.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).