From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id eEsiEJFh5mNMTgAAbAwnHQ (envelope-from ) for ; Fri, 10 Feb 2023 16:24:01 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id wDfQD5Fh5mMIGAAAauVa8A (envelope-from ) for ; Fri, 10 Feb 2023 16:24:01 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 01F5C2A063 for ; Fri, 10 Feb 2023 16:24:00 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pQU4M-0005G8-BW; Fri, 10 Feb 2023 09:08:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQU4K-0005Dn-6m for guix-patches@gnu.org; Fri, 10 Feb 2023 09:08:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pQU4I-0004fm-Bj for guix-patches@gnu.org; Fri, 10 Feb 2023 09:08:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pQU4I-0004lr-0Z for guix-patches@gnu.org; Fri, 10 Feb 2023 09:08:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60788] [PATCH v5] services: Add vnstat-service-type. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 10 Feb 2023 14:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60788 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Bruno Victal Cc: 60788@debbugs.gnu.org Received: via spool by 60788-submit@debbugs.gnu.org id=B60788.167603807118322 (code B ref 60788); Fri, 10 Feb 2023 14:08:01 +0000 Received: (at 60788) by debbugs.gnu.org; 10 Feb 2023 14:07:51 +0000 Received: from localhost ([127.0.0.1]:34517 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQU46-0004lR-JI for submit@debbugs.gnu.org; Fri, 10 Feb 2023 09:07:50 -0500 Received: from mail-qt1-f179.google.com ([209.85.160.179]:36629) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQU44-0004lD-38 for 60788@debbugs.gnu.org; Fri, 10 Feb 2023 09:07:49 -0500 Received: by mail-qt1-f179.google.com with SMTP id v17so5790678qto.3 for <60788@debbugs.gnu.org>; Fri, 10 Feb 2023 06:07:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=LXO+RIVi/2vc840MxuqwggkzN94MU/UdezH4x0r8krQ=; b=ilDUNEaH8IuK7is4CicEnBmfpRW17V9pXfguLuklL+SnU/CyOnhcuuFf6sPwKltq24 H+SYicSNzS1r+RVOgl2jgJj/WAfSfMSDL+1N9P9RYkET3n+UlMV0i/oTT+P0bBmfPda/ 5CMjsrVg4YMh1tBT3BVRvnO5SjOGiLupfUgqgBA1xazv+YQKvpacOP3EY6/zIiK/ZDJK 5Q4Y8/nzYRdLBbSMXB9hPfoyNh21ThofWUQ4sl0gLSNcOo4gn8Tvv3KQ0bTnRGIEbFzq yWzfG+dKKX0vWUouqBIkLEpHL3gc3aRJ/POlABwKarWwl56R7OTAQtzkkaqKz7jfH+eH 3uGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LXO+RIVi/2vc840MxuqwggkzN94MU/UdezH4x0r8krQ=; b=Pwu6Z9nhr7XFCVfKnUlb5vwK/0p3k8nuYcN37vp1DBP8Q84fSRWXeMkgzjVXWrLP8j 3s4Fq7CvELmhvOuDph6JKNMVUOhbzRf5zYPckx37/wKr4O3+eb4vJ/gRwRQTKt9KKXTR gS0ZQNsEQuuctnXLB2qWOBFnd0zKzNm6v7JhMD3ELswl7BDrUkyyKP/Hq/FWwyNta4ZE AAbTZeeQc4ZuyEjlnCXR747HmTWYmSB+SqMR4+Ipb9PSf1aPJ3t9VGmy45mOSNj61aRT mWpTnXC9k+GdZIts5DhbaC9Hc+KCvWXEB1XlYRQjJnBXVORl0/zv8hkES9bDfQJL/Y49 K0KQ== X-Gm-Message-State: AO0yUKUhUN0fiZAVYc8NT9aY4OEEmtEKpbcizlJ4exxv4H36Ov2IlRy0 57hA84GHXasIHOqbJJx+x8IlJzVY9M8s7v9i X-Google-Smtp-Source: AK7set/9ZThIsucTWVc1UYu5PZ55MfgaeXddIp/Wp8vcxwuV9Wmk+aLznFHdBGLNulZ2LbqgG913hQ== X-Received: by 2002:ac8:580f:0:b0:3b8:4b00:575e with SMTP id g15-20020ac8580f000000b003b84b00575emr25003944qtg.35.1676038062359; Fri, 10 Feb 2023 06:07:42 -0800 (PST) Received: from hurd (dsl-158-147.b2b2c.ca. [66.158.158.147]) by smtp.gmail.com with ESMTPSA id s4-20020a372c04000000b006f9f3c0c63csm3574924qkh.32.2023.02.10.06.07.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Feb 2023 06:07:41 -0800 (PST) From: Maxim Cournoyer References: <965e112603934b79ec784738a3ad075bfdb0dd51.1676034889.git.mirai@makinata.eu> Date: Fri, 10 Feb 2023 09:07:40 -0500 In-Reply-To: <965e112603934b79ec784738a3ad075bfdb0dd51.1676034889.git.mirai@makinata.eu> (Bruno Victal's message of "Fri, 10 Feb 2023 13:15:13 +0000") Message-ID: <87lel5fwb7.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1676042641; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=LXO+RIVi/2vc840MxuqwggkzN94MU/UdezH4x0r8krQ=; b=ef+m3cgLQZ1T0UucHD22ijsP1KdJO+UjuyWd5QHhMOpoTtfnsuWyPsTD+r9edyHJyNjdhZ yKdpLdgZCyG5ypzwkkbK/Kk6ulgiGcYifmsqLH19QuSb5Vv9Ir44AdF/jIPguSPc7A0RxD oxmdNbPl/JcmKYLwqibFPqDOCbCPKifpAUbBuaDpM1iT1EHZKsT9AAEvGjbYFciX1LUepA wOINAWJ/Pq6xEShrFtbqreKfhNyp6O1OtiiIR+mHa84RnHuVhYY+g+zknMfApDkPOmheL2 MrbGUAKQw+/fw/D+v0kDuchVfgDHal0FxbwhQ8k3oUGrj3tDWG2Ql2GYApgOxA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=ilDUNEaH; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1676042641; a=rsa-sha256; cv=none; b=guvziKWmHc0sw73k2aP5hFIomlpqgw729902fbo1O8/2XSe6oJYNdXkoyJrg6EdvLTAbpN AJs3PvcwSPiY2PaDyJ23KtETaRlhCcZtPULdKmib1+L9uglpnjF1UTn+DdWP9ER7nBLluD bDx5CVmr2Wn1dMGmOiKqDdhP1wZyk/LUjLsdQqlQTJewI3iC1GUpvUvwUHDFud+rBHcoaK cep1GCsguooqxYIaJZvIhL+FgFnPA4yu/jf/iMNLzTTQ4so4CzVp9FNtCw6oeNFEKqcB4l gu7PCyUcjYqnerc5Lwtpm1yXEV8RZv5qQvaOOfcXxpJXWWLKRkkK+Env/fanrQ== Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=ilDUNEaH; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.89 X-Spam-Score: 5.89 X-Migadu-Queue-Id: 01F5C2A063 X-Migadu-Scanner: scn1.migadu.com X-TUID: FqKezGiW9C4d Hi! Bruno Victal writes: [...] > + vnstat-configuration > + vnstat-configuration? > + vnstat-service-type > + vnstat-configuration-package > + vnstat-configuration-database-dir > + vnstat-configuration-5-minute-hours > + vnstat-configuration-64bit-interface-counters > + vnstat-configuration-always-add-new-interfaces? > + vnstat-configuration-bandwidth-detection? > + vnstat-configuration-bandwidth-detection-interval > + vnstat-configuration-boot-variation > + vnstat-configuration-check-disk-space? > + vnstat-configuration-create-dirs? > + vnstat-configuration-daemon-group > + vnstat-configuration-daemon-user > + vnstat-configuration-daily-days > + vnstat-configuration-database-synchronous > + vnstat-configuration-database-write-ahead-logging? > + vnstat-configuration-hourly-days > + vnstat-configuration-log-file > + vnstat-configuration-max-bandwidth > + vnstat-configuration-max-BW ^ Looks like you forgot to adjust to use the now all lowercase symbol here. > + vnstat-configuration-monthly-months > + vnstat-configuration-month-rotate > + vnstat-configuration-month-rotate-affects-years? > + vnstat-configuration-offline-save-interval > + vnstat-configuration-pid-file > + vnstat-configuration-poll-interval > + vnstat-configuration-rescan-database-on-save? > + vnstat-configuration-save-interval > + vnstat-configuration-save-on-status-change? > + vnstat-configuration-time-sync-wait > + vnstat-configuration-top-day-entries > + vnstat-configuration-trafficless-entries? > + vnstat-configuration-update-file-owner? > + vnstat-configuration-update-interval > + vnstat-configuration-use-logging > + vnstat-configuration-use-UTC? Ditto. The rest LGTM. -- Thanks, Maxim