unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#67466] [PATCH gnome-team] gnu: rygel: Update to 0.42.4.
@ 2023-11-26 16:58 Vivien Kraus via Guix-patches via
  2023-12-03 23:56 ` Maxim Cournoyer
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Vivien Kraus via Guix-patches via @ 2023-11-26 16:58 UTC (permalink / raw)
  To: 67466; +Cc: rg, liliana.prikler, maxim.cournoyer

* gnu/packages/gnome.scm (rygel): Update to 0.42.4.
[arguments]: Convert to list of G-Expressions.
[propagated-inputs]: Add glib.

Change-Id: I17da7894a9626cd056c7c86ac6747acc0828e1ba
---
 gnu/packages/gnome.scm | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index d354327497..d6ee3493b5 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -1676,7 +1676,7 @@ (define-public sushi
 (define-public rygel
   (package
     (name "rygel")
-    (version "0.41.2")
+    (version "0.42.4")
     (source (origin
               (method url-fetch)
               (uri (string-append "mirror://gnome/sources/" name "/"
@@ -1684,12 +1684,12 @@ (define-public rygel
                                   name "-" version ".tar.xz"))
               (sha256
                (base32
-                "0wivd60hn115ar3hsrsa595kpxzp8gwq30ksh32qlq8j9dhlq65i"))))
+                "1xq36f0n42yall67ibqzqsdpvljbdanhy0lvkc8ncark5nmdy433"))))
     (build-system meson-build-system)
     (arguments
      ;; Disable the tracker plugin.
-     '(#:configure-flags
-       (list "-Dplugins=external,gst-launch,lms,media-export,
+     (list #:configure-flags
+           #~'("-Dplugins=external,gst-launch,lms,media-export,
 mpris,playbin,ruih,tracker3")))
     (native-inputs
      (list gettext-minimal
@@ -1719,6 +1719,9 @@ (define-public rygel
            libxslt
            libunistring
            tracker))
+    (propagated-inputs
+     ;; The .pc files require.private gmodule-2.0
+     (list glib))
     (synopsis "Share audio, video, and pictures with other devices")
     (description
      "Rygel is a home media solution (@dfn{UPnP AV MediaServer and

base-commit: e21f0cb7b7a87992004193cd56638ad961fe5928
-- 
2.41.0




^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [bug#67466] [PATCH gnome-team] gnu: rygel: Update to 0.42.4.
  2023-11-26 16:58 [bug#67466] [PATCH gnome-team] gnu: rygel: Update to 0.42.4 Vivien Kraus via Guix-patches via
@ 2023-12-03 23:56 ` Maxim Cournoyer
  2023-12-04 17:27 ` [bug#67466] [PATCH gnome-team v2] gnu: rygel: Improve style Vivien Kraus via Guix-patches via
  2023-12-19 23:16 ` bug#67466: Closing! Vivien Kraus via Guix-patches via
  2 siblings, 0 replies; 5+ messages in thread
From: Maxim Cournoyer @ 2023-12-03 23:56 UTC (permalink / raw)
  To: Vivien Kraus; +Cc: rg, liliana.prikler, 67466

Hello,

Vivien Kraus <vivien@planete-kraus.eu> writes:

> * gnu/packages/gnome.scm (rygel): Update to 0.42.4.
> [arguments]: Convert to list of G-Expressions.
> [propagated-inputs]: Add glib.
>
> Change-Id: I17da7894a9626cd056c7c86ac6747acc0828e1ba
> ---
>  gnu/packages/gnome.scm | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index d354327497..d6ee3493b5 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -1676,7 +1676,7 @@ (define-public sushi
>  (define-public rygel
>    (package
>      (name "rygel")
> -    (version "0.41.2")
> +    (version "0.42.4")
>      (source (origin
>                (method url-fetch)
>                (uri (string-append "mirror://gnome/sources/" name "/"
> @@ -1684,12 +1684,12 @@ (define-public rygel
>                                    name "-" version ".tar.xz"))
>                (sha256
>                 (base32
> -                "0wivd60hn115ar3hsrsa595kpxzp8gwq30ksh32qlq8j9dhlq65i"))))
> +                "1xq36f0n42yall67ibqzqsdpvljbdanhy0lvkc8ncark5nmdy433"))))
>      (build-system meson-build-system)
>      (arguments
>       ;; Disable the tracker plugin.
> -     '(#:configure-flags
> -       (list "-Dplugins=external,gst-launch,lms,media-export,
> +     (list #:configure-flags
> +           #~'("-Dplugins=external,gst-launch,lms,media-export,
>  mpris,playbin,ruih,tracker3")))

Nitpick: I prefer the #~(list "args" ...) style, which I find more readable.

Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail.com>

-- 
Thanks,
Maxim




^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#67466] [PATCH gnome-team v2] gnu: rygel: Improve style.
  2023-11-26 16:58 [bug#67466] [PATCH gnome-team] gnu: rygel: Update to 0.42.4 Vivien Kraus via Guix-patches via
  2023-12-03 23:56 ` Maxim Cournoyer
@ 2023-12-04 17:27 ` Vivien Kraus via Guix-patches via
  2023-12-04 23:05   ` Maxim Cournoyer
  2023-12-19 23:16 ` bug#67466: Closing! Vivien Kraus via Guix-patches via
  2 siblings, 1 reply; 5+ messages in thread
From: Vivien Kraus via Guix-patches via @ 2023-12-04 17:27 UTC (permalink / raw)
  To: Maxim Cournoyer; +Cc: rg, 67466, liliana.prikler

* gnu/packages/gnome.scm (rygel) [#:configure-flags]: Use the 'list' syntax
istead of 'quote'.

Change-Id: I173b5872ebfa82855055145923cd2f1a1b4d68d1
---
Hi,

The patch was already applied, so I make a new commit.

I am sorry for the X-Debbugs-CC error on my side, I understand why it is
useful and I will systematically use it in the future for new submissions.

Best regards,

Vivien

 gnu/packages/gnome.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index c6437ce450..2bb0587d5f 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -1697,7 +1697,7 @@ (define-public rygel
     (arguments
      ;; Disable the tracker plugin.
      (list #:configure-flags
-           #~'("-Dplugins=external,gst-launch,lms,media-export,
+           #~(list "-Dplugins=external,gst-launch,lms,media-export,
 mpris,playbin,ruih,tracker3")))
     (native-inputs
      (list gettext-minimal

base-commit: 4c323c2f8308bba0e3295f3109d159c7b8f72838
-- 
2.41.0




^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [bug#67466] [PATCH gnome-team v2] gnu: rygel: Improve style.
  2023-12-04 17:27 ` [bug#67466] [PATCH gnome-team v2] gnu: rygel: Improve style Vivien Kraus via Guix-patches via
@ 2023-12-04 23:05   ` Maxim Cournoyer
  0 siblings, 0 replies; 5+ messages in thread
From: Maxim Cournoyer @ 2023-12-04 23:05 UTC (permalink / raw)
  To: Vivien Kraus; +Cc: rg, 67466, liliana.prikler

Vivien Kraus <vivien@planete-kraus.eu> writes:

> * gnu/packages/gnome.scm (rygel) [#:configure-flags]: Use the 'list' syntax
> istead of 'quote'.
>
> Change-Id: I173b5872ebfa82855055145923cd2f1a1b4d68d1

Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail>

-- 
Thanks,
Maxim




^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#67466: Closing!
  2023-11-26 16:58 [bug#67466] [PATCH gnome-team] gnu: rygel: Update to 0.42.4 Vivien Kraus via Guix-patches via
  2023-12-03 23:56 ` Maxim Cournoyer
  2023-12-04 17:27 ` [bug#67466] [PATCH gnome-team v2] gnu: rygel: Improve style Vivien Kraus via Guix-patches via
@ 2023-12-19 23:16 ` Vivien Kraus via Guix-patches via
  2 siblings, 0 replies; 5+ messages in thread
From: Vivien Kraus via Guix-patches via @ 2023-12-19 23:16 UTC (permalink / raw)
  To: 67466-done

It has been pushed.




^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-12-19 23:18 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-26 16:58 [bug#67466] [PATCH gnome-team] gnu: rygel: Update to 0.42.4 Vivien Kraus via Guix-patches via
2023-12-03 23:56 ` Maxim Cournoyer
2023-12-04 17:27 ` [bug#67466] [PATCH gnome-team v2] gnu: rygel: Improve style Vivien Kraus via Guix-patches via
2023-12-04 23:05   ` Maxim Cournoyer
2023-12-19 23:16 ` bug#67466: Closing! Vivien Kraus via Guix-patches via

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).