[bug#28718] [PATCH] gnu: qemu: Add sysconfdir to configure-flags.

[bug#28718] [PATCH] gnu: qemu: Add sysconfdir to configure-flags.

[Oleg Pykhalov]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: [PATCH] gnu: qemu: Add sysconfdir to configure-flags. --]
[-- Type: text/x-patch, Size: 1005 bytes --]

From 371ba5aee9ef1412753fdb43230f107087f9651b Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust@gmail.com>
Date: Fri, 6 Oct 2017 06:24:58 +0300
Subject: [PATCH] gnu: qemu: Add sysconfdir to configure-flags.

* gnu/packages/virtualization.scm (qemu): Add sysconfdir to configure-flags.
---
 gnu/packages/virtualization.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualization.scm
index a8e54d684..21fc7b784 100644
--- a/gnu/packages/virtualization.scm
+++ b/gnu/packages/virtualization.scm
@@ -111,6 +111,7 @@
                          "--disable-debug-info" ; save build space
                          "--enable-virtfs"      ; just to be sure
                          ,(string-append "--prefix=" out)
+                         ,(string-append "--sysconfdir=/tmp/etc")
                          ,@configure-flags))))))
          (add-after 'install 'install-info
            (lambda* (#:key inputs outputs #:allow-other-keys)
-- 
2.14.2

[bug#28718] Status: [PATCH] gnu: qemu: Add sysconfdir to configure-flags.

[Oleg Pykhalov]

I've used this patch to run a QEMU VM with bridge interface.

$ mkdir -p /tmp/etc/qemu
$ echo 'allow bridge0' | tee -a /tmp/etc/qemu/bridge.conf
# ip link add bridge0 type bridge
# ip link set dev enp6s0 master bridge0
# ip link up bridge0
# dhclient bridge0
# qemu-system-x86_64 -net nic -net bridge,br=bridge0 # …

[bug#28718] [PATCH] gnu: qemu: Add sysconfdir to configure-flags.

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 1296 bytes --]

On Fri, Oct 06, 2017 at 06:30:34AM +0300, Oleg Pykhalov wrote:
> From 371ba5aee9ef1412753fdb43230f107087f9651b Mon Sep 17 00:00:00 2001
> From: Oleg Pykhalov <go.wigust@gmail.com>
> Date: Fri, 6 Oct 2017 06:24:58 +0300
> Subject: [PATCH] gnu: qemu: Add sysconfdir to configure-flags.
> 
> * gnu/packages/virtualization.scm (qemu): Add sysconfdir to configure-flags.

Hi Oleg, thanks for the patch.

> ---
>  gnu/packages/virtualization.scm | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualization.scm
> index a8e54d684..21fc7b784 100644
> --- a/gnu/packages/virtualization.scm
> +++ b/gnu/packages/virtualization.scm
> @@ -111,6 +111,7 @@
>                           "--disable-debug-info" ; save build space
>                           "--enable-virtfs"      ; just to be sure
>                           ,(string-append "--prefix=" out)
> +                         ,(string-append "--sysconfdir=/tmp/etc")
>                           ,@configure-flags))))))
>           (add-after 'install 'install-info
>             (lambda* (#:key inputs outputs #:allow-other-keys)

Can you describe the problem this patch aims to address? And, where does
QEMU look for its configuration when this flag is not set?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[bug#28718] [PATCH] gnu: qemu: Add sysconfdir to configure-flags.

[Ludovic Courtès]

Hi Oleg,

Oleg Pykhalov <go.wigust@gmail.com> skribis:

> From 371ba5aee9ef1412753fdb43230f107087f9651b Mon Sep 17 00:00:00 2001
> From: Oleg Pykhalov <go.wigust@gmail.com>
> Date: Fri, 6 Oct 2017 06:24:58 +0300
> Subject: [PATCH] gnu: qemu: Add sysconfdir to configure-flags.
>
> * gnu/packages/virtualization.scm (qemu): Add sysconfdir to configure-flags.
> ---
>  gnu/packages/virtualization.scm | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualization.scm
> index a8e54d684..21fc7b784 100644
> --- a/gnu/packages/virtualization.scm
> +++ b/gnu/packages/virtualization.scm
> @@ -111,6 +111,7 @@
>                           "--disable-debug-info" ; save build space
>                           "--enable-virtfs"      ; just to be sure
>                           ,(string-append "--prefix=" out)
> +                         ,(string-append "--sysconfdir=/tmp/etc")

[...]

> I've used this patch to run a QEMU VM with bridge interface.
>
> $ mkdir -p /tmp/etc/qemu
> $ echo 'allow bridge0' | tee -a /tmp/etc/qemu/bridge.conf
> # ip link add bridge0 type bridge
> # ip link set dev enp6s0 master bridge0
> # ip link up bridge0
> # dhclient bridge0
> # qemu-system-x86_64 -net nic -net bridge,br=bridge0 # …

It feels wrong to me to default to /tmp/etc instead of /etc.

Setting up a bridge requires root privileges anyway, so why not stick to
/etc instead of /tmp/etc?

Thanks,
Ludo’.

[bug#28718] [PATCH] gnu: qemu: Add sysconfdir to configure-flags.

[Oleg Pykhalov]

Hello Ludovic,

ludo@gnu.org (Ludovic Courtès) writes:

[...]

>> I've used this patch to run a QEMU VM with bridge interface.
>>
>> $ mkdir -p /tmp/etc/qemu
>> $ echo 'allow bridge0' | tee -a /tmp/etc/qemu/bridge.conf
>> # ip link add bridge0 type bridge
>> # ip link set dev enp6s0 master bridge0
>> # ip link up bridge0
>> # dhclient bridge0
>> # qemu-system-x86_64 -net nic -net bridge,br=bridge0 # …
>
> It feels wrong to me to default to /tmp/etc instead of /etc.
>
> Setting up a bridge requires root privileges anyway, so why not stick to
> /etc instead of /tmp/etc?

It's inspired by libvirt package recipe :-)

[bug#28718] [PATCH] gnu: qemu: Add sysconfdir to configure-flags.

[Ludovic Courtès]

Oleg Pykhalov <go.wigust@gmail.com> skribis:

> Hello Ludovic,
>
> ludo@gnu.org (Ludovic Courtès) writes:
>
> [...]
>
>>> I've used this patch to run a QEMU VM with bridge interface.
>>>
>>> $ mkdir -p /tmp/etc/qemu
>>> $ echo 'allow bridge0' | tee -a /tmp/etc/qemu/bridge.conf
>>> # ip link add bridge0 type bridge
>>> # ip link set dev enp6s0 master bridge0
>>> # ip link up bridge0
>>> # dhclient bridge0
>>> # qemu-system-x86_64 -net nic -net bridge,br=bridge0 # …
>>
>> It feels wrong to me to default to /tmp/etc instead of /etc.
>>
>> Setting up a bridge requires root privileges anyway, so why not stick to
>> /etc instead of /tmp/etc?
>
> It's inspired by libvirt package recipe :-)

Looking at commit a4b9392151 for libvirt, I think it’s a trick here: we
do pass --sysconfdir=/etc, and sysconfdir=/tmp/etc is passed only during
the install phase, which I think is a trick to avoid errors while
creating $(sysconfdir).  But /etc is the actual sysconfdir AIUI.

So, WDYT?  :-)

Ludo’.

[bug#28718] [PATCH] gnu: qemu: Add sysconfdir to configure-flags.

[Oleg Pykhalov]

[-- Attachment #1: Type: text/plain, Size: 1174 bytes --]

Hello Ludovic,

ludo@gnu.org (Ludovic Courtès) writes:

[...]

>>>> I've used this patch to run a QEMU VM with bridge interface.
>>>>
>>>> $ mkdir -p /tmp/etc/qemu
>>>> $ echo 'allow bridge0' | tee -a /tmp/etc/qemu/bridge.conf
>>>> # ip link add bridge0 type bridge
>>>> # ip link set dev enp6s0 master bridge0
>>>> # ip link up bridge0
>>>> # dhclient bridge0
>>>> # qemu-system-x86_64 -net nic -net bridge,br=bridge0 # …
>>>
>>> It feels wrong to me to default to /tmp/etc instead of /etc.
>>>
>>> Setting up a bridge requires root privileges anyway, so why not stick to
>>> /etc instead of /tmp/etc?
>>
>> It's inspired by libvirt package recipe :-)
>
> Looking at commit a4b9392151 for libvirt, I think it’s a trick here: we
> do pass --sysconfdir=/etc, and sysconfdir=/tmp/etc is passed only during
> the install phase, which I think is a trick to avoid errors while
> creating $(sysconfdir).  But /etc is the actual sysconfdir AIUI.
>
> So, WDYT?  :-)

Thank you for investigation.  I saw no reason not to use file-system
convention at the beginning of discussion.  Here is an another patch.
Build finished successfully for me.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-qemu-Add-sysconfdir-to-configure-flags.patch --]
[-- Type: text/x-patch, Size: 1002 bytes --]

From fcff3b4b2c53af7974786f7f4dd1633c9b634130 Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust@gmail.com>
Date: Fri, 6 Oct 2017 06:24:58 +0300
Subject: [PATCH] gnu: qemu: Add sysconfdir to configure-flags.

* gnu/packages/virtualization.scm (qemu): Add sysconfdir to configure-flags.
---
 gnu/packages/virtualization.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualization.scm
index a8e54d684..4e384e79a 100644
--- a/gnu/packages/virtualization.scm
+++ b/gnu/packages/virtualization.scm
@@ -111,6 +111,7 @@
                          "--disable-debug-info" ; save build space
                          "--enable-virtfs"      ; just to be sure
                          ,(string-append "--prefix=" out)
+                         ,(string-append "--sysconfdir=/etc")
                          ,@configure-flags))))))
          (add-after 'install 'install-info
            (lambda* (#:key inputs outputs #:allow-other-keys)
-- 
2.14.2

bug#28718: [PATCH] gnu: qemu: Add sysconfdir to configure-flags.

[Ludovic Courtès]

Oleg Pykhalov <go.wigust@gmail.com> skribis:

> From fcff3b4b2c53af7974786f7f4dd1633c9b634130 Mon Sep 17 00:00:00 2001
> From: Oleg Pykhalov <go.wigust@gmail.com>
> Date: Fri, 6 Oct 2017 06:24:58 +0300
> Subject: [PATCH] gnu: qemu: Add sysconfdir to configure-flags.
>
> * gnu/packages/virtualization.scm (qemu): Add sysconfdir to configure-flags.

Applied, thanks!

Ludo'.