unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Clément Lassieur" <clement@lassieur.org>
To: Oleg Pykhalov <go.wigust@gmail.com>
Cc: 29820@debbugs.gnu.org
Subject: [bug#29820] [PATCH] services: cgit: Add more configuration fields.
Date: Tue, 26 Dec 2017 14:54:21 +0100	[thread overview]
Message-ID: <87k1x9bnn6.fsf@lassieur.org> (raw)
In-Reply-To: <87incy9yv6.fsf@gmail.com>

Oleg Pykhalov <go.wigust@gmail.com> writes:

> +  (project-list
> +   (list '())
> +   "A list of subdirectories inside of @code{repository-directory}, relative
> +to it, that should loaded as Git repositories.")

I forgot one thing: 'project-list' is a file, not a list of strings.  I
agree it's weird that cgit's documentation doesn't say it's a file.  I
see two solutions:

1. Change the type to 'string', so that people can set a file name.

2. Use a list type that would transparently transform its values into a
   file in the store, with the generated cgitrc file pointing to it.

The second solution is better because the user won't need to create the
file.

  parent reply	other threads:[~2017-12-26 13:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-22 22:33 [bug#29820] [PATCH] services: cgit: Add more configuration fields Oleg Pykhalov
2017-12-25 17:00 ` Clément Lassieur
2017-12-26 13:54 ` Clément Lassieur [this message]
2017-12-26 19:59 ` Clément Lassieur
2017-12-28 16:45   ` Oleg Pykhalov
2017-12-29 18:40     ` Clément Lassieur
2018-01-31  3:26       ` Oleg Pykhalov
2018-02-24 23:03         ` Clément Lassieur
2018-02-24 23:09           ` Clément Lassieur
2018-02-25  5:25           ` Oleg Pykhalov
2018-02-25  9:34             ` Clément Lassieur
2018-02-27 17:25               ` Ludovic Courtès
2018-02-28  1:50                 ` bug#29820: " Oleg Pykhalov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k1x9bnn6.fsf@lassieur.org \
    --to=clement@lassieur.org \
    --cc=29820@debbugs.gnu.org \
    --cc=go.wigust@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).