From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47058) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eTphA-0004X7-UL for guix-patches@gnu.org; Tue, 26 Dec 2017 08:55:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eTph8-0000VP-9m for guix-patches@gnu.org; Tue, 26 Dec 2017 08:55:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:43776) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eTph8-0000V8-5U for guix-patches@gnu.org; Tue, 26 Dec 2017 08:55:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eTph7-0005o2-Ow for guix-patches@gnu.org; Tue, 26 Dec 2017 08:55:01 -0500 Subject: [bug#29820] [PATCH] services: cgit: Add more configuration fields. Resent-Message-ID: References: <87incy9yv6.fsf@gmail.com> From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur In-reply-to: <87incy9yv6.fsf@gmail.com> Date: Tue, 26 Dec 2017 14:54:21 +0100 Message-ID: <87k1x9bnn6.fsf@lassieur.org> MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Oleg Pykhalov Cc: 29820@debbugs.gnu.org Oleg Pykhalov writes: > + (project-list > + (list '()) > + "A list of subdirectories inside of @code{repository-directory}, relative > +to it, that should loaded as Git repositories.") I forgot one thing: 'project-list' is a file, not a list of strings. I agree it's weird that cgit's documentation doesn't say it's a file. I see two solutions: 1. Change the type to 'string', so that people can set a file name. 2. Use a list type that would transparently transform its values into a file in the store, with the generated cgitrc file pointing to it. The second solution is better because the user won't need to create the file.