unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#37535] [PATCH] gnu: Add python-flask-cors.
@ 2019-09-27 22:16 Hamzeh Nasajpour
  2019-09-28 20:40 ` Ludovic Courtès
  0 siblings, 1 reply; 4+ messages in thread
From: Hamzeh Nasajpour @ 2019-09-27 22:16 UTC (permalink / raw)
  To: 37535

* gnu/packages/python-web.scm (python-flask-cors): New variable.
---
 gnu/packages/python-web.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index e37ae94e18..276ed0f01f 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -2146,6 +2146,27 @@ SlimIt also provides a library that includes a JavaScript parser, lexer,
 pretty printer and a tree visitor.")
     (license license:expat)))
 
+(define-public python-flask-cors
+  (package
+  (name "python-flask-cors")
+    (version "3.0.7")
+    (source (origin
+      (method url-fetch)
+      (uri (pypi-uri "Flask-Cors" version))
+      (sha256 (base32 "1v6gq4vjgyxi8q8lxawpdfhq01adb4bznnabp08ks5nzbwibz43y"))))
+    (build-system python-build-system)
+    (arguments
+      `(#:tests? #f))
+    (propagated-inputs
+      `(("python-six" ,python-six)
+        ("python-flask" ,python-flask)))
+    (home-page "https://github.com/corydolphin/flask-cors")
+    (synopsis "A Flask extension adding a decorator for CORS support")
+    (description
+     "A Flask extension for handling Cross Origin Resource Sharing (CORS), 
+making cross-origin AJAX possible.")
+    (license license:expat)))
+
 (define-public python-flask-restful
   (package
     (name "python-flask-restful")
-- 
2.23.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#37535] [PATCH] gnu: Add python-flask-cors.
  2019-09-27 22:16 [bug#37535] [PATCH] gnu: Add python-flask-cors Hamzeh Nasajpour
@ 2019-09-28 20:40 ` Ludovic Courtès
  2019-10-06 12:36   ` Ludovic Courtès
  0 siblings, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2019-09-28 20:40 UTC (permalink / raw)
  To: Hamzeh Nasajpour; +Cc: 37535

Hi Hamzeh,

"Hamzeh Nasajpour" <h.nasajpour@pantherx.org> skribis:

> * gnu/packages/python-web.scm (python-flask-cors): New variable.

[...]

> +(define-public python-flask-cors
> +  (package
> +  (name "python-flask-cors")
> +    (version "3.0.7")

The indentation is different from what we usually do.  Could you run
./etc/indent-code.el as noted at
<https://guix.gnu.org/manual/en/html_node/Formatting-Code.html>?

> +    (arguments
> +      `(#:tests? #f))

Could you try to run the test suite or, as a last resort, add a comment
explaining why it is disabled?

> +    (home-page "https://github.com/corydolphin/flask-cors")
> +    (synopsis "A Flask extension adding a decorator for CORS support")
> +    (description
> +     "A Flask extension for handling Cross Origin Resource Sharing (CORS), 
> +making cross-origin AJAX possible.")

Please fix the issue reported by ‘guix lint’ for the synopsis and make a
full sentence for the description.  See
<https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html>.

Could you send an updated patch?

Thanks,
Ludo’.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#37535] [PATCH] gnu: Add python-flask-cors.
  2019-09-28 20:40 ` Ludovic Courtès
@ 2019-10-06 12:36   ` Ludovic Courtès
  2023-05-28 21:34     ` bug#37535: " Jelle Licht
  0 siblings, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2019-10-06 12:36 UTC (permalink / raw)
  To: Hamzeh Nasajpour; +Cc: 37535

Ping!  :-)

Ludovic Courtès <ludo@gnu.org> skribis:

> Hi Hamzeh,
>
> "Hamzeh Nasajpour" <h.nasajpour@pantherx.org> skribis:
>
>> * gnu/packages/python-web.scm (python-flask-cors): New variable.
>
> [...]
>
>> +(define-public python-flask-cors
>> +  (package
>> +  (name "python-flask-cors")
>> +    (version "3.0.7")
>
> The indentation is different from what we usually do.  Could you run
> ./etc/indent-code.el as noted at
> <https://guix.gnu.org/manual/en/html_node/Formatting-Code.html>?
>
>> +    (arguments
>> +      `(#:tests? #f))
>
> Could you try to run the test suite or, as a last resort, add a comment
> explaining why it is disabled?
>
>> +    (home-page "https://github.com/corydolphin/flask-cors")
>> +    (synopsis "A Flask extension adding a decorator for CORS support")
>> +    (description
>> +     "A Flask extension for handling Cross Origin Resource Sharing (CORS), 
>> +making cross-origin AJAX possible.")
>
> Please fix the issue reported by ‘guix lint’ for the synopsis and make a
> full sentence for the description.  See
> <https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html>.
>
> Could you send an updated patch?
>
> Thanks,
> Ludo’.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#37535: [PATCH] gnu: Add python-flask-cors.
  2019-10-06 12:36   ` Ludovic Courtès
@ 2023-05-28 21:34     ` Jelle Licht
  0 siblings, 0 replies; 4+ messages in thread
From: Jelle Licht @ 2023-05-28 21:34 UTC (permalink / raw)
  To: 37535-done; +Cc: Hamzeh Nasajpour, Ludovic Courtès


python-flask-cors is available on current guix master, so closing this.





^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-05-28 21:35 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-27 22:16 [bug#37535] [PATCH] gnu: Add python-flask-cors Hamzeh Nasajpour
2019-09-28 20:40 ` Ludovic Courtès
2019-10-06 12:36   ` Ludovic Courtès
2023-05-28 21:34     ` bug#37535: " Jelle Licht

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).