unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Mathieu Othacehe <m.othacehe@gmail.com>
To: Brice Waegeneire <brice@waegenei.re>
Cc: 40902@debbugs.gnu.org
Subject: [bug#40902] [PATCH] gnu: Add edid-decode.
Date: Tue, 28 Apr 2020 09:46:38 +0200	[thread overview]
Message-ID: <87k120uk69.fsf@gmail.com> (raw)
In-Reply-To: <20200427135550.20640-1-brice@waegenei.re> (Brice Waegeneire's message of "Mon, 27 Apr 2020 15:55:50 +0200")


Hello Brice,

You can add your copyright.

> +(define-public edid-decode
> +  (let ((commit "74b64180d67bb009d8d9ea1b6f18ad41aaa16396") ; 2020-04-22
> +        (revision "1"))
> +   (package
> +     (name "edid-decode")
> +     (version (git-version "0.0.0" revision commit))

The indentation of the block seems wrong.

> +     (source
> +      (origin
> +        (method git-fetch)
> +        (file-name (git-file-name name version))
> +        (uri (git-reference
> +              (url "git://linuxtv.org/edid-decode.git")
> +              (commit commit)))
> +        (sha256
> +         (base32 "0nirp5bza08zj5d8bjgcm0p869hdg3qg3mwa7999pjdrzmn7s2ah"))))
> +     (build-system gnu-build-system)
> +     (arguments
> +      `(#:tests? #f                     ; No test suite
> +        #:make-flags
> +        (list (string-append "DESTDIR=" (assoc-ref %outputs "out"))
> +              "bindir=/bin" "mandir=/share/man")
> +        #:phases
> +        (modify-phases %standard-phases
> +          (delete 'configure))))

When cross-compiling, a native binary is produced. This is because CXX
is set to 'g++' I guess. You need to do something similar to what is
done in the 'maradns' package.

Thanks,

Mathieu

  reply	other threads:[~2020-04-28  7:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-27 13:55 [bug#40902] [PATCH] gnu: Add edid-decode Brice Waegeneire
2020-04-28  7:46 ` Mathieu Othacehe [this message]
2020-04-28  9:54   ` Brice Waegeneire
2020-04-28  9:53 ` [bug#40902] [PATCH v2] " Brice Waegeneire
2020-04-29  9:41   ` bug#40902: " Mathieu Othacehe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k120uk69.fsf@gmail.com \
    --to=m.othacehe@gmail.com \
    --cc=40902@debbugs.gnu.org \
    --cc=brice@waegenei.re \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).