From: Brice Waegeneire <brice@waegenei.re>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: 40902@debbugs.gnu.org
Subject: [bug#40902] [PATCH] gnu: Add edid-decode.
Date: Tue, 28 Apr 2020 09:54:06 +0000 [thread overview]
Message-ID: <7de17236dbe22dcb942ef17c044de01d@waegenei.re> (raw)
In-Reply-To: <87k120uk69.fsf@gmail.com>
Hello Mathieu,
Thank you for taking the time to review this patch.
On 2020-04-28 07:46, Mathieu Othacehe wrote:
> Hello Brice,
>
> You can add your copyright.
I already added it in #40607[0], an unmerged patch adding usbguard.
>> +(define-public edid-decode
>> + (let ((commit "74b64180d67bb009d8d9ea1b6f18ad41aaa16396") ;
>> 2020-04-22
>> + (revision "1"))
>> + (package
>> + (name "edid-decode")
>> + (version (git-version "0.0.0" revision commit))
>
> The indentation of the block seems wrong.
You are correct, “guix lint” didn't mentioned it though. Fixed in v2.
>> + (source
>> + (origin
>> + (method git-fetch)
>> + (file-name (git-file-name name version))
>> + (uri (git-reference
>> + (url "git://linuxtv.org/edid-decode.git")
>> + (commit commit)))
>> + (sha256
>> + (base32
>> "0nirp5bza08zj5d8bjgcm0p869hdg3qg3mwa7999pjdrzmn7s2ah"))))
>> + (build-system gnu-build-system)
>> + (arguments
>> + `(#:tests? #f ; No test suite
>> + #:make-flags
>> + (list (string-append "DESTDIR=" (assoc-ref %outputs "out"))
>> + "bindir=/bin" "mandir=/share/man")
>> + #:phases
>> + (modify-phases %standard-phases
>> + (delete 'configure))))
>
> When cross-compiling, a native binary is produced. This is because CXX
> is set to 'g++' I guess. You need to do something similar to what is
> done in the 'maradns' package.
I never thought of testing that, I should start doing it. Fixed in v2.
[0]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=40607#28
- Brice
next prev parent reply other threads:[~2020-04-28 9:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 13:55 [bug#40902] [PATCH] gnu: Add edid-decode Brice Waegeneire
2020-04-28 7:46 ` Mathieu Othacehe
2020-04-28 9:54 ` Brice Waegeneire [this message]
2020-04-28 9:53 ` [bug#40902] [PATCH v2] " Brice Waegeneire
2020-04-29 9:41 ` bug#40902: " Mathieu Othacehe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7de17236dbe22dcb942ef17c044de01d@waegenei.re \
--to=brice@waegenei.re \
--cc=40902@debbugs.gnu.org \
--cc=m.othacehe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).