From: "Ludovic Courtès" <ludo@gnu.org>
To: John Soo <jsoo1@asu.edu>
Cc: 44460@debbugs.gnu.org
Subject: [bug#44460] Add copyright lines
Date: Tue, 10 Nov 2020 23:15:11 +0100 [thread overview]
Message-ID: <87k0usn9jk.fsf@gnu.org> (raw)
In-Reply-To: <878sbeoya2.fsf@asu.edu> (John Soo's message of "Fri, 06 Nov 2020 15:34:13 -0800")
Hi John,
John Soo <jsoo1@asu.edu> skribis:
>>From 48945997d9139ddc5e288512de3dda8d5accaf44 Mon Sep 17 00:00:00 2001
> From: John Soo <jsoo1@asu.edu>
> Date: Wed, 4 Nov 2020 07:51:52 -0800
> Subject: [PATCH] processes: Optionally normalize recutils output.
>
> * guix/scripts/processes.scm: Add "normalize" flag
[...]
> +@table @code
> +@item --normalize
> +Normalize the output records into record sets (@pxref{Record Sets,,,
> +recutils, GNU recutils manual}). Normalizing into record sets allows
> +joins across record types.
> +
> +@example
> +$ guix processes --normalize | \
> + recsel \
> + -j Session \
> + -t ChildProcess \
> + -p Session.PID,PID \
> + -e 'Session.ClientCommand ~ build'
> +Session_PID: 4278
> +PID: 4435
> +
> +Session_PID: 4278
> +PID: 4554
> +
> +Session_PID: 4278
> +PID: 4646
> +@end example
> +@end table
Nice! Right above the example, I’d suggest adding a sentence like “The
example below lists…” (what does it list actually? :-)).
In the default format, I wonder if we could already change split
‘ChildProcess’ into ‘ChildPID’ and ‘ChildCommand’, as you had initially
proposed on IRC; would that work?
> +(define (lock->record lock port)
> + (format port "LockHeld: ~a~%" lock))
Maybe ‘lock->recutils’ for consistency and to avoid confusion with
Scheme “records”?
> +(define (format-single-record port)
Maybe ‘daemon-sessions->recutils’? Should ‘sessions’ be a parameter for
clarity?
> + "Display denormalized session information to PORT."
> + (for-each (lambda (session)
> + (daemon-session->recutils session port)
> + (newline port))
^
Indentation is off.
> +(define (child-process->normalized-record process port)
> + "Display PROCESS record on PORT in normalized form"
> + (format port "PID: ~a" (process-id process))
> + (newline port)
> + (format port "Command:~{ ~a~}" (process-command process)))
> +
> +(define (format-normalized port)
Please add a docstring. Perhaps make ‘sessions’ a parameter?
> + (define sessions (daemon-sessions))
> +
> + (format port session-rec-type)
As reported by ‘-Wformat’, passing a non-literal format string is risky;
write this instead:
(display session-rec-type port)
> + (newline port)
> + (newline port)
> + (for-each
> + (lambda (session)
Preferable indent ‘for-each’ like so:
(for-each (lambda (session)
Likewise below.
> + (display (G_ "
> + --normalize display results as normalized record sets"))
Should it be ‘--format=normalized’ (just like we have ‘--format’ in
‘guix describe’, for instance)?
Could you send an updated patch?
Thanks!
Ludo’.
next prev parent reply other threads:[~2020-11-10 22:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 4:31 [bug#44460] [PATCH] processes: Optionally normalize recutils output John Soo
2020-11-05 15:49 ` [bug#44460] processes: Don't normalize Locks John Soo
2020-11-05 16:01 ` [bug#44460] Fixup the output of Session John Soo
2020-11-06 23:34 ` [bug#44460] Add copyright lines John Soo
2020-11-10 22:15 ` Ludovic Courtès [this message]
2020-11-11 17:51 ` John Soo
2020-11-11 17:59 ` John Soo
2020-11-11 18:47 ` John Soo
2020-11-12 10:58 ` Ludovic Courtès
2020-11-12 15:37 ` John Soo
2020-11-12 20:29 ` Ludovic Courtès
2020-11-13 5:33 ` John Soo
2020-11-13 16:16 ` John Soo
2020-11-29 22:49 ` bug#44460: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0usn9jk.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=44460@debbugs.gnu.org \
--cc=jsoo1@asu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).