unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Xinglu Chen <public@yoctocell.xyz>
To: phodina <phodina@protonmail.com>, 49703@debbugs.gnu.org
Subject: [bug#49703] [PATCH] gnu: Add rust-rot8
Date: Sat, 24 Jul 2021 15:19:51 +0200	[thread overview]
Message-ID: <87k0lf3l3c.fsf@yoctocell.xyz> (raw)
In-Reply-To: <JXhdJVbh6eBC7z3b4DRh2h2DMYc_8Jhksy1n9ewZoQhvAWXb7cadH5kzmIYMfdF0uIXzrEDYXS7xD-u2DcDNIfZ9B6nmdy0wYqhx2jDgsgw=@protonmail.com>

[-- Attachment #1: Type: text/plain, Size: 1540 bytes --]

On Fri, Jul 23 2021, phodina via Guix-patches via wrote:

> ---

Please write a proper commit message in the GNU ChangeLog format; you
can see the commit log for examples, or read the manual.

  <https://www.gnu.org/prep/standards/html_node/Change-Logs.html>

> +(define-public rust-rot8-0.1
> +  (package
> +    (name "rust-rot8")
> +    (version "0.1.3")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (crate-uri "rot8" version))
> +        (file-name
> +          (string-append name "-" version ".tar.gz"))
> +        (sha256
> +          (base32
> +            "15mhszk9qy2q49dpab4p0d9d4aph61yshaxjf02mhdx07n9qpnmh"))))
> +    (build-system cargo-build-system)
> +    (arguments
> +      `(#:cargo-inputs
> +        (("rust-clap" ,rust-clap-2)
> +         ("rust-glob" ,rust-glob-0.3)
> +         ("rust-regex" ,rust-regex-1)
> +         ("rust-serde" ,rust-serde-1)
> +         ("rust-serde-json" ,rust-serde-json-1))))
> +    (home-page "https://github.com/efernau/rot8")
> +    (synopsis
> +      "A screen rotation daemon")

Avoid articles like “A” or “An” in the synopsis.

> +    (description
> +      "Automatic rotation for modern Linux screen and input device. Compatible

The description should consist of full sentences, and there should be
two spaces after periods.  See the “16.4.4 Synopses and Descriptions” in
the manual for more details.  Make sure to run ‘guix lint’ to catch
common mistakes like these.  :)

Otherwise, LGTM.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

  reply	other threads:[~2021-07-24 13:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-23  3:27 [bug#49703] [PATCH] gnu: Add rust-rot8 phodina via Guix-patches via
2021-07-24 13:19 ` Xinglu Chen [this message]
2021-07-25 18:44 ` [bug#49703] [PATCH v2] gnu: Add rust-rot8-0.1 phodina via Guix-patches via
2021-09-18  8:02   ` phodina via Guix-patches via
2021-09-20 12:03     ` Xinglu Chen
2021-09-20 15:20       ` phodina via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k0lf3l3c.fsf@yoctocell.xyz \
    --to=public@yoctocell.xyz \
    --cc=49703@debbugs.gnu.org \
    --cc=phodina@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).