On Fri, Jul 23 2021, phodina via Guix-patches via wrote:

> ---

Please write a proper commit message in the GNU ChangeLog format; you
can see the commit log for examples, or read the manual.

  <https://www.gnu.org/prep/standards/html_node/Change-Logs.html>

> +(define-public rust-rot8-0.1
> +  (package
> +    (name "rust-rot8")
> +    (version "0.1.3")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (crate-uri "rot8" version))
> +        (file-name
> +          (string-append name "-" version ".tar.gz"))
> +        (sha256
> +          (base32
> +            "15mhszk9qy2q49dpab4p0d9d4aph61yshaxjf02mhdx07n9qpnmh"))))
> +    (build-system cargo-build-system)
> +    (arguments
> +      `(#:cargo-inputs
> +        (("rust-clap" ,rust-clap-2)
> +         ("rust-glob" ,rust-glob-0.3)
> +         ("rust-regex" ,rust-regex-1)
> +         ("rust-serde" ,rust-serde-1)
> +         ("rust-serde-json" ,rust-serde-json-1))))
> +    (home-page "https://github.com/efernau/rot8")
> +    (synopsis
> +      "A screen rotation daemon")

Avoid articles like “A” or “An” in the synopsis.

> +    (description
> +      "Automatic rotation for modern Linux screen and input device. Compatible

The description should consist of full sentences, and there should be
two spaces after periods.  See the “16.4.4 Synopses and Descriptions” in
the manual for more details.  Make sure to run ‘guix lint’ to catch
common mistakes like these.  :)

Otherwise, LGTM.