From: "Ludovic Courtès" <ludo@gnu.org>
To: Adam Kandur <manualbot@icloud.com>
Cc: 60192@debbugs.gnu.org
Subject: [bug#60192] [PATCH] gnu: Add python-tcod.
Date: Thu, 26 Jan 2023 10:51:39 +0100 [thread overview]
Message-ID: <87k019r5ck.fsf@gnu.org> (raw)
In-Reply-To: <20221218210216.3920-1-manualbot@icloud.com> (Adam Kandur's message of "Mon, 19 Dec 2022 00:02:16 +0300")
[-- Attachment #1: Type: text/plain, Size: 1448 bytes --]
Hi,
Adam Kandur <manualbot@icloud.com> skribis:
> * gnu/packages/game-development.scm (python-tcod): New variable.
I suggest the attached changes.
However, one comment:
> + ;; tests fail for a strange reason
> + ;; "ERROR docs/conf.py - FileNotFoundError",
> + ;; but this file is in the checkout
> + (arguments
> + '(#:tests? #f))
> + (native-inputs
> + (list sdl2
> + python-pcpp
> + python-pycparser
> + python-requests
> + python-pytest-runner
> + python-pytest-benchmark
> + python-pytest-cov))
> + (propagated-inputs
> + (list python-numpy
> + python-typing-extensions
> + python-cffi))
> + (home-page "https://github.com/libtcod/python-tcod")
> + (synopsis
> + "This library is a Python cffi port of libtcod")
That ‘FileNotFoundError’, could it be because libtcod itself is missing?
I would expect libtocd to be in ‘inputs’ since this package provides
bindings to libtcod, no?
> + (description
> + "A high-performance Python port of libtcod.
> +Includes the libtcodpy module for backwards compatibility with older projects.")
Please improve the synopsis and description as per:
https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html
Could you send an updated patch?
Thanks,
Ludo’.
[-- Attachment #2: Type: text/plain, Size: 980 bytes --]
diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm
index 304df3bd75..dd08241080 100644
--- a/gnu/packages/game-development.scm
+++ b/gnu/packages/game-development.scm
@@ -2584,11 +2584,12 @@ (define-public python-tcod
(package
(name "python-tcod")
(version "13.9.1")
+ (home-page "https://github.com/libtcod/python-tcod")
(source
(origin
(method git-fetch)
(uri (git-reference
- (url "https://github.com/libtcod/python-tcod")
+ (url home-page)
(commit commit)
(recursive? #true)))
(file-name (git-file-name name version))
@@ -2613,7 +2614,6 @@ (define-public python-tcod
(list python-numpy
python-typing-extensions
python-cffi))
- (home-page "https://github.com/libtcod/python-tcod")
(synopsis
"This library is a Python cffi port of libtcod")
(description
next prev parent reply other threads:[~2023-01-26 9:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-18 21:02 [bug#60192] [PATCH] gnu: Add python-tcod Adam Kandur via Guix-patches via
2023-01-26 9:51 ` Ludovic Courtès [this message]
2023-01-26 17:51 ` Adam Kandur via Guix-patches via
2023-03-22 11:00 ` [bug#60192] Update on issue Adam Kandur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k019r5ck.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=60192@debbugs.gnu.org \
--cc=manualbot@icloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).