From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 8PKlMFZN0mNl1AAAbAwnHQ (envelope-from ) for ; Thu, 26 Jan 2023 10:52:22 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id oLxPMFZN0mOkIQAAauVa8A (envelope-from ) for ; Thu, 26 Jan 2023 10:52:22 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7F2B81F544 for ; Thu, 26 Jan 2023 10:52:22 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pKyvS-0001r4-VV; Thu, 26 Jan 2023 04:52:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKyvP-0001oz-LW for guix-patches@gnu.org; Thu, 26 Jan 2023 04:52:08 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pKyvK-0006WH-Bs for guix-patches@gnu.org; Thu, 26 Jan 2023 04:52:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pKyvJ-000350-QH for guix-patches@gnu.org; Thu, 26 Jan 2023 04:52:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60192] [PATCH] gnu: Add python-tcod. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 26 Jan 2023 09:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60192 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Adam Kandur Cc: 60192@debbugs.gnu.org Received: via spool by 60192-submit@debbugs.gnu.org id=B60192.167472671211822 (code B ref 60192); Thu, 26 Jan 2023 09:52:01 +0000 Received: (at 60192) by debbugs.gnu.org; 26 Jan 2023 09:51:52 +0000 Received: from localhost ([127.0.0.1]:60749 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKyvA-00034c-7g for submit@debbugs.gnu.org; Thu, 26 Jan 2023 04:51:52 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55820) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKyv7-00034O-8s for 60192@debbugs.gnu.org; Thu, 26 Jan 2023 04:51:50 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKyv1-0006T7-Of; Thu, 26 Jan 2023 04:51:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=AtsulCkp15QGONrfrmnpVea7462Rqf/s+4Y+5qJOQ2k=; b=l67Q/0SxRoZzSmBh/NOR jgYFbYemAEmqSLj/a/1OGpI2WpuPCsThF/+gNjrSRF5Gep1dqK9mltQZ0rKGWjDsnJdDBQENb8Wna GmpBbSN8lvCDh5iAXvd2H/6uTS7pRX4pVC/Mduqahpgf31Ltk0hVvbWQFNWeNekCy0UkMNqN2dahp Tu+bylpEUz6vK5eX0l6mn/TKETiE7YINUD875ETUvFYct/cetT2yOFha1+0ZKDyYfrCd+tyP7eOsC psaNl/r+KNk7klcj0uHYo8ZHOzHH1FhJl0ViStsvPEPLrjoSUqizrJ5jfG/0i6Kz6AfugvMsafXXB Sxq8JEKX+h3ATw==; Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKyv0-00029P-3h; Thu, 26 Jan 2023 04:51:42 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20221218210216.3920-1-manualbot@icloud.com> Date: Thu, 26 Jan 2023 10:51:39 +0100 In-Reply-To: <20221218210216.3920-1-manualbot@icloud.com> (Adam Kandur's message of "Mon, 19 Dec 2022 00:02:16 +0300") Message-ID: <87k019r5ck.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1674726742; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=AtsulCkp15QGONrfrmnpVea7462Rqf/s+4Y+5qJOQ2k=; b=szGh78u/ESgnEQTw+w7BaVqfLkXqUCKn4SoDhaYbtAIm7rRU630ZiOd+4CwlwHdYHR9nSN 4ed298feUzCek83GWDNobNGmQLH2KP6ujo9t1xpRmcy/jkjf/V+fZCIgNECBbCUznxcTSw wAXXGQJey4ovVzj+wa2Dc2d677STr0vSWLUeI4h6/5TR8xeSY3j/NDh04CP27F68l+IK44 C1HmbXXyIHcXGmGJxvrbMfzcFDIY0B7aCwqioqDtRy/xNOxz3xsM6yPb+et4k4uHbD0fPf ed9PUIXR8VxEl91d4Y/rvRusyP9DHF0z+694qvbeneyIi9EDXDbswejZPJ74Nw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="l67Q/0Sx"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1674726742; a=rsa-sha256; cv=none; b=XM/tOYjyupCSPN0uhMC9TdhdhurA/duK/Uyh5wwQsziRE8WEpJVO8GGdz8VAICsLNT2uM/ cyL9jCKzCe+W30MHjDgDw4Ne+CM1YJ0fAMF2RXdyoXLHGT/JhoUo5Hr4mlM3XVLCOCp2hV FeoiX2G2iWc/3vw/88ff9o5ofi7Jemryz/2w9gC6o39+RKb/3RjAab0b/AKdAQ6lzms8sp g8FWthcPuRo3aeegj9A9YCsxZBsjLgGTJbTkZNtLDrrbZ94wOWlQqiEFgs4atMjiGNMS8D ex7QdMAza/j2OiPDYpTRg4e0pGhkwtiUCcALf36DB9Nxz3Ont82V+zPTSfOJdw== X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="l67Q/0Sx"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org X-Migadu-Spam-Score: -1.48 X-Spam-Score: -1.48 X-Migadu-Queue-Id: 7F2B81F544 X-TUID: DgQpK8dunk35 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, Adam Kandur skribis: > * gnu/packages/game-development.scm (python-tcod): New variable. I suggest the attached changes. However, one comment: > + ;; tests fail for a strange reason > + ;; "ERROR docs/conf.py - FileNotFoundError", > + ;; but this file is in the checkout > + (arguments > + '(#:tests? #f)) > + (native-inputs > + (list sdl2 > + python-pcpp > + python-pycparser > + python-requests > + python-pytest-runner > + python-pytest-benchmark > + python-pytest-cov)) > + (propagated-inputs > + (list python-numpy > + python-typing-extensions > + python-cffi)) > + (home-page "https://github.com/libtcod/python-tcod") > + (synopsis > + "This library is a Python cffi port of libtcod") That =E2=80=98FileNotFoundError=E2=80=99, could it be because libtcod itsel= f is missing? I would expect libtocd to be in =E2=80=98inputs=E2=80=99 since this package= provides bindings to libtcod, no? > + (description > + "A high-performance Python port of libtcod. > +Includes the libtcodpy module for backwards compatibility with older pro= jects.") Please improve the synopsis and description as per: https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html Could you send an updated patch? Thanks, Ludo=E2=80=99. --=-=-= Content-Type: text/plain Content-Disposition: inline diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm index 304df3bd75..dd08241080 100644 --- a/gnu/packages/game-development.scm +++ b/gnu/packages/game-development.scm @@ -2584,11 +2584,12 @@ (define-public python-tcod (package (name "python-tcod") (version "13.9.1") + (home-page "https://github.com/libtcod/python-tcod") (source (origin (method git-fetch) (uri (git-reference - (url "https://github.com/libtcod/python-tcod") + (url home-page) (commit commit) (recursive? #true))) (file-name (git-file-name name version)) @@ -2613,7 +2614,6 @@ (define-public python-tcod (list python-numpy python-typing-extensions python-cffi)) - (home-page "https://github.com/libtcod/python-tcod") (synopsis "This library is a Python cffi port of libtcod") (description --=-=-=--